Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors in tables missing #210

Open
ShaneBeee opened this issue Jun 1, 2023 · 5 comments
Open

Colors in tables missing #210

ShaneBeee opened this issue Jun 1, 2023 · 5 comments
Labels

Comments

@ShaneBeee
Copy link

I noticed the color is missing in tables. While this isn't a HUGE issue, it makes reading the table a little difficult.
How am I to keep track of my housewives...

Native Version with color in table:

Screenshot 2023-05-31 at 8 44 51 PM

Wiki-Dark without color in table

Screenshot 2023-05-31 at 8 44 44 PM
@AfroThundr3007730
Copy link
Member

Yeah, with the current way we used the !important hammer to strip a lot of the custom wikitable colors, there's many places where it affects color coding like this. We've been selectively adding rules to override those colors with ones from our palette, but we've only been targeting the more standardized colors in well known templates.

Fortunately, this is one of those cases that could be fixed easily with the latter approach. I'll take a look at fixing this later, or if you feel like getting your hands dirty, pull requests are welcome.

@pointydev
Copy link

pointydev commented Aug 19, 2023

In my opinion, it'd be nice to have a UserCSS option to completely disable colour overrides in wikitable cells that have custom colours. Some tables use colour legends to convey information, and I would much rather be blinded slightly and consume that information that have to turn off the entire theme and get flashbanged. An example of this can be found here:

dark
light

Another example can be found here:

dark
light

Thanks,
Elliott

@xeophyte
Copy link

xeophyte commented Dec 7, 2023

Same here
image

@neocharles
Copy link

neocharles commented Mar 5, 2024

I also noticed the coloring in the tables on https://en.wikipedia.org/wiki/Multicast_address has been removed.

image

image

@AfroThundr3007730
Copy link
Member

As is, these colors are made with inline styles in most places as the practice of using classes and template styles didn't happen until fairly recently in Wikipedia editing history. Hence, the reason they're so prevalent, and such pervasive use of !important overrides everywhere to capture them all. It's gotten to be messy, and cleaning it up is easier said than done.

We concluded a while back that the best way to solve it would be a rewrite of the non-mobile style (we already rewrote the mobile one), but since then, the Vector Modern skin was released and made default, and it's grown it's own dark mode, reducing the priority of a rewrite.

If anyone is interested in finding all the places that happen to affect these tables (there's a lot) and putting them behind an option, pull requests are certainly welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants