Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This computation:
k /= norm(k) + 1e-12
introduces an unphysical cutoff, and in particular it disagrees with SpinW.However, asking for
polarization_matrix([0,0,0])
is physically undefined. The correct thing to do is complicated, and not really experimentally accessible. The closest thing is to average over allk
in a neighborhood of (but not actually at) zero, as described in the code comment. The other option is to simply reportNaN
, which makes fewer assumptions, but also makes life much more annoying for plotting purposes.