Implement clippy suggestions

Author: Amit Gold

src/config.rs

@@ -25,7 +25,7 @@ pub fn config(
 
     match action.as_enum() {
         ActionEnum::Add { from: key, to: value } => {
-            let value = ::toml::Value::String(String::from(value));
+            let value = ::toml::Value::String(value);
             info!("Inserting {} -> {:?}.", key, value);
             debug!("Before: {}", pretty_print(&parsed));
             if opt.act {

src/deploy.rs

@@ -183,7 +183,7 @@ fn substitute_variables(content: String, variables: &Table) -> String {
             value,
         );
     }
-    content.to_string()
+    content
 }
 
 fn copy_if_changed(from: &Path, to: &Path) -> Result<(), ::std::io::Error> {

src/parse.rs

@@ -11,17 +11,17 @@ where
     T: DeserializeOwned,
 {
     let mut buf = String::new();
-    let mut f = File::open(filename).or_else(|_| { Err("open") })?;
-    f.read_to_string(&mut buf).or_else(|_| { Err("read") })?;
-    Ok(toml::from_str::<T>(&buf).or_else(|_| { Err("parse") })?)
+    let mut f = File::open(filename).map_err(|_| "open")?;
+    f.read_to_string(&mut buf).map_err(|_| "read")?;
+    Ok(toml::from_str::<T>(&buf).map_err(|_| "parse")?)
 }
 
 pub fn save_file<T>(filename: &Path, data: &T) -> Result<(), String>
 where
     T: Serialize,
 {
-    let mut f = File::create(filename).or_else(|_| { Err("open") })?;
-    let buf = toml::to_string(data).or_else(|_| { Err("serialize") })?;
-    f.write(buf.as_bytes()).or_else(|_| { Err("write") })?;
+    let mut f = File::create(filename).map_err(|_| "open")?;
+    let buf = toml::to_string(data).map_err(|_| "serialize")?;
+    f.write(buf.as_bytes()).map_err(|_| "write")?;
     Ok(())
 }