Fix Windows uninstaller crash with launcher strategy (#115)

* Attempt to fix Uninstall process

* Implement launcher strategy to fix uninstaller crash on Windows

Problem:
- Uninstaller crashed with access violation (0xc0000005) when executed from installation directory
- .NET Single-File runtime extraction fails in locked/restricted directories
- Crash occurred before Program.Main, making debugging impossible

Root Cause:
- When executed from AppData\Local\Programs, .NET runtime cannot extract bundled files
- Desktop execution worked fine, proving issue was location-dependent

Solution Implemented:
- Created UninstallLauncher.exe (WinExe, ~12MB single-file .NET 8 app)
- Launcher copies Uninstall.exe to %TEMP%\DotnetPackaging\Uninstallers\{GUID}\
- Executes uninstaller from %TEMP% and waits for completion (WaitForExit)
- Registry UninstallString points to launcher instead of uninstaller directly

Key Changes:
- New project: src/DotnetPackaging.Exe.UninstallLauncher/
  * WinExe (no console window)
  * Single-file, trimmed .NET 8
  * Handles copy, execute, and wait logic

- Modified src/DotnetPackaging.Exe.Installer/Core/Installer.cs:
  * Copies installer as Uninstall.exe to installation directory
  * Extracts UninstallLauncher.exe from embedded resources
  * Registry points to launcher

- Updated DotnetPackaging.Exe.Installer.csproj:
  * Embeds UninstallLauncher.exe as resource

- Comprehensive documentation in WARP.md and AGENTS.md:
  * Architecture and execution flow
  * Implementation details
  * Why it works
  * 6 future improvements (Native AOT, GitHub downloads, etc.)
  * Testing checklist
  * Lessons learned

Benefits:
✅ Uninstaller always runs from %TEMP% (no extraction issues)
✅ No console window (WinExe)
✅ No Windows 'program may not have uninstalled correctly' dialog (WaitForExit)
✅ Robust to %TEMP% cleanup (recreates on each run)
✅ Fallback to direct uninstaller if launcher extraction fails

Testing:
✅ Install/uninstall works correctly
✅ No console window appears
✅ No Windows error dialogs
✅ Uninstaller UI shows properly
✅ Works after multiple install/uninstall cycles

Future Improvements:
- Native AOT or C++ launcher (reduce from 12MB to <1MB)
- Download launcher from GitHub releases (smaller installer)
- Self-deleting temp uninstaller
- Retry logic for antivirus locks

See WARP.md lines 383-618 for complete documentation.

* Restore installation directory removal during uninstall

* Add UninstallLauncher project to solution

Author: SuperJMN

AGENTS.md

@@ -243,3 +243,177 @@ Windows EXE (.exe) 
   - Detección avanzada de ejecutable e icono (paridad con .deb/.appimage).
   - Modo silencioso.
   - Pruebas E2E en Windows.
+
+---
+
+## CRITICAL UNRESOLVED ISSUE: Uninstaller Crash (2025-11-20)
+
+### Problem Summary
+The Windows uninstaller (Uninstall.exe) crashes with access violation **before any managed code executes**.
+
+**Error Signature:**
+- Exception: 0xc0000005 (Access Violation)
+- Exit Code: 0x80131506 (.NET Runtime internal error)
+- Crash Offset: 0x00000000000b24f6 (consistent)
+- PE Timestamp: 0x68ffe47c (consistent despite rebuilds)
+- Assembly Version: 2.0.0.0
+
+**Critical Fact:** Crash occurs BEFORE Program.Main - no managed code runs at all.
+
+### Attempted Fixes (All Failed)
+1. Centralized Serilog logging to %TEMP%\DotnetPackaging.Installer\
+2. Removed Win32 P/Invoke (FindResource, LoadResource)
+3. Fixed Avalonia Dispatcher (base.OnFrameworkInitializationCompleted, Dispatcher.UIThread.Post)
+4. Rename strategy for locked directories
+5. Non-deterministic builds (Deterministic=false, AssemblyVersion=2.0.0.0)
+6. Multiple complete clean rebuilds (bin/obj/temp cache)
+7. Emergency logging at top of Program.Main (does not execute)
+
+### Key Evidence
+- Installer works perfectly
+- Uninstaller is IDENTICAL binary (created via File.Copy)
+- Same crash offset across all builds
+- Same PE timestamp despite forced non-deterministic builds
+- Emergency log (%TEMP%\dp-emergency.log) is never created = crash before Program.Main
+
+### Hypothesis
+Crash during .NET Runtime initialization or native DLL loading, NOT in managed code.
+Possibly Single-File bundling corruption when executable is copied.
+
+### Diagnostic Steps for Next Agent
+
+1. **Check if crash is before Main:**
+   `powershell
+   Get-Content C:\Users\JMN\AppData\Local\Temp\dp-emergency.log
+   `
+   If empty/missing → crash is definitely before managed entry point
+
+2. **Use WinDbg:**
+   Attach to Uninstall.exe and identify what module owns offset 0x00000000000b24f6
+
+3. **Compare binaries:**
+   `powershell
+   dumpbin /headers C:\Users\JMN\Desktop\AngorSetup.exe > installer-headers.txt
+   dumpbin /headers C:\Users\JMN\AppData\Local\Programs\AngorTest\Uninstall.exe > uninstaller-headers.txt
+   Compare-Object (Get-Content installer-headers.txt) (Get-Content uninstaller-headers.txt)
+   `
+
+4. **Try without Single-File:**
+   Modify DotnetPackaging.Exe.Installer.csproj:
+   - Remove or set PublishSingleFile=false
+   - Test if crash persists
+
+5. **Alternative approaches:**
+   - Don't copy installer - registry points to original with --uninstall flag
+   - Build uninstaller as separate project (not copy)
+   - Generate PowerShell uninstaller script instead
+
+### Code Locations
+- src/DotnetPackaging.Exe.Installer/Program.cs:15 - Emergency log (never executes)
+- src/DotnetPackaging.Exe.Installer/Core/Installer.cs:39 - File.Copy creates uninstaller
+- src/DotnetPackaging.Exe.Installer/App.axaml.cs:32 - base.OnFrameworkInitializationCompleted
+- src/DotnetPackaging.Exe.Installer/Core/LoggerSetup.cs - Logging config
+
+### Test Command
+`powershell
+# Generate installer
+dotnet run --project src\DotnetPackaging.Tool\DotnetPackaging.Tool.csproj -- exe from-project --project F:\Repos\angor\src\Angor\Avalonia\AngorApp.Desktop\AngorApp.Desktop.csproj --output C:\Users\JMN\Desktop\AngorSetup.exe --rid win-x64
+
+# Install to AngorTest, then run uninstaller
+C:\Users\JMN\AppData\Local\Programs\AngorTest\Uninstall.exe --uninstall
+`
+
+### Environment
+- Windows 11
+- .NET 8.0.22
+- Avalonia 11.x
+- Single-file self-contained deployment
+
+**CONFIRMED (2025-11-20 13:37):** dp-emergency.log created during install, NOT during uninstall.
+Crash is definitively BEFORE Program.Main. Problem is in .NET Runtime init or native DLL loading.
+
+### BREAKTHROUGH (2025-11-20 15:08)
+
+**ROOT CAUSE FOUND:** Problem is WHERE the executable runs from, NOT the binary itself.
+
+- Desktop\AngorSetup.exe --uninstall → ✅ WORKS
+- Programs\AngorTest\Uninstall.exe --uninstall → ❌ CRASHES
+- Both files IDENTICAL (SHA256 verified)
+
+**Conclusion:** .NET Single-File runtime fails to extract from installation directory.
+
+**FIX:** Don't copy uninstaller. Registry should point to Desktop installer with --uninstall flag.
+Or: Extract uninstaller to %TEMP% before running.
+
+### UPDATE (2025-11-20 15:27)
+
+**SOLUTION IMPLEMENTED:** Uninstaller now copies to %TEMP%
+- Modified Installer.cs:RegisterUninstaller() to copy uninstaller to:
+  %TEMP%\DotnetPackaging\Uninstallers\{appId}\Uninstall.exe
+- Registry UninstallString now points to %TEMP% location
+- This avoids .NET Single-File extraction issues in installation directory
+
+**NEW BLOCKER:** Avalonia Dispatcher crash prevents testing
+After implementing %TEMP% solution, installer crashes with:
+System.InvalidOperationException: Cannot perform requested operation because the Dispatcher shut down
+
+**Root cause:** Avalonia Dispatcher closes before async wizard completes.
+
+**Attempted fixes (ALL FAILED):**
+1. Dispatcher.UIThread.Post - async void doesn't wait
+2. Dispatcher.UIThread.InvokeAsync - same issue  
+3. desktopLifetime.Startup event - async void
+4. mainWindow.Opened event - async void
+5. ShutdownMode.OnMainWindowClose - closes too early
+6. MainWindow in OnFrameworkInitializationCompleted - same
+
+**Current state:**
+- Installer.cs: ✅ %TEMP% copy implemented
+- App.axaml.cs: ❌ Dispatcher shutdown issue
+- Cannot test %TEMP% solution until Dispatcher is fixed
+
+**Next steps:**
+- Fix Avalonia async initialization pattern
+- OR revert to working version and implement %TEMP% solution there
+- OR use synchronous UI initialization then async operations
+
+See WARP.md line 356 for full details.
+
+### FINAL SOLUTION (2025-11-20 16:15) ✅
+
+**Problem Solved:** Uninstaller crashes when executed from installation directory.
+
+**Root Cause:** .NET Single-File runtime extraction fails in locked/restricted directories.
+
+**Solution Implemented:** Native Launcher Pattern
+- Created UninstallLauncher.exe (WinExe, ~12MB, single-file .NET 8)
+- Launcher copies Uninstall.exe to %TEMP% and executes it
+- Registry points to launcher (stable location in install dir)
+- Launcher waits for uninstaller to complete (WaitForExit)
+
+**Key Files:**
+- src/DotnetPackaging.Exe.UninstallLauncher/ - New launcher project
+- src/DotnetPackaging.Exe.Installer/Core/Installer.cs - Extracts launcher from resources
+- src/DotnetPackaging.Exe.Installer/Resources/UninstallLauncher.exe - Embedded binary
+
+**Why It Works:**
+✅ Launcher always available (embedded in installer)
+✅ Uninstaller always runs from %TEMP% (no extraction issues)
+✅ No console window (WinExe)
+✅ No Windows error dialog (WaitForExit)
+✅ Robust to %TEMP% cleanup (launcher recreates on each run)
+
+**Future Improvements (see WARP.md lines 481-618):**
+1. Native AOT or C++ launcher (reduce from 12MB to <1MB)
+2. Download launcher from GitHub releases (smaller installer)
+3. Self-deleting temp uninstaller
+4. Retry logic for antivirus locks
+
+**Testing:**
+✅ Install/uninstall works correctly
+✅ No console window appears
+✅ No Windows error dialogs
+✅ Uninstaller UI shows properly
+✅ Works after multiple cycles
+
+See WARP.md lines 383-618 for complete documentation.

Directory.Packages.props

@@ -18,6 +18,7 @@
     <PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
     <PackageVersion Include="NyaFs" Version="1.0.8" />
     <PackageVersion Include="Octokit" Version="14.0.0" />
+    <PackageVersion Include="Projektanker.Icons.Avalonia.FontAwesome" Version="9.6.2" />
     <PackageVersion Include="ReactiveProperty" Version="9.8.0" />
     <PackageVersion Include="ReactiveUI.Avalonia" Version="11.3.8" />
     <PackageVersion Include="ReactiveUI.Fody" Version="19.5.41" />
@@ -27,8 +28,9 @@
     <PackageVersion Include="Avalonia.Themes.Fluent" Version="11.3.8" />
     <PackageVersion Include="Avalonia.Fonts.Inter" Version="11.3.8" />
     <PackageVersion Include="Avalonia.ReactiveUI" Version="11.3.6" />
-    <PackageVersion Include="Zafiro.Avalonia" Version="40.1.1" />
-    <PackageVersion Include="Zafiro.Avalonia.Dialogs" Version="40.1.1" />
+    <PackageVersion Include="Serilog.Sinks.File" Version="7.0.0" />
+    <PackageVersion Include="Zafiro.Avalonia" Version="41.0.2" />
+    <PackageVersion Include="Zafiro.Avalonia.Dialogs" Version="41.0.2" />
     <PackageVersion Include="Serilog.Sinks.Console" Version="6.1.1" />
     <PackageVersion Include="Serilog.Sinks.XUnit" Version="3.0.19" />
     <PackageVersion Include="SharpCompress" Version="0.41.0" />
@@ -49,12 +51,12 @@
     <PackageVersion Include="System.IO.Hashing" Version="10.0.0" />
     <PackageVersion Include="DeflateBlockCompressor" Version="0.0.13" />
     <PackageVersion Include="NuGet.Versioning" Version="7.0.0" />
-    <PackageVersion Include="Zafiro.Avalonia.Generators" Version="40.1.1" />
+    <PackageVersion Include="Zafiro.Avalonia.Generators" Version="41.0.2" />
     <PackageVersion Include="Zafiro.FileSystem" Version="41.2.1" />
-    <PackageVersion Include="Zafiro" Version="41.2.1" />
+    <PackageVersion Include="Zafiro" Version="41.2.4" />
     <PackageVersion Include="Zafiro.FileSystem.Unix" Version="41.2.1" />
     <PackageVersion Include="Zafiro.FileSystem.Local" Version="41.2.1" />
-    <PackageVersion Include="Zafiro.DivineBytes" Version="41.2.1" />
+    <PackageVersion Include="Zafiro.DivineBytes" Version="41.2.4" />
     <PackageVersion Include="DiscUtils" Version="0.16.13" />
   </ItemGroup>
 </Project>

DotnetPackaging.sln

@@ -43,6 +43,12 @@ Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DotnetPackaging.AppImage.Te
 EndProject
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DotnetPackaging.Dmg.Tests", "test\DotnetPackaging.Dmg.Tests\DotnetPackaging.Dmg.Tests.csproj", "{D97A5E33-6621-44DD-83D0-65F55F56E487}"
 EndProject
+Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{827E0CD3-B72D-47B6-A68D-7590B98EB39B}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DotnetPackaging.Exe.Tests", "src\DotnetPackaging.Exe.Tests\DotnetPackaging.Exe.Tests.csproj", "{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}"
+EndProject
+Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "DotnetPackaging.Exe.UninstallLauncher", "src\DotnetPackaging.Exe.UninstallLauncher\DotnetPackaging.Exe.UninstallLauncher.csproj", "{37EC0322-AF12-490D-92B7-1712DFDAB731}"
+EndProject
 Global
 	GlobalSection(SolutionConfigurationPlatforms) = preSolution
 		Debug|Any CPU = Debug|Any CPU
@@ -233,16 +239,41 @@ Global
 		{D97A5E33-6621-44DD-83D0-65F55F56E487}.Release|x64.Build.0 = Release|Any CPU
 		{D97A5E33-6621-44DD-83D0-65F55F56E487}.Release|x86.ActiveCfg = Release|Any CPU
 		{D97A5E33-6621-44DD-83D0-65F55F56E487}.Release|x86.Build.0 = Release|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Debug|x64.Build.0 = Debug|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Debug|x86.Build.0 = Debug|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Release|Any CPU.Build.0 = Release|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Release|x64.ActiveCfg = Release|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Release|x64.Build.0 = Release|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Release|x86.ActiveCfg = Release|Any CPU
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD}.Release|x86.Build.0 = Release|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Debug|Any CPU.Build.0 = Debug|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Debug|x64.ActiveCfg = Debug|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Debug|x64.Build.0 = Debug|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Debug|x86.ActiveCfg = Debug|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Debug|x86.Build.0 = Debug|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Release|Any CPU.ActiveCfg = Release|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Release|Any CPU.Build.0 = Release|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Release|x64.ActiveCfg = Release|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Release|x64.Build.0 = Release|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Release|x86.ActiveCfg = Release|Any CPU
+		{37EC0322-AF12-490D-92B7-1712DFDAB731}.Release|x86.Build.0 = Release|Any CPU
 	EndGlobalSection
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
 	EndGlobalSection
 	GlobalSection(NestedProjects) = preSolution
+		{79928283-5F6E-49F4-ACC4-FE5994DA1116} = {7E0C2A39-1C29-4B5D-9D45-1B6B7E7A77B6}
 		{6F3C5C5A-61E4-4D16-BE0D-6A0E9E9B3F9D} = {7E0C2A39-1C29-4B5D-9D45-1B6B7E7A77B6}
-		{2BD66C13-3A2A-45B5-9E36-F25F77292B10} = {7E0C2A39-1C29-4B5D-9D45-1B6B7E7A77B6}
 		{F090C5BD-3B1C-4D32-93AD-5D90E4819A69} = {7E0C2A39-1C29-4B5D-9D45-1B6B7E7A77B6}
-		{79928283-5F6E-49F4-ACC4-FE5994DA1116} = {7E0C2A39-1C29-4B5D-9D45-1B6B7E7A77B6}
+		{2BD66C13-3A2A-45B5-9E36-F25F77292B10} = {7E0C2A39-1C29-4B5D-9D45-1B6B7E7A77B6}
 		{D97A5E33-6621-44DD-83D0-65F55F56E487} = {7E0C2A39-1C29-4B5D-9D45-1B6B7E7A77B6}
+		{4AA3D5C2-1C8D-4E3A-901A-07E2FDAE59BD} = {827E0CD3-B72D-47B6-A68D-7590B98EB39B}
 	EndGlobalSection
 	GlobalSection(ExtensibilityGlobals) = postSolution
 		SolutionGuid = {1D869DF1-9147-472D-A3D9-D519518A6951}