Commit 17678da
authored
Refactor packaging, deployment, and dependency management (#150)
* Refactor and clean up DotnetDeployer codebase
Refactored several components in the DotnetDeployer project to improve maintainability and align with best practices. Key changes include type improvements, consistent use of `IPublishedDirectory`, encapsulated disposable object handling, and migration from package references to project references. Simplified redundant code and streamlined logic in multiple modules for better readability.
* Replace custom stub download logic with InstallerStubProvider
- Introduced `InstallerStubProvider` to encapsulate stub download and caching.
- Refactored `ExePackagingService` to use `InstallerStubProvider` for cleaner and more maintainable code.
- Added tests for `InstallerStubProvider` to validate stub retrieval behavior.
- Updated dependencies and bumped relevant Zafiro packages to versions `44.0.1` and `44.0.3`.
* Add detached installer support to ExePackagingService and update references
- Implemented logic to detach installer and stub creation in `ExePackagingService`.
- Added `DetachedInstallerTests` for validating detached installer handling.
- Switched from package references to project references for Zafiro modules.
- Cleaned up and refactored code related to stub and installer resource generation.
* Refactor publish process for better resource cleanup
Introduce `Disposable` patterns and improve resource handling during publish, packaging, and deployment. Added `TemporaryDirectory` utility and enhanced logging, ensuring temporary files are properly cleaned up. Updated relevant tests to validate changes.
* Migrate project references to package references and update Zafiro dependencies to 44.0.4.
* Migrate project references to package references in DotnetPackaging.Exe.Installer and restructure references in DotnetPackaging.Dmg to improve modularity.
* Refactor packaging commands to remove unnecessary use of `ByteSourceDetacher` and streamline byte source operations. Add end-to-end tests for packaging formats and introduce reusable `TempDirectory` utility for test isolation.1 parent 43970a1 commit 17678da
File tree
23 files changed
+841
-365
lines changed- src
- DotnetPackaging.Deb
- DotnetPackaging.Dmg
- DotnetPackaging.Exe.Installer
- DotnetPackaging.Exe
- DotnetPackaging.Msix
- DotnetPackaging.Tool/Commands
- DotnetPackaging
- Internal
- Publish
- test-input/TestApp
- test
- DotnetPackaging.E2E.Tests
- DotnetPackaging.Exe.Tests
23 files changed
+841
-365
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
| 34 | + | |
| 35 | + | |
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
| |||
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
57 | | - | |
58 | | - | |
59 | | - | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
7 | 8 | | |
8 | | - | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | 11 | | |
| 12 | + | |
13 | 13 | | |
14 | | - | |
15 | 14 | | |
16 | 15 | | |
17 | 16 | | |
18 | | - | |
19 | | - | |
| 17 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
6 | 7 | | |
7 | 8 | | |
8 | 9 | | |
| 10 | + | |
9 | 11 | | |
10 | 12 | | |
11 | | - | |
12 | 13 | | |
13 | 14 | | |
Lines changed: 0 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | 39 | | |
41 | 40 | | |
42 | | - | |
43 | 41 | | |
44 | 42 | | |
45 | 43 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
| 10 | + | |
10 | 11 | | |
11 | 12 | | |
12 | 13 | | |
| |||
0 commit comments