Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: we should display kmd to USD price upto 2 decimal point #70

Open
kashifali007 opened this issue Feb 5, 2017 · 1 comment
Open

Enhancement: we should display kmd to USD price upto 2 decimal point #70

kashifali007 opened this issue Feb 5, 2017 · 1 comment
Assignees
@pbca26
Milestone
0.3.1

Comments

@kashifali007
Copy link

Though conversion between KMD to USD seems correct but the total balance in USD is being displayed upto 17 decimal point which i think doesn't look pretty and which should become upto min 2 and max 4 decimal points.

snapshot is attached
floatingpoint
pbca26 added a commit that referenced this issue Feb 5, 2017
@pbca26
#70 added decimal places fix
c258c26
@pbca26
Copy link
Collaborator

pbca26 commented Feb 5, 2017

rounding

@kashifali007 rounding to 2 decimal places doesn't cover all cases. This is what I have on my end. If we apply your logic then I will only see 0.00 balance.

Anyway, I added a workaroud. Let me know if it will fix the issue on your end.

@imboogieman imboogieman modified the milestone: 0.3.1 Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pbca26 pbca26

Labels
None yet
Projects
None yet
Milestone
0.3.1
Development

No branches or pull requests
3 participants
@pbca26 @imboogieman @kashifali007