Skip to content

Commit df0e70a

Browse files
authored
comment: added todo comments for mahadi. Also remove treagent and enc… (#188)
Just added comments needed to help mahadi
1 parent 9902872 commit df0e70a

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

DARE-Control.sln

Lines changed: 2 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,9 @@ Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TRE-UI", "src\TRE-UI\TRE-UI
2424
EndProject
2525
Project("{E53339B2-1760-4266-BCC7-CA923CBCF16C}") = "docker-compose", "docker-compose.dcproj", "{BC0287B0-FFB6-490D-8F6C-44E02A012528}"
2626
EndProject
27-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "TREAgent", "src\TREAgent\TREAgent.csproj", "{97D09002-2CA7-4D78-81E6-36AC912F089B}"
27+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Data-Egress-API", "src\Data-Egress-API\Data-Egress-API.csproj", "{68369D1D-B5AE-4CED-944C-3FEF0EB23414}"
2828
EndProject
29-
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "PasswordEncryptor", "..\PasswordEncryptor\PasswordEncryptor.csproj", "{E3113006-5E32-451D-9541-CEA84F55EC9D}"
30-
EndProject
31-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Data-Egress-API", "src\Data-Egress-API\Data-Egress-API.csproj", "{68369D1D-B5AE-4CED-944C-3FEF0EB23414}"
32-
EndProject
33-
Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "Data-Egress-UI", "src\Data-Egress-UI\Data-Egress-UI.csproj", "{80C9C407-D56A-4FD1-9FE3-58B046729ADC}"
29+
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "Data-Egress-UI", "src\Data-Egress-UI\Data-Egress-UI.csproj", "{80C9C407-D56A-4FD1-9FE3-58B046729ADC}"
3430
EndProject
3531
Global
3632
GlobalSection(SolutionConfigurationPlatforms) = preSolution
@@ -62,14 +58,6 @@ Global
6258
{BC0287B0-FFB6-490D-8F6C-44E02A012528}.Debug|Any CPU.Build.0 = Debug|Any CPU
6359
{BC0287B0-FFB6-490D-8F6C-44E02A012528}.Release|Any CPU.ActiveCfg = Release|Any CPU
6460
{BC0287B0-FFB6-490D-8F6C-44E02A012528}.Release|Any CPU.Build.0 = Release|Any CPU
65-
{97D09002-2CA7-4D78-81E6-36AC912F089B}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
66-
{97D09002-2CA7-4D78-81E6-36AC912F089B}.Debug|Any CPU.Build.0 = Debug|Any CPU
67-
{97D09002-2CA7-4D78-81E6-36AC912F089B}.Release|Any CPU.ActiveCfg = Release|Any CPU
68-
{97D09002-2CA7-4D78-81E6-36AC912F089B}.Release|Any CPU.Build.0 = Release|Any CPU
69-
{E3113006-5E32-451D-9541-CEA84F55EC9D}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
70-
{E3113006-5E32-451D-9541-CEA84F55EC9D}.Debug|Any CPU.Build.0 = Debug|Any CPU
71-
{E3113006-5E32-451D-9541-CEA84F55EC9D}.Release|Any CPU.ActiveCfg = Release|Any CPU
72-
{E3113006-5E32-451D-9541-CEA84F55EC9D}.Release|Any CPU.Build.0 = Release|Any CPU
7361
{68369D1D-B5AE-4CED-944C-3FEF0EB23414}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
7462
{68369D1D-B5AE-4CED-944C-3FEF0EB23414}.Debug|Any CPU.Build.0 = Debug|Any CPU
7563
{68369D1D-B5AE-4CED-944C-3FEF0EB23414}.Release|Any CPU.ActiveCfg = Release|Any CPU
@@ -91,8 +79,6 @@ Global
9179
{74A67920-5A7D-4C10-B1DB-8DE5AD25FF35} = {BCA7B4D1-726B-46EA-90D1-2BD3ACD5154A}
9280
{7E5C3A67-D4F6-490D-B24A-BCB1008DC7CA} = {505AD4FB-0822-4989-9A01-1F56C3820D0D}
9381
{0F576ABA-E84A-4176-8AB9-D15C76952305} = {ED66814A-91F3-4E06-AE48-B7A9F666659E}
94-
{97D09002-2CA7-4D78-81E6-36AC912F089B} = {505AD4FB-0822-4989-9A01-1F56C3820D0D}
95-
{E3113006-5E32-451D-9541-CEA84F55EC9D} = {505AD4FB-0822-4989-9A01-1F56C3820D0D}
9682
{68369D1D-B5AE-4CED-944C-3FEF0EB23414} = {BCA7B4D1-726B-46EA-90D1-2BD3ACD5154A}
9783
{80C9C407-D56A-4FD1-9FE3-58B046729ADC} = {ED66814A-91F3-4E06-AE48-B7A9F666659E}
9884
EndGlobalSection

src/DARE-API/Services/ConsumeInternalMessageService.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ private void Process(IMessage<int> message, MessageReceivedInfo info)
4545
{
4646
var sub = _dbContext.Submissions.First(s => s.Id == message.Body);
4747

48+
//TODO: Mahadi copy crate from external to local submission (if in external)
49+
4850
//TODO: Validate format of Crate
4951

5052
var dbproj = sub.Project;

src/TRE-API/Controllers/SubmissionController.cs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ public IActionResult EgressResults([FromBody] EgressReview review)
126126
[SwaggerResponse(statusCode: 200, type: typeof(string), description: "")]
127127
public IActionResult FinalOutcome([FromBody] FinalOutcome outcome)
128128
{
129+
//TODO: Mahadi copy FinalOutcome file from tre output bucket to submission output bucket
129130
throw new NotImplementedException();
130131
}
131132

src/TRE-API/DoAgentWork.cs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -247,6 +247,8 @@ public void Execute()
247247
}
248248
else
249249
{
250+
251+
//TODO: Mahadi copy from submission input bucket to tre input bucket
250252
// The TES message
251253
var tesMessage = JsonConvert.DeserializeObject<TesTask>(aSubmission.TesJson);
252254
var processedOK = true;

0 commit comments

Comments
 (0)