Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/SWED-2268 expandable component preview #902

Merged

Conversation

goldenraphti
Copy link
Collaborator

Description

https://payexjira.atlassian.net/browse/SWED-2268

  • add a button in the DS documentation website to offer the user the possibility to expand the preview container to full-screen
  • this is an opt-in feature added to the preview component. It is disabled by default. And, for start, is only enabled for the Topbar component. We can iterate on it later on. But working on the topbar as the next new big UI change it was making a lot of sense

Motivation and Context

How Has This Been Tested?

  • specific tests have not been added (yet?)
  • all old tests are passing

Screenshots

Screenshot 2023-09-01 at 11 32 51

Screenshot 2023-09-01 at 11 33 49

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have updated the CHANGELOG document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Review instructions

Review instructions

@goldenraphti goldenraphti changed the title Feature/swed 2268 expandable component preview feature/SWED-2268 expandable component preview Sep 1, 2023
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #902 (25dce2f) into develop (a5ecd5d) will decrease coverage by 0.19%.
Report is 1 commits behind head on develop.
The diff coverage is 7.14%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #902      +/-   ##
===========================================
- Coverage    72.85%   72.67%   -0.19%     
===========================================
  Files          211      211              
  Lines         4484     4497      +13     
  Branches      1249     1258       +9     
===========================================
+ Hits          3267     3268       +1     
- Misses        1081     1092      +11     
- Partials       136      137       +1     
Files Changed Coverage Δ
...ComponentsDocumentation/components/Topbar/index.js 50.00% <ø> (ø)
src/App/docutils/ComponentPreview/index.js 36.77% <7.14%> (-1.81%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372b4f7...25dce2f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Size Change: +805 B (0%)

Total Size: 1.1 MB

Filename Size Change
dist/scripts/payex.js 322 kB +215 B (0%)
dist/scripts/swedbankpay.js 322 kB +216 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/designguide/scripts/dg-dashboard.js 72.9 kB 0 B
dist/designguide/scripts/dg.js 24.5 kB 0 B
dist/designguide/styles/documentation-payex.css 8.3 kB +93 B (+1%)
dist/designguide/styles/documentation-swedbankpay.css 7.41 kB +94 B (+1%)
dist/designguide/styles/payex.css 41.1 kB 0 B
dist/designguide/styles/swedbankpay.css 39.1 kB 0 B
dist/scripts/9438.js 71.8 kB 0 B
dist/scripts/dg-dashboard.js 72.9 kB 0 B
dist/scripts/dg.js 24.5 kB 0 B
dist/styles/documentation-payex.css 8.3 kB +93 B (+1%)
dist/styles/documentation-swedbankpay.css 7.41 kB +94 B (+1%)
dist/styles/payex.css 41.1 kB 0 B
dist/styles/swedbankpay.css 39.1 kB 0 B

compressed-size-action

@goldenraphti goldenraphti merged commit f53154c into develop Sep 5, 2023
8 checks passed
@github-actions github-actions bot deleted the feature/SWED-2268-expandable_component_preview branch September 5, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants