Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UILabel instantiation called on each layoutTrack #33

Open
mattgallivan opened this issue Jun 1, 2017 · 0 comments
Open

UILabel instantiation called on each layoutTrack #33

mattgallivan opened this issue Jun 1, 2017 · 0 comments
Assignees

Comments

@mattgallivan
Copy link

I was having an issue with labels being recreated on view resize. Specifically, the labels appeared to drop in from the top left which wasn't exactly what I wanted. This was a result of the labels being recreated whenever layoutTrack was called.

To fix this, I made a change so that the labels are only recreated when the names array is set. layoutTrack then only modifies the frames of the labels. When animating, this looks a bit better (in my opinion).

Is this a modification you'd look at a pull request for? (I'm not sure the extent of my changes but I believe they function correctly.)

@SwiftArchitect SwiftArchitect self-assigned this Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants