refactor #154 Remove container cleanup in test environment (1.3) (Zales0123)

This PR was merged into the 1.3 branch.

Discussion
----------

changes incorporated from Sylius/Sylius#10067

Commits
-------

0cb492e Remove container cleanup in test environment

Author: pamil

.travis.yml

@@ -19,7 +19,7 @@ env:
         - SYLIUS_BUILD_DIR=etc/build
     matrix:
         - SYMFONY_VERSION="3.4.*"
-        - SYMFONY_VERSION="4.1.*"
+        - SYMFONY_VERSION="4.2.*"
 
 before_install:
     - phpenv config-rm xdebug.ini

tests/Application/Kernel.php

@@ -4,7 +4,6 @@
 
 namespace Tests\Acme\SyliusExamplePlugin\Application;
 
-use ProxyManager\Proxy\VirtualProxyInterface;
 use PSS\SymfonyMockerContainer\DependencyInjection\MockerContainer;
 use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
 use Symfony\Component\Config\Loader\DelegatingLoader;
@@ -31,13 +30,6 @@ final class Kernel extends BaseKernel
 
     private const CONFIG_EXTS = '.{php,xml,yaml,yml}';
 
-    private const IGNORED_SERVICES_DURING_CLEANUP = [
-        'kernel',
-        'http_kernel',
-        'liip_imagine.mime_type_guesser',
-        'liip_imagine.extension_guesser',
-    ];
-
     public function getCacheDir(): string
     {
         return $this->getProjectDir() . '/var/cache/' . $this->environment;
@@ -58,25 +50,6 @@ public function registerBundles(): iterable
         }
     }
 
-    public function shutdown(): void
-    {
-        if (!$this->isTestEnvironment()) {
-            parent::shutdown();
-
-            return;
-        }
-
-        if (false === $this->booted) {
-            return;
-        }
-
-        $container = $this->getContainer();
-
-        parent::shutdown();
-
-        $this->cleanupContainer($container);
-    }
-
     protected function configureContainer(ContainerBuilder $container, LoaderInterface $loader): void
     {
         $container->addResource(new FileResource($this->getProjectDir() . '/config/bundles.php'));
@@ -130,45 +103,4 @@ private function isTestEnvironment(): bool
     {
         return 0 === strpos($this->getEnvironment(), 'test');
     }
-
-    /**
-     * Remove all container references from all loaded services
-     */
-    private function cleanupContainer(ContainerInterface $container): void
-    {
-        $containerReflection = new \ReflectionObject($container);
-        $containerServicesPropertyReflection = $containerReflection->getProperty('services');
-        $containerServicesPropertyReflection->setAccessible(true);
-
-        $services = $containerServicesPropertyReflection->getValue($container) ?: [];
-        foreach ($services as $serviceId => $service) {
-            if (null === $service) {
-                continue;
-            }
-
-            if (in_array($serviceId, self::IGNORED_SERVICES_DURING_CLEANUP, true)) {
-                continue;
-            }
-
-            $serviceReflection = new \ReflectionObject($service);
-
-            if ($serviceReflection->implementsInterface(VirtualProxyInterface::class)) {
-                continue;
-            }
-
-            $servicePropertiesReflections = $serviceReflection->getProperties();
-            $servicePropertiesDefaultValues = $serviceReflection->getDefaultProperties();
-            foreach ($servicePropertiesReflections as $servicePropertyReflection) {
-                $defaultPropertyValue = null;
-                if (isset($servicePropertiesDefaultValues[$servicePropertyReflection->getName()])) {
-                    $defaultPropertyValue = $servicePropertiesDefaultValues[$servicePropertyReflection->getName()];
-                }
-
-                $servicePropertyReflection->setAccessible(true);
-                $servicePropertyReflection->setValue($service, $defaultPropertyValue);
-            }
-        }
-
-        $containerServicesPropertyReflection->setValue($container, null);
-    }
 }