going to CRAN

Author: dcooley

DESCRIPTION

@@ -2,7 +2,7 @@ Package: mapdeck
 Type: Package
 Title: Interactive Maps Using 'Mapbox GL JS' and 'Deck.gl'
 Version: 0.3.0
-Date: 2020-03-18
+Date: 2020-03-22
 Authors@R: c(
     person("David", "Cooley", ,"dcooley@symbolix.com.au", role = c("aut", "cre"))
     )

NEWS.md

@@ -28,7 +28,7 @@
 * `add_arc` gets `tilt` and `height` arguments
 * `add_arc` gets `brush_radius` argument for brushing
 * opacity values can be in [0,1) OR [0,255]
-* layeres work without an access token
+* layers work without an access token
 * `add_title()` for adding titles to map
 * `add_scatterplot` gets `stroke_colour` and `stroke_width` arguments
 * `add_hexagon` gets transitions

R/map_layer_mesh.R

@@ -33,18 +33,18 @@ find_mesh_index <- function( data ) {
 #' @inheritSection add_arc id
 #'
 #' @examples
+#' \donttest{
 #'
-#' x <- structure(list(vb = structure(c(0, 0, 0, 1, 100, 0, 0, 1, 0,
-#' -42, 0, 1), .Dim = 4:3), it = structure(1:3, .Dim = c(3L, 1L)),
-#' material = list(), normals = NULL, texcoords = NULL, meshColor = "vertices"),
-#'  class = c("mesh3d", "shape3d"))
+#' ## exaggerate the elevation slightly
+#' m <- melbourne_mesh
+#' m$vb[3, ] <- m$vb[3, ] * 50
 #'
-#' set_token("MAPBOX_API_TOKEN")
+#'mapdeck() %>%
+#'  add_mesh(
+#'  data = m
+#'  )
 #'
-#' mapdeck() %>%
-#'   add_mesh(
-#' 	  data = x
-#'   )
+#' }
 #'
 #' @details
 #'

cran-comments.md

@@ -4,3 +4,7 @@
 * updated to correctly link to geojsonsf and spatialwidget
 * various updates to functions
 
+## Tests
+
+* rhub - check for cran
+* rhub - check with sanitizers

man/add_mesh.Rd

@@ -99,8 +99,10 @@ Rcpp::List mesh_to_sf( Rcpp::List& mesh, Rcpp::StringVector vertices ) {
 
 // [[Rcpp::export]]
 Rcpp::List rcpp_mesh_geojson(
-		Rcpp::List mesh, Rcpp::List params,
-		Rcpp::StringVector vertices, int digits
+		Rcpp::List mesh,
+		Rcpp::List params,
+		Rcpp::StringVector vertices,
+		int digits
 	) {
 
 	Rcpp::DataFrame data = mesh_to_sf( mesh, vertices );
@@ -112,7 +114,7 @@ Rcpp::List rcpp_mesh_geojson(
 
 	int data_rows = data.nrows();
 
-	std::string geometry_columns = "geometry";
+	Rcpp::StringVector geometry_columns({"geometry"});
 
 	Rcpp::List lst_defaults = mesh_defaults( data_rows );  // initialise with defaults
 	std::unordered_map< std::string, std::string > mesh_colours = mapdeck::layer_colours::fill_colours;