Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections are inscrutable #222

Open
jakebeal opened this issue Jan 16, 2018 · 11 comments
Open

Collections are inscrutable #222

jakebeal opened this issue Jan 16, 2018 · 11 comments

Comments

@jakebeal
Copy link

I would like to combine five devices into one collection, cannot figure out how to browse the contents of collections in SBOLDesigner

@jakebeal jakebeal added the bug label Jan 16, 2018
@cjmyers
Copy link
Contributor

cjmyers commented Jan 16, 2018

The procedure should be as follows but will only work completely in 3.0:

  1. Create a new SBOL document (far left icon)
  2. Build your first device be sure to give it a unique id using pencil icon.
  3. Save your current design (fifth icon)
  4. Upload your design to a SynBioHub instance selecting to create a new Collection.
  5. Create a new part in this document (third icon)
  6. Build your second device again with a new id.
  7. Save your current design.
  8. Upload your design to a SynBioHub instance selecting to add to an existing Collection.
  9. Repeat for next 3 devices.
  10. You should now be able to browse your new collection on SynBioHub in your private repository.

Would be great to create a video for this potentially very common use case. Also, we should add to SynBioHub a way to upload an entire working document rather than just the design being edited.

@cjmyers cjmyers added this to the SBOLDesigner 3.0 milestone Jan 16, 2018
@jakebeal
Copy link
Author

  • The pencil icon is non-intuitive. I kept clicking on the "> Unnamed Part" button to try to name it and edit its information. Editing the selected part by double-clicking is quite intuitive to me --- I never even went looking for an icon. The "> Unnamed Part" button really invites a similar interaction.
  • The "create a new part in this document" button implies the ability to create and manage collections in the document. It's even sort-of doing it.
  • If I uploaded to SynBioHub and found that only some of the parts in the document had uploaded, I would be confused and frustrated. The common semantics of the button as we are trained from other applications are "save to cloud", not "export a small fragment to the cloud"
  • Uploading to SynBioHub is misnamed right now, as "SBOL stack"

@cjmyers
Copy link
Contributor

cjmyers commented Jan 17, 2018 via email

@michael13162
Copy link
Contributor

michael13162 commented Jan 25, 2018

Designs must now be saved before uploading to SynBioHub. I also found and fixed some bugs along the way. Should probably test more as well.

@cjmyers
Copy link
Contributor

cjmyers commented Jan 25, 2018 via email

@cjmyers
Copy link
Contributor

cjmyers commented Jan 29, 2018

Still need to do the following:

  1. Add ability to edit part by clicking on the name in the left corner.
  2. Add an option to the upload that allows the user to select to upload only the current working design. If checked, it is the current behavior, else it should upload the entire working document. The later should be the default.

As for creating a collection for the document, I think we can let SynBioHub handle that when the parts are uploaded.

@cjmyers cjmyers removed their assignment Jan 29, 2018
@michael13162
Copy link
Contributor

The user is now asked whether they want to upload the current design or working document. I've tested it, and it seems to be working. I think this is useful to always bring up since it makes it more clear what's being uploaded (people may assume the wrong thing and be confused/accidentally lose data).

@cjmyers
Copy link
Contributor

cjmyers commented Jan 30, 2018 via email

@michael13162
Copy link
Contributor

It is checked in. It should pop up whenever you go to upload something.

@cjmyers
Copy link
Contributor

cjmyers commented Jan 30, 2018 via email

@michael13162
Copy link
Contributor

Edit part by clicking on the top left corner name is actually difficult because of 1) updating the internal SBOLDesigner data model and 2) refreshing the UI properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants