Fix saving of chord simulator parameter

soymonitus · soymonitus · commit 7d2e94c09244 · 2025-01-24T19:32:18.000+01:00
diff --git a/src/deluge/modulation/arpeggiator.cpp b/src/deluge/modulation/arpeggiator.cpp
@@ -1446,9 +1446,9 @@ bool ArpeggiatorSettings::readCommonTagsFromFile(Deserializer& reader, char cons
 		updatePresetFromCurrentSettings();
 	}
 	else if (!strcmp(tagName, "chordType")) {
-		uint8_t chordTypeIndex = (uint8_t)reader.readTagOrAttributeValueInt();
-		if (chordTypeIndex >= 0 && chordTypeIndex < MAX_CHORD_TYPES) {
-			chordTypeIndex = chordTypeIndex;
+		uint8_t value = (uint8_t)reader.readTagOrAttributeValueInt();
+		if (value >= 0 && value < MAX_CHORD_TYPES) {
+			chordTypeIndex = value;
 		}
 	}
 	else if (!strcmp(tagName, "noteMode")) {

Original file line number	Diff line number	Diff line change
`@@ -1446,9 +1446,9 @@ bool ArpeggiatorSettings::readCommonTagsFromFile(Deserializer& reader, char cons`
`1446`	`1446`	`updatePresetFromCurrentSettings();`
`1447`	`1447`	`}`
`1448`	`1448`	`else if (!strcmp(tagName, "chordType")) {`
`1449`		`- uint8_t chordTypeIndex = (uint8_t)reader.readTagOrAttributeValueInt();`
`1450`		`- if (chordTypeIndex >= 0 && chordTypeIndex < MAX_CHORD_TYPES) {`
`1451`		`- chordTypeIndex = chordTypeIndex;`
	`1449`	`+ uint8_t value = (uint8_t)reader.readTagOrAttributeValueInt();`
	`1450`	`+ if (value >= 0 && value < MAX_CHORD_TYPES) {`
	`1451`	`+ chordTypeIndex = value;`
`1452`	`1452`	`}`
`1453`	`1453`	`}`
`1454`	`1454`	`else if (!strcmp(tagName, "noteMode")) {`