-
Notifications
You must be signed in to change notification settings - Fork 2
Link and announcement indexes query DB a lot #73
Comments
Caused by permission checks querying for the announceable/linkable of each entry. |
Is there really all that much that can be done about this without creating security issues around permissions? |
@gxrneyme Unfortunately our ORM doesn't support the kind of query we need to be able to fix this, so this is kind of an on-hold issue until it does (or we implement it ourselves). |
What were you thinking in terms of queries, @kailan? |
@gxrneyme When fetching the announcements/links, we need to add This could be mitigated for certain views such as departments/activities by only running the permission check once (instead of for each link) since we know that the results are all the same. |
@kailan Good thinking on the departments/activities front — would likely speed things up a lot. Will take a look sometime and see if I can put you a PR together. |
The text was updated successfully, but these errors were encountered: