Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocKey: Triage on the type ObjectDescriptor #29

Open
SUMUKHA-PK opened this issue Oct 10, 2020 · 2 comments
Open

LocKey: Triage on the type ObjectDescriptor #29

SUMUKHA-PK opened this issue Oct 10, 2020 · 2 comments
Assignees

Comments

@SUMUKHA-PK
Copy link
Contributor

SUMUKHA-PK commented Oct 10, 2020

  • For argument: Since LockDescriptor wont have an Owner field once sessions have been implemented, there wont be any need for the ObjectDescriptor type.

  • Against argument: As we have seen the need of the ObjectDescriptor type in the past, we might need to add more fields to LockDescriptor in the future and then we would need to revert back to having 2 types.

  • Conflict: While calling Acquire or Release in the client, the argument - Descriptor, must not have an option for the user to send any sort of OwnerID on account of security. However, we need owner data further down the line because it needs to be passed on to the lockservice to verify that the user process that is manipulating the lock has access to do so.
    Thus, the lockclient functions must have a different argument input - say ObjectDescriptor but LockDescriptor must stay so that it can be passed on later to the internal lockservice functions.

SUMUKHA-PK added a commit that referenced this issue Oct 10, 2020
…criptor and LockDescriptor separation, solving #29
@suraj44
Copy link
Contributor

suraj44 commented Oct 10, 2020

@SUMUKHA-PK I think LockDescriptor needs to keep the OwnerID field. Instead, the only argument to Acquire() will be the object. Internally, before sending the HTTP request to the server, the client can add the sessionID to the request.

@SUMUKHA-PK
Copy link
Contributor Author

Yes that's what has happened now. Check the latest commit on the sessions PR. @suraj44

@SUMUKHA-PK SUMUKHA-PK changed the title Removal the type ObjectDescriptor Triage on the type ObjectDescriptor Oct 11, 2020
@SUMUKHA-PK SUMUKHA-PK self-assigned this Oct 11, 2020
@SUMUKHA-PK SUMUKHA-PK changed the title Triage on the type ObjectDescriptor LocKey: Triage on the type ObjectDescriptor Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants