Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocKey: separate lockclient and lockservice tests #33

Open
SUMUKHA-PK opened this issue Oct 22, 2020 · 0 comments
Open

LocKey: separate lockclient and lockservice tests #33

SUMUKHA-PK opened this issue Oct 22, 2020 · 0 comments
Assignees

Comments

@SUMUKHA-PK
Copy link
Contributor

The current situation is like this: One single test file in client which has all tests in the name of TestLockService.
This is misleading and not package specific.
I propose the following:

  1. lockservice tests: These tests will be the same as the existing ones but they call the lockservice API instead of the lockclient API. Basically all the acquire, release without thinking of a client.
  2. lockclient tests: These tests will be only in the domain of the client and use the client interface functions. No calls to the lockservice will be made like in the current tests and all those will be mocked to return the expected value.
  3. LocKey tests: This is IMO what we already have and maybe can be moved outside the two packages in the root directory with an appropriate name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants