[#10597] Instructor edit session page: page refreshes by itself on first loading (#11172)

* Remove editSession and editSessionEventHandle for instructor

* Remove editSessionEvent in sessions-table.component.ts

Co-authored-by: PHONG BACH <phongnghinhbach@gmail.com>
Co-authored-by: Ni Tianzhen <nitianzhen1210@gmail.com>
Co-authored-by: Rahul Rajesh <rahul.rajesh.bhat@gmail.com>

Author: 4 people

src/web/app/components/sessions-table/__snapshots__/sessions-table.component.spec.ts.snap

@@ -12,7 +12,6 @@ exports[`SessionsTableComponent should snap like in home page with 2 sessions so
   copySessionEvent={[Function EventEmitter]}
   courseCandidates={[Function Array]}
   downloadSessionResultsEvent={[Function EventEmitter]}
-  editSessionEvent={[Function EventEmitter]}
   headerColorScheme="0"
   loadResponseRateEvent={[Function EventEmitter]}
   moveSessionToRecycleBinEvent={[Function EventEmitter]}
@@ -446,7 +445,6 @@ exports[`SessionsTableComponent should snap like in sessions page with 2 session
   copySessionEvent={[Function EventEmitter]}
   courseCandidates={[Function Array]}
   downloadSessionResultsEvent={[Function EventEmitter]}
-  editSessionEvent={[Function EventEmitter]}
   headerColorScheme="0"
   loadResponseRateEvent={[Function EventEmitter]}
   moveSessionToRecycleBinEvent={[Function EventEmitter]}
@@ -845,7 +843,6 @@ exports[`SessionsTableComponent should snap with default fields 1`] = `
   copySessionEvent={[Function EventEmitter]}
   courseCandidates={[Function Array]}
   downloadSessionResultsEvent={[Function EventEmitter]}
-  editSessionEvent={[Function EventEmitter]}
   headerColorScheme="0"
   loadResponseRateEvent={[Function EventEmitter]}
   moveSessionToRecycleBinEvent={[Function EventEmitter]}

src/web/app/components/sessions-table/sessions-table.component.html

@@ -65,7 +65,7 @@
             <ng-container *ngTemplateOutlet="editSessionBtn"></ng-container>
           </a>
           <ng-template #editSessionBtn>
-            <button type="button" class="btn btn-light btn-sm" (click)="editSessionEvent.emit(idx)"
+            <button type="button" class="btn btn-light btn-sm"
                     [disabled]="!sessionsTableRowModel.instructorPrivilege.canModifySession">
               Edit
             </button>

src/web/app/components/sessions-table/sessions-table.component.ts

@@ -55,9 +55,6 @@ export class SessionsTableComponent implements OnInit {
   @Output()
   loadResponseRateEvent: EventEmitter<number> = new EventEmitter();
 
-  @Output()
-  editSessionEvent: EventEmitter<number> = new EventEmitter();
-
   @Output()
   moveSessionToRecycleBinEvent: EventEmitter<number> = new EventEmitter();
 

src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.html

@@ -90,7 +90,7 @@ <h1>Home</h1>
                 [sessionsTableRowModelsSortOrder]="courseTabModel.sessionsTableRowModelsSortOrder" [courseCandidates]="courseCandidates"
                 [headerColorScheme]="SessionsTableHeaderColorScheme.WHITE" [columnsToShow]="[ SessionsTableColumn.START_DATE, SessionsTableColumn.END_DATE ]"
                 (sortSessionsTableRowModelsEvent)="sortSessionsTableRowModelsEvent(idx, $event)"
-                (loadResponseRateEvent)="loadResponseRateEventHandler(idx, $event)" (editSessionEvent)="editSessionEventHandler(idx, $event)"
+                (loadResponseRateEvent)="loadResponseRateEventHandler(idx, $event)"
                 (moveSessionToRecycleBinEvent)="moveSessionToRecycleBinEventHandler(idx, $event)" (copySessionEvent)="copySessionEventHandler(idx, $event)"
                 (submitSessionAsInstructorEvent)="submitSessionAsInstructorEventHandler(idx, $event)" (viewSessionResultEvent)="viewSessionResultEventHandler(idx, $event)"
                 (publishSessionEvent)="publishSessionEventHandler(idx, $event)" (unpublishSessionEvent)="unpublishSessionEventHandler(idx, $event)"

src/web/app/pages-instructor/instructor-home-page/instructor-home-page.component.ts

@@ -311,13 +311,6 @@ export class InstructorHomePageComponent extends InstructorSessionModalPageCompo
     this.loadResponseRate(this.courseTabModels[tabIndex].sessionsTableRowModels[rowIndex]);
   }
 
-  /**
-   * Edits the feedback session.
-   */
-  editSessionEventHandler(tabIndex: number, rowIndex: number): void {
-    this.editSession(this.courseTabModels[tabIndex].sessionsTableRowModels[rowIndex]);
-  }
-
   /**
    * Moves the feedback session to the recycle bin.
    */

src/web/app/pages-instructor/instructor-session-base-page.component.ts

@@ -172,16 +172,6 @@ export abstract class InstructorSessionBasePageComponent {
         }, (resp: ErrorMessageOutput) => { this.statusMessageService.showErrorToast(resp.error.message); });
   }
 
-  /**
-   * Edits the feedback session.
-   */
-  editSession(model: SessionsTableRowModel): void {
-    this.navigationService.navigateByURLWithParamEncoding(
-        this.router,
-        '/web/instructor/sessions/edit',
-        { courseid: model.feedbackSession.courseId, fsname: model.feedbackSession.feedbackSessionName });
-  }
-
   /**
    * Creates list of copy session requests from params
    * @param model the source session model

src/web/app/pages-instructor/instructor-sessions-page/instructor-sessions-page.component.html

@@ -30,7 +30,7 @@
                          [courseCandidates]="courseCandidates" [columnsToShow]="[ SessionsTableColumn.COURSE_ID ]"
                          [headerColorScheme]="SessionsTableHeaderColorScheme.BLUE"
                          (sortSessionsTableRowModelsEvent)="sortSessionsTableRowModelsEvent($event)"
-                         (loadResponseRateEvent)="loadResponseRateEventHandler($event)" (editSessionEvent)="editSessionEventHandler($event)"
+                         (loadResponseRateEvent)="loadResponseRateEventHandler($event)"
                          (moveSessionToRecycleBinEvent)="moveSessionToRecycleBinEventHandler($event)" (copySessionEvent)="copySessionEventHandler($event)"
                          (submitSessionAsInstructorEvent)="submitSessionAsInstructorEventHandler($event)" (viewSessionResultEvent)="viewSessionResultEventHandler($event)"
                          (publishSessionEvent)="publishSessionEventHandler($event)" (unpublishSessionEvent)="unpublishSessionEventHandler($event)"

src/web/app/pages-instructor/instructor-sessions-page/instructor-sessions-page.component.ts

@@ -436,13 +436,6 @@ export class InstructorSessionsPageComponent extends InstructorSessionModalPageC
     this.loadResponseRate(this.sessionsTableRowModels[rowIndex]);
   }
 
-  /**
-   * Edits the feedback session.
-   */
-  editSessionEventHandler(rowIndex: number): void {
-    this.editSession(this.sessionsTableRowModels[rowIndex]);
-  }
-
   /**
    * Restores a recycle bin feedback session.
    */