From 5cde3d00d03f3122f12c32edd079de883192ed4e Mon Sep 17 00:00:00 2001 From: dankelley Date: Mon, 19 Aug 2024 12:03:47 -0300 Subject: [PATCH] update (finalize?) cran comments --- cran-comments.md | 29 +++++++++++++++-------------- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 7bfc87f..64e6924 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,24 +1,25 @@ # Submission of 1.2-0 -This update was required by 2024-09-20, in order to accommodate the change from -the Calloc() and Free() macros to R_Calloc() and R_Free(). The only other -change from the previous CRAN version is the addition of the function -`gsw_infunnel()`, and this addition does not affect any previous behaviours of -the package. +This update was required by 2024-09-20, in order to accommodate the +CRAN-requested change (on that date) relating to the need to replace the +Calloc() and Free() calls with R_Calloc() and R_Free() calls. I wish to thank +the CRAN team for sending that email, since I do not check the CRAN-results +pages as frequently as I ought to, for this mainly-stable package. + +The only other change from the previous CRAN version is the addition of the +function `gsw_infunnel()`. This is mainly for developers' use and, in any +case, its provision does not affect the actions of the rest of the package, so +it should not affect users adversely. # Tests ## Local Tests -R 4.4.1 on macOS Beta 15.0 Beta (24A5298h) revealed no ERRORs, no WARNINGs, -or NOTEs. One NOTE was about the author name and the other about the package -size (a known issue; see above). These tests included those in the CRAN test -suite, along with other tests of datasets that are not provided with the -package. - -* No problems on macOS (12.5 beta, intel) with R-4.2.1 (2022-06-23). +I saw no problems with R 4.4.1 on macOS Beta 15.0 Beta (24A5298h) revealed no +ERRORs, no WARNINGs, or NOTEs (apart from the usual NOTE about the author +name). ## Remote tests -* No problems on win-builder (devel and release). -* No problems on Github R-CMD-check action tests. +* I saw no problems on win-builder (devel and release). +* I saw no problems on Github R-CMD-check action tests.