Skip to content

[Ventus][fix] remove wrong pat #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2025

Conversation

wenhu1024
Copy link
Collaborator

No description provided.

@wenhu1024 wenhu1024 linked an issue Apr 17, 2025 that may be closed by this pull request
@wenhu1024
Copy link
Collaborator Author

wenhu1024 commented Apr 17, 2025

only fixed cts-contractions in #160

@wenhu1024 wenhu1024 linked an issue Apr 21, 2025 that may be closed by this pull request
@wenhu1024 wenhu1024 changed the title [Ventus][fix] disable ventus cse pass, move wrong pat [Ventus][fix] remove wrong pat Apr 29, 2025
This was unlinked from issues Apr 29, 2025
@wenhu1024 wenhu1024 added the bug Something isn't working label Apr 29, 2025
@wenhu1024 wenhu1024 requested a review from ivan-lei as a code owner June 5, 2025 09:47
The FP_CONTRACT pragma can be used to allow (if the state is on) or disallow (if the state is off) the implementation to contract expressions.

The removed patterns previously matched ternary floating-point expressions
such as fadd(fmul(...)), enabling contraction via FMA even when not
explicitly allowed.

These patterns were incorrect because they ignored the current floating-point
contraction state (e.g., controlled by the FP_CONTRACT pragma).
@ivan-lei
Copy link
Collaborator

@Jules-Kong 这个PR修复了OpenCL-CTS里面的contractions测试 ( THU-DSP-LAB/OpenCL-CTS#1 ) ,我们使用run_test_parallel.py运行了整个测试,当前在我这里统计总共是1543个测试例子。
不过在这个过程当中我们触发类似于 THU-DSP-LAB/pocl#84 中的错误,但是目前没办法稳定复现,我觉得可以在后续跑测试的过程中出现后记录状态再整体看是什么问题。

Copy link
Collaborator

@ivan-lei ivan-lei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenhu1024 wenhu1024 merged commit 5ecbb82 into THU-DSP-LAB:main Jun 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants