DEV TESTING

[TT-ReBORN]

CURRENT VERSION: Second Release Candidate - Georgia-ReBORN v3.0-RC2: DOWNLOAD FROM HERE.

P.S Just a reminder for anyone who did not know, you can always download the master as you like.
If you go to the main page here and at the top click on the green <> Code button > Download ZIP.

---

Note for Wine/Linux users:
There is a Wine/Linux bug in the playlist drag and drop, a workaround fix was applied in the playlist.
To be able to use playlist drag and drop on Wine/Linux, you need to downgrade and use Spider Monkey Panel v1.5.2:
https://github.com/TheQwertiest/foo_spider_monkey_panel/releases/tag/v1.5.2

The playlist drag and drop issue has been fixed by Wine devs since Wine 8.

---

Developers might be interested to take a look at the DEV CORNER thread here: #171

---

Posted issues that have been fixed, will be deleted to have a better overview of messages, thank you for the bug report!

Cheers

-TT

[TT-ReBORN]

@Wil-B,

just realized ( a little bit too late 😅 ) that in Biography, the item properties view and nowplaying view is not available when lyrics are found and displayed. Shouldn't we make this also possible to have item properties and nowplaying accessible regardless when lyrics are found? Did I miss something? Just checked and it is the same behavior in your original Biography.

Because of the new lyrics sources I have written for ESLyric, Georgia-ReBORN automatically saves and displays lyrics when found and that is almost for every song now, that means I didn't even realize the missing item properties and nowplaying views. I have forgot about those but I knew in the past they existed but couldn't figure out why they were not being displayed, I mean the behavior when
lyrics were loaded... took me an hour to figure this out 😅

What's your opinion about that?

-Tom

[Meisfuture]

Hi Tom, music in DTS format does not display the DTS logo correctly.

[TT-ReBORN]

@regorxxx,

do you know why foobar behaves like this when using a DTS file in wav file format?
As we know DTS is weird because it has its own codec and file format .dts.
If you use %codec% and %channels% with EvalWithMetadb(metadb) it outputs PCM 2 Channels.
If you use %codec% with Eval it outputs correctly DCA (DTS) 7 Channels.

/**
 * Formats a title and returns the result.
 * @global
 * @param {string} titleFormatString - The title format string to evaluate.
 * @param {FbMetadbHandle} metadb - The handle to evaluate string with.
 * @param {boolean} [force] - An optional force evaluate.
 * @returns {string} The formatted title or an error message.
 */
function $(titleFormatString, metadb = undefined, force = false) {
	try {
		return metadb ? fb.TitleFormat(titleFormatString).EvalWithMetadb(metadb) : fb.TitleFormat(titleFormatString).Eval(force);
	} catch (e) {
		return `${e} (Invalid metadb!)`;
	}
}

		let codec = $('$lower($if2(%codec%,$ext(%path%)))', metadb);
		let format = $('$lower($ext(%path%))', metadb);

		// Foobar bug showing wrong metadata when DTS is in wav file format
		if (codec === 'pcm' && format === 'wav') {
			codec = $('$lower($if2(%codec%,$ext(%path%)))');
			format = $('$lower($ext(%path%))');
		}

Also in Media Player Classic it correctly shows DTS 7 Channels, erm foobar bug!?

I only found this on HA:
https://hydrogenaud.io/index.php/topic,77327.msg675868.html#msg675868

[TT-ReBORN]

Also if you look at the bottom at the foobar toolbar in the screenshot posted by Meisfuture it shows
DTS 7 Channels... foobar kinda contradicts itself 😅

[TT-ReBORN]

Also the post on HA is from 2009-12-28 21:14:26 , so almost 15 years... and this has not been fixed or am I missing something!?

[TT-ReBORN]

The workaround fix was added in the latest commit.

[regorxxx]

No idea, never seen that since I don't use DTS files. But it would be recommendable to report this at HA so it gets finally fixed.

[Meisfuture]

Hi Tom, your avid fan, made a suggestion for me to pass on to you, he would like to have a left/right split state, where mouseover to the left album, and a preview of the tracks from the left album appear on the right side correspondingly.

[Meisfuture]

Tom, additional note from your avid fan 风里尘: Can the two sides of this library split mode follow each other, that is, when the cursor selects one, the other side scrolls to the selected album. Tap the left cover, the right side scrolls to the selected album, non-playing. The reverse is also true, tap right, left scrolls to selected.

[TT-ReBORN]

@Meisfuture,

this is actually already achievable, when you first activate Browse mode and then in the Library menu > Controls > Action > Action mode > Browser. Maybe I will add an extra preset menu setting for this...

-Tom

[Meisfuture]

风里尘 Please realize the source: activate the playlist this setting in the case.

[TT-ReBORN]

Now available in the master, implemented background image component:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

• Implemented background image functionality for Playlist and Library

  Access for the Playlist:

  • Navigate to Top Menu > Options > Playlist > Background
  • Alternatively, use Playlist's context menu > Playlist options menu > Background

  Access for the Library:

  • Navigate to Top Menu > Options > Library > Background
  • Alternatively, use Library's context menu > Playlist options menu > Background

  Features:

  • Show image on background

    • This option must be activated for usage

  • Show now playing rows only (Playlist only)

    • Hides the Playlist header and row backgrounds, displaying only the currently playing track

  • Cycle images

    • Enables automatic cycling through available images

  • Cycle time

    • Configurable intervals for automatic image cycling

  • Image source

    • Specifies the image source type: Artist, Album, or Custom
    • When Artist is selected, artist images from the Biography directory are displayed
    • When Album is selected, album art images are displayed
    • When Custom is selected, custom jpg or png images are displayed from:
      Portable installation: foobar2000\profile\georgia-reborn\images\background
      Standard installation: C:\Users\Username\AppData\Roaming\foobar2000-v2\georgia-reborn\images\background
      Users can add their own images to this directory

  • Image scaling

    • Manages the scaling of background images: Proportional, Filled, or Stretched
    • The default Filled method provides optimal display results

  • Image opacity

    • Adjusts the opacity of the background image; lower values are recommended for readability

  • Row opacity

    • Adjusts the opacity of the Playlist/Library header and track rows; moderate values are recommended for readability

  • Additional notes

    • Manual image cycling can be performed using Shift + mouse wheel
    • All options can be independently configured for both the Playlist and Library, including image source, cycle time, and more

[TT-ReBORN]

Guys, last update for now. We need to finish RC3 after this one!!! 😅

Implemented Redesigned Lyrics Layouts, New Rating Systems, Playlist Diagnostics, and Various Enhancements

New Lyrics features

• Completely redesigned the Lyrics full layout

  • This layout has a special feature: when mouse hovering on the right edge,
    an album overlay will be displayed with artist, album, track ratings
    Clicking on the right edge pauses the track

• Additionally, two new Lyrics layouts, Left and Right, have been implemented

  • In these layouts, hovering over the album covers displays the new ratings
    Clicking on the album cover pauses playback

• All these new layouts use the newly implemented background image functionality by default

  • The shortcut Shift + mouse wheel will cycle through images, the same as in Playlist or Library

• Implemented background image functionality for Lyrics, used as default in the new Lyrics layouts

  • Navigate to Top Menu > Options > Lyrics > Background
  • Alternatively, use Lyrics's context menu > Playlist options menu > Background
  • Nearly the same functionality as Playlist and Library

New Main features

• Implemented a new 5-star rating system that supports fractional ratings

  • This new rating system is used in the new Lyrics layouts
  • Displays quarter, half, and three-quarter stars

• Implemented artist rating functionality

  • Calculates artist rating based on all rated artist tracks
  • Can be seen in the new lyrics layouts and motivates the user to rate all their tracks

New Playlist features

• Implemented playlist diagnostics lists

  • Accessible via right-click on Playlist's context menu > Write playlist diagnostics to list
    • Include album art item menu will select the album art when using Check all missing files
    • File checks:
      • Missing album art (checks if either local or embedded album art in the music album folder exists)
      • Missing album art (local) (checks if local album art in the music album folder exists)
      • Missing album art (embedded) (checks if embedded album art in music files exists)
      • Missing disc art (checks if local disc art in music folders exists)
      • Missing playlist files (checks for dead music files in the playlist)
      • Check all missing files (writes all file checks in one list)
    • Tagging checks:
      • Missing artist name (checks if %artist% metadata in tracks exists)
      • Missing album title (checks if %album% metadata in tracks exists)
      • Missing track number (checks if %tracknumber% metadata in tracks exists)
      • Missing track title (checks if %title% metadata in tracks exists)
      • Missing year (checks if %date% or %year% metadata in tracks exists)
      • Missing genre (checks if %genre% or %year% metadata in tracks exists)
      • Missing label (checks if %label% metadata in tracks exists)
      • Missing country (checks if %artistcountry% or %country% metadata in tracks exists)
      • Check all missing tagging (writes all tagging checks in one list)

• Added new playlist sorting options Artist rating and Artist playcount

  • Accessible in Top menu > Options > Playlist > Sort order > Artist rating and Artist playcount
  • Requires custom metadata from tags, meaning ratings and playcounts in the playlist must exist
    Use Write album statistics to tags via right-click on Playlist context menu to write the custom metadata from tags
    After that, you can use the new sorting options

Rewrites

• Playlist statistics codebase
  • Improved modularity and methods
  • Simplified logic
  • Added artist ratings and artist playcounts as separate lists
• Main Album Art Resize Functionality and Logic
  • Enhanced modularity and methods
  • Simplified logic
• Details Disc Art Resize Functionality and Logic
  • Improved modularity and methods
  • Simplified logic
• General Code Cleanup

Removed

• Removed Shift + mouse wheel lyrics shortcut to adjust 10-second offset; you can use the existing left-click dragging instead
  • This shortcut is now used to cycle through background images
• Removed Top Menu > Options > Lyrics > Display > Show lyrics on album art
  • This is now in Top Menu > Options > Lyrics > Background > Show image on background

Fixes

• Fixed cosmetic metadata grid refresh in Details when cycling artwork image and it is too wide with no space available
• Fixed the creation of ghost folders when writing playlist statistic lists caused by playlist names containing illegal characters

---

Download as usual from here:

https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

-Tom

[silverwings15]

left foobar playing music in the background, reopened it to this

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
CreateImage failed:
Failed to create GdiPlus object (0x2): InvalidParameter

File: gr-helpers.js
Line: 1603, Column: 16
Stack trace:
  GDI@gr-helpers.js:1603:16
  createDiscArtCoverMask@gr-details.js:1659:16
  combineDiscArtWithCover@gr-details.js:1679:10
  setDiscArtRotation@gr-details.js:1876:28
  handlePlaybackNewTrack@gr-main.js:2348:16
  on_playback_new_track@gr-callbacks.js:97:9

and got this error when i reloaded the theme right after

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
ActiveXObject_Constructor failed:
Failed to create ActiveXObject object via CLSID: Microsoft.XMLHTTP

File: gr-helpers.js
Line: 114, Column: 18
Stack trace:
  MakeHttpRequest@gr-helpers.js:114:18
  checkForUpdates@gr-config.js:738:3
  scheduleUpdateCheck/this.updateTimer<@gr-config.js:924:10

and yet another error upon a second (and subsequent) reload attempt

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
ShowHtmlDialog failed:
DoModal failed: -1

File: lib-popupbox.js
Line: 20, Column: 9
Stack trace:
  confirm@lib-popupbox.js:20:9
  showPopup@gr-main-components.js:1389:17
  handleAlbumArt/<@gr-main.js:3824:13

on the dev version with the latest commit being 2aa5bae

[TT-ReBORN]

Another issue in foobar v2 is that lots of crap is also stored in the sqlite meta database file:
foobar2000\profile\metadb.sqlite. How large is your file? The issue here is that foobar v2 saves all sorts of metadata
information from tracks in this database file, also from tags etc. For now, foobar does not have the ability to clean it up,
i.e reducing the filesize. That means old and dead files are also stored there :(

The only way would be to rebuild it by deleting this file, but then you would lose all data.
This includes playlists, ratings, playcounts etc. There already are discussion on HydrogenAudio that Peter should improve it
and implement a clean functionality.

One last tip I can give you is that you should use foobar only during playback session and always close
and start foobar fresh when needed.

-Tom

[silverwings15]

How many tracks does have your Library and Playlists? Also how long was foobar open until it happened?

Library: some 15k tracks
Playlist: was like one album when it was playing
Open duration: Maybe 15-20 minutes.. my foobar usage can hardly be considered intensive

Speaking of which, how is the progress with the SMP 64bit wrapper?

[TT-ReBORN]

Ok this is not normal. I thought you had foobar open for one day or so...

I thought this was the memory issue ( the same error, i.e invalid parameters happens when there is no memory available or corrupt image ) but I have checked the crash logs you posted and it points to a corrupt album cover, this is 100%.
And I thought I handled this already and also correctly.

Do you know which album/track this happened? Maybe you can reproduce it?
Because I have done some testings myself with invalid/corrupt album covers to handle the errors and it seems OK.
I have done some test involving renaming an empty .txt file and renamed it to cover.jpg and normally a popup will
show telling the user that the image is corrupt...

So can you remember the album you have played and check all tracks to see if the crash happens again?
If you find the corrupt album cover, send it to me please.

There also is software on the web that can check your album art images if they are corrupt.
It is also possible that embedded album art in music files are corrupt.

[TT-ReBORN]

Also can you do a test folder with a test track? Create a new empty .txt file and rename it to cover.jpg.
Drag and drop the test track into your playlist and play it. When you click on it, a popup should appear
saying that the album art is corrupt.

[TT-ReBORN]

Ok, I added more robustness to prevent the crashes, try this latest master and replace your files:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

[silverwings15]

got this crash while leaving my foobar playing in the background for over 30 minutes, 18 songs in playlist

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
ApplyMask failed:
GdiPlus error: mask::LockBits failed with error (0x3): OutOfMemory

File: gr-details.js
Line: 1671, Column: 7
Stack trace:
  createDiscArtCoverMask@gr-details.js:1671:7
  combineDiscArtWithCover@gr-details.js:1684:10
  setDiscArtRotation@gr-details.js:1880:28
  updateDiscArt@gr-details.js:1962:8
  loadDiscArt@gr-details.js:1749:9
  fetchDiscArt@gr-details.js:1707:9
  fetchNewArtwork@gr-main.js:3794:15
  handleArtwork@gr-main.js:3818:9
  handlePlaybackNewTrack@gr-main.js:2370:8
  on_playback_new_track@gr-callbacks.js:98:9

[TT-ReBORN]

Ok this is strange, I am working with Georgia-ReBORN the whole day and do not get into these memory issues.
Do you have spinning disc art and if so, are you using lower degrees than the default 72 (5 degrees) in Options > Details > Disc art > Rotation images?

[silverwings15]

nope, i have not changed any settings at all. i also only use playlist view while using foobar

[TT-ReBORN]

Ok, so you aren't displaying the Details panel only the Playlist?
You also do not have full ram, meaning foobar is open and you play some games or other intensive memory eating resources?
And are you using additional foobar user-components? Maybe one user-component introduces memory leak...

I'll take a serious look at this, but I am at the moment focused on the 64-bit Georgia-ReBORN conversion.
This is hard stuff but I think it is doable... I only need to figure out how to correctly implement the COM/ActiveX interface
to JavaScript. Then I can write the missing UI Hacks and peakmeter bar functionalities as foobar user-component in x64
and we are good to go...

-Tom

[silverwings15]

here are my components. and no, i'm not using details panel at all as i usually leave my foobar in the background

don't worry about getting to solving this atm

[TT-ReBORN]

It is very possible that one of these user-components shown in the screenshot causing a memory leak,
thus it's crashing Georgia-ReBORN. I have this feeling because you are the only one that is repeatedly reporting memory crashes.

How about you do testing and for a short period of time?
Install a new portable foobar installation and use it with only the original user-components that come within the zip?

-Tom

[TT-ReBORN]

Hey Cardiacs,

look at this here, now available in the master:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

After replacing files, start foobar and close foobar, it will automatically write the new section at the top.

You wanted to display artist images for current playing album in the background image feature? Now you can!
Check this out how to do this:

• Implemented custom configurable album art filtering:
  • Users can now set their own album art filtering via their georgia-reborn-config.jsonc config file.
  • Filtering patterns can be set in the foobar2000\profile\georgia-reborn\configs\georgia-reborn-config.jsonc file
    in the "artworkPatterns" section. The default pattern filters out disc art from the album art:

    "albumArt": "!/(cd|disc|vinyl)([0-9]*|[a-h])\\.(png|jpg)/i",
    "playlistBgAlbumArt": "!/(cd|disc|vinyl)([0-9]*|[a-h])\\.(png|jpg)/i",
    "libraryBgAlbumArt": "!/(cd|disc|vinyl)([0-9]*|[a-h])\\.(png|jpg)/i",
    "lyricsBgAlbumArt": "!/(cd|disc|vinyl)([0-9]*|[a-h])\\.(png|jpg)/i"

The `albumArt` property handles the large album art displayed on the left side.
The `playlistBgAlbumArt`, `libraryBgAlbumArt`, and `lyricsBgAlbumArt` properties handle
the background image filtering for the Playlist, Library, and Lyrics panels respectively.

The `!` prefix at the start of the pattern is used for exclusion.
When no `!` prefix is used, the pattern uses inclusion.
Example to only display `artist.jpg` images for the Playlist background image:

"playlistBgAlbumArt": "/(artist)\\.(jpg|png)$/i"

All filtering options must be enabled to use the album art filtering:
* For large album art: `Options` > `Player controls` > `Album art` > `Filter album art images`.
* For Playlist background image: `Options` > Playlist` > `Background` > `Image source` > `Filter album art images`.
* For Library background image: `Options` > Library` > `Background` > `Image source` > `Filter album art images`.
* For Lyrics background image: `Options` > Lyrics` > `Background` > `Image source` > `Filter album art images`.

When using background image filtering, ensure the `Image source` is set to `Album` for Playlist, Library, and Lyrics.

• Changed setting Filter disc art from artwork to Filter album art images:

  • Previously: Options > Details > Disc art > Filter disc art from artwork.
  • Now: Options > Player controls > Album art > Filter album art images.

• Refactored and improved the configuration write code:

  • Restructured the code into a more modular, maintainable, and readable format.
  • It now also handles escaping backslashes not only in array objects.

[TT-ReBORN]

I checked your config and the error is this:
"/(artist)\.(jpg|png)$/i",

You are missing one backslash
it should be:
"/(artist)\\.(jpg|png)$/i",

[Cardiacs1964]

Funziona :-)

Cardiacs

[TT-ReBORN]

lol, I just checked. Github here in this post is removing the backslash in my posts!
It is a Github bug here in the posting system. It only works if you declare it as code block :(

Example: these are two backslashes \ without codeblock but shown as one backslash,
and now with codeblock it correctly displays two backslashes \\

Should be reported to Github, maybe they can fix it...

P.S All posts have been updated to correctly display the two backslashes in the posts.

[Cardiacs1964]

[Cardiacs1964]

Perfetto

Cardiacs

[silverwings15]

got another variation of the out of memory error

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
Resize failed:
Failed to create GdiPlus object (0x2): InvalidParameter

File: gr-details.js
Line: 1671, Column: 22
Stack trace:
  createDiscArtCoverMask@gr-details.js:1671:22
  combineDiscArtWithCover@gr-details.js:1684:10
  setDiscArtRotation@gr-details.js:1880:28
  handlePlaybackNewTrack@gr-main.js:2376:16
  on_playback_new_track@gr-callbacks.js:98:9

and maybe a new one

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
FillGradRect failed:
GdiPlus error: SetBlendTriangularShape failed with error (0x2): InvalidParameter

File: gr-main-components.js
Line: 3269, Column: 8
Stack trace:
  drawProgressBarFill@gr-main-components.js:3269:8
  draw@gr-main-components.js:3187:8
  drawLowerBar@gr-main.js:1023:16
  drawMain@gr-main.js:378:8
  on_paint@gr-initialize.js:73:9

kinda strange cos i've run your theme for years on this same device and never got half as many errors as with the recent dev versions

[TT-ReBORN]

Actually it is always the same issue you are reporting, that is when the memory is full,
you will get additional ones because it can not create objects etc. I am developing Georgia-ReBORN dev version and have
not once encountered this issue, it means I have it open and running the entire day. Just think about it for a second, if it would be the case, i.e the DEV version would have big memory issues, then why is it that you are the only one that is reporting it??? I would already get hundreds of these same reports from different users, wouldn't i!?

So did you try to use only the original user-components like I have already mentioned here?

I'll copy it once again:

It is very possible that one of these user-components shown in the screenshot causing a memory leak,
thus it's crashing Georgia-ReBORN. I have this feeling because you are the only one that is repeatedly reporting memory crashes.

How about you do testing and for a short period of time?
Install a new portable foobar installation and use it with only the original user-components that come within the zip?

P.S Do not get me wrong, I would love to fix this memory issue, because stability is the most important!

-Tom

[TT-ReBORN]

So @silverwings15, did you try my advice with only using the original files?
I.e only using the original components that are provided in the zip?

[Meisfuture]

Hi Tom, a small problem, I used to be able to mouse over the cover and scroll through the album images like Back inside the album, but now the locked cover doesn't allow you to browse through the other images inside the album~

[TT-ReBORN]

Try to cycle through these images:
Test.zip

It should be much faster because they are small, it is just lots of processing power is needed for image processing and calculations.

[Meisfuture]

Tom, the questions seem to be getting more and more interesting, sending you the video for reference.

QQ20241227-112553.mp4

[TT-ReBORN]

Thanks for the video, I'll take a look when I have some time.
At the moment I am focused on the work of Georgia-ReBORN 64-Bit.

[TT-ReBORN]

@Meisfuture, the issues should be now fixed.

I had some free time to take a look and the issue was because of the new filtering feature.
I forgot to also add the image formats, because if you not set them, it will also display non-image files in the list
when cycling with the mouse wheel doing weird things =)

Thanks for the report, this was an important bug to report.

-Tom

[Meisfuture]

Hi Tom, hats off to you for taking your responsibilities seriously. More than that, I'm looking forward to Georgia-ReBORN 64-Bit and hope to use it soon.

[erusapien]

just clicking next (shuffle) and encounter this message

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
FillGradRect failed:
GdiPlus error: SetBlendTriangularShape failed with error (0x2): InvalidParameter

File: gr-main-components.js
Line: 3286, Column: 8
Stack trace:
  drawProgressBarFill@gr-main-components.js:3286:8
  draw@gr-main-components.js:3204:8
  drawLowerBar@gr-main.js:1023:16
  drawMain@gr-main.js:378:8
  on_paint@gr-initialize.js:73:9

[TT-ReBORN]

@erusapien, thanks for reporting!
Should be fixed in the latest commit: https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

[XxDeadPatienTxX]

Hello,

I set up everything last night, and when I go to open foobar I receive these two errors, any idea of what is wrong? Please let me know if I should provide any other information.

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
FillRoundRect failed:
Arc argument has invalid value

File: gr-helpers.js
Line: 1954, Column: 12
Stack trace:
FillRoundRect@gr-helpers.js:1954:12
draw@gr-main-components.js:2970:4
drawLowerBar@gr-main.js:1022:15
drawMain@gr-main.js:382:8
on_paint@gr-initialize.js:73:9
forcePaint@lib-panel.js:156:10
getLibrary@lib-library.js:488:13
initialise@lib-library.js:523:8
initMain/<@gr-main.js:1941:33
MakeAsync/<@gr-helpers.js:998:3
MakeAsync@gr-helpers.js:997:9
initMain@gr-main.js:1941:9
async*@gr-initialize.js:63:9
loadAsyncFile/</<@gr-async-loader.js:182:5

Error: Spider Monkey Panel v1.6.1-mod ({04620F16-1878-47A1-8EFE-0CE0B99566CC}: Georgia-ReBORN v3.0-RC3 by TT)
LoadImageAsync failed:
Method called before fb2k was initialized completely

File: bio-images.js
Line: 1176, Column: 8
Stack trace:
loadImg@bio-images.js:1176:8
loadArtImage@bio-images.js:1115:55
getArtImg@bio-images.js:736:8
getItem@bio-images.js:930:11
getArtImg@bio-images.js:728:9
on_size@bio-images.js:1328:9
on_size@bio-callbacks.js:593:11
setBiographySize@gr-main.js:4928:12
displayPanel@gr-main.js:2778:8
initMain@gr-main.js:1951:8
async*@gr-initialize.js:63:9
loadAsyncFile/</<@gr-async-loader.js:182:5

[TT-ReBORN]

Hi @XxDeadPatienTxX,

are you using the latest DEV version?
Because this error should not happen at all.

If you are not using the latest DEV version, please download from here:
https://github.com/TT-ReBORN/Georgia-ReBORN/archive/refs/heads/master.zip

And just replace your files. If this error does not go away, please report again here and tell me how to reproduce.

-TT

[XxDeadPatienTxX]

Yes. However, I replaced the files anyway and that got rid of the errors. I am not sure what happened, but it's working now. Thank you!

[regorxxx]

Just a quick note about the waveform script, have added multiple things as shown here:
https://hydrogenaud.io/index.php/topic,124385.msg1057785.html#msg1057785

A few fixes.

Struggling handling multiple channels on ffprobe thoug. Only reference to my usage is this , but no matter what I do with channels, splitchannel or channel_layout, it's always mono. If anyone has any idea, let me know!

Next step will be changing the current resolution preference, so that it behaves the same in ffprobe and ffmpeg, with points per second, and offer a resolution setting per binary mode (instead of global).

Trying to upload all in different commits to make it more clear for you @TT-ReBORN .

[TT-ReBORN]

LOL, did you look at this here? I couldn't resist and rewrote/refactored basically the entire waveform bar:
994af52

Starts from here:

Georgia-ReBORN/profile/georgia-reborn/scripts/Base/gr-main-components.js

Line 4506 in 98851a1

class WaveformBar {

Now I am doomed, maybe I shouldn't have done this but the entire thing is clean :P

[regorxxx]

XD well that's what happens when you clean other people's code.

In some cases I performed a similar code cleanup it seems, I don't agree with some changes (like all the check flags being recalculated within the loop on painting, which is cleaner for sure, but far from optimal), and the multi-channel support changes some significant bits of loops here and there. I also fixed/improved some parts of the drawing/animation logic which I think you also covered somewhat.

The resolution part should be 10 lines of code, so you can implement the rest. ffmpeg multi.channel support the same (if I find the way to do it xd). But I will try to add docs to every method during these days, so have that in mind. You can wait some days.

[regorxxx]

Have finished code cleanup and bug fixing anything I broke with latest changes. Also added docs everywhere.

Still remaining the resolution part and ffmpeg multichannel support. Those should be small commits.

[TT-ReBORN]

Thanks @regorxxx,

currently, I am very busy and focused on Georgia-ReBORN 64-bit. I have made some good progress,
and finishing it is now my highest priority. After that I'll take a look but how on earth filter out now your refactoring!? 😅
You said your new feature only has 10 lines of code!? I doubt that, or is it only for one feature but you implemented several new ones? Please show me the easiest way without all the noise, I'll keep my new code as I am happy and you keep your new code and we are both happy, end of the drama story and sorry for the trouble.

P.S When I see the 1,5K code line changes ( or whatever the total commit number is ), I want to run away 😛

-Tom

[regorxxx]

I said the 2 things left to do should be less than 10 lines of code.

Multi-channel support changes a lot of places, can't help with that. But it's just a matter of changing data processing to an array of arrays (multiple channels) instead of a single array (1 channel).

I also told you I added JSDOCs everywhere, something you already did. Judging differences by lines means nothing in this case. You can skip those I think.

Either you revise each commit and take a look a the description (and I tried to not mix things unnecessarily) or accept that by implementing and changing code by yourself this is what happens 😅

You may also skip any new feature and just stick to bugfixes.