makes the totals row stay visible just over the punch button

[Atomic-Germ]

Context / Background

While using the app, I find myself wanting to see the totals row when I’m higher up in the sheet.

What change is being introduced by this PR?

This just changes a little bit of the css to keep that row on screen.

How it is:

How it will be with this pr:

How will this be tested?

By scrolling!

[araujoarthur0]

Hey @Atomic-Germ, this is an interesting proposal. I say it might be a bit drastic to change visual elements by default and we could have a preference setting for this instead so it only applies to those who choose it. We already have a few preference values in the preferences page.
What do you think, @tupaschoal ?

[tupaschoal]

Actually I quite like it, I find myself scrolling to the bottom veery often when a month begins, I don't see how it would harm any one person usage, so if it works well, I'd make it default and non configurable.

Does this also touch the day view?

[Atomic-Germ]

Looks like it does — if that isn’t wanted, there are a few ways around it. I can add some code here and there to make it behave normally in that window, oooor does it need to be displayed at all in day view?

[araujoarthur0]

Day view has its own bar with month balance, it's expected.
With your change it has a weird effect with more entries:

[tupaschoal]

I'm ok with having it in both day and month view, but it has to look correct on both.

[Atomic-Germ]

I see what you're saying, I’ll work on a few different options for fixing that and see what looks best!

[Atomic-Germ]

See anything strange still? I’ll consider this a work in progress until we’re all good with it

EDIT: Added shots with the title in them

[araujoarthur0]

@Atomic-Germ I noticed it looks a bit rounder. Let's focus only on the proposed change here for stickiness and think about other styles later.
The scrollbar is appearing on the default view of the day calendar, which is not expected.

Text is also still appearing below and behind the button, which feels weird to me as originally the bar is part of the table and then it "jumps 1 dimension" above it. I know previously the button was transparent, but with the bar it's giving me a weird feeling. For example on the screenshot it looks like it's a table row with a purple border above and below.

Perhaps we should make the whole region around the punch button solid and no longer show the table below/behind it.

[Atomic-Germ]

And with the punch button disabled:

[tupaschoal]

I like how it looks now, what do you think @araujoarthur0 ?

If we stick to it, I'd just say we should delete the opacity property altogether, since the default is already 1.
I also wonder whether we should apply some effect to the background color of the disabled punch button, since it lost the opacity as disabled meaning.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

[Atomic-Germ]

@tupaschoal How’s this? Needs to be tested for when it is enabled still though.

[tupaschoal]

Hmm, I don't like much the changing of the button to grey, I think it is too drastic. What if we use brightness filter for when it is disabled and when the user hovers it? I liked the result I played with (I'm not a CSS wizard, so there might be better ways)

Also, it seems like the image of the fingerprint is being cut by the footer. There was a small margin before but it is gone.

Needs to be tested for when it is enabled still though.

If you open the preferences and toggle the current day to be on then close it, the button will be enabled :)

[tupaschoal]

I like it too! Will wait for @araujoarthur0's take

[araujoarthur0]

Hover on enabled button is looking a little weird, it's like someone turned the flash on. I think the font is also leaking some of the light. I think changing the background color should be simpler than messing with the brightness as it's affecting everything inside it.

[Atomic-Germ]

Looking further into it, this seems to be a perceptual thing. The contrast of the button is lowering by bringing the background color closer to white. I think leaving the hover transition for the enabled button out entirely.

[araujoarthur0]

Today it doesn't change on hover, right? It should be ok not to change that.

[tupaschoal]

I like there being some effect on hover of buttons, but I agree it should be considered separately. I'm mergint this as is, then, thanks for the patience @Atomic-Germ !

[tupaschoal]

\changelog-update
Message: Enhancement [#1142]: Make balance row always visible above the punch button