Merge pull request #153 from TaloDev/develop

Release 0.46.0

Author: tudddorrr

.github/workflows/claude-code-review.yml

@@ -17,14 +17,14 @@ jobs:
     #   github.event.pull_request.user.login == 'external-contributor' ||
     #   github.event.pull_request.user.login == 'new-developer' ||
     #   github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR'
-    
+
     runs-on: ubuntu-latest
     permissions:
       contents: read
       pull-requests: read
       issues: read
       id-token: write
-    
+
     steps:
       - name: Checkout repository
         uses: actions/checkout@v4
@@ -33,15 +33,10 @@ jobs:
 
       - name: Run Claude Code Review
         id: claude-review
-        uses: anthropics/claude-code-action@beta
+        uses: anthropics/claude-code-action@v1
         with:
           claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }}
-
-          # Optional: Specify model (defaults to Claude Sonnet 4, uncomment for Claude Opus 4.1)
-          # model: "claude-opus-4-1-20250805"
-
-          # Direct prompt for automated review (no @claude mention needed)
-          direct_prompt: |
+          prompt: |
             Please review this pull request and provide feedback on:
             - Code quality and best practices
             - Potential bugs or issues
@@ -53,28 +48,11 @@ jobs:
             Be constructive and helpful in your feedback but do not repeat yourself - only summarise potential issues.
             Test coverage is currently not a priority.
             Prefix section headers with emojis and use dividers for better readability.
-
-          use_sticky_comment: true
+            
+            Use the repository's CLAUDE.md for guidance on style and conventions. Be constructive and helpful in your feedback.
+            Use `gh pr comment` with your Bash tool to leave your review as a comment on the PR.
           
-          # Optional: Customize review based on file types
-          # direct_prompt: |
-          #   Review this PR focusing on:
-          #   - For TypeScript files: Type safety and proper interface usage
-          #   - For API endpoints: Security, input validation, and error handling
-          #   - For React components: Performance, accessibility, and best practices
-          #   - For tests: Coverage, edge cases, and test quality
-          
-          # Optional: Different prompts for different authors
-          # direct_prompt: |
-          #   ${{ github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' && 
-          #   'Welcome! Please review this PR from a first-time contributor. Be encouraging and provide detailed explanations for any suggestions.' ||
-          #   'Please provide a thorough code review focusing on our coding standards and best practices.' }}
-          
-          # Optional: Add specific tools for running tests or linting
-          # allowed_tools: "Bash(npm run test),Bash(npm run lint),Bash(npm run typecheck)"
-          
-          # Optional: Skip review for certain conditions
-          # if: |
-          #   !contains(github.event.pull_request.title, '[skip-review]') &&
-          #   !contains(github.event.pull_request.title, '[WIP]')
-
+          # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md
+          # or https://docs.anthropic.com/en/docs/claude-code/sdk#command-line for available options
+          claude_args: '--allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"'
+          use_sticky_comment: true

Assets/Talo Game Services/Talo/Runtime/APIs/BaseAPI.cs

@@ -9,7 +9,7 @@ namespace TaloGameServices
     public class BaseAPI
     {
         // automatically updated with a pre-commit hook
-        private const string ClientVersion = "0.45.0";
+        private const string ClientVersion = "0.46.0";
 
         protected string baseUrl;
 

Assets/Talo Game Services/Talo/Runtime/APIs/ChannelsAPI.cs

@@ -37,6 +37,30 @@ public string ToQueryString()
         }
     }
 
+    public class GetMembersOptions
+    {
+        public int page = 0;
+        public string playerId = "";
+        public int aliasId = -1;
+        public string identifier = "";
+        public string propKey = "";
+        public string propValue = "";
+        public string playerGroupId = "";
+
+        public string ToQueryString()
+        {
+            var query = new Dictionary<string, string> { ["page"] = page.ToString() };
+            if (!string.IsNullOrEmpty(playerId)) query["playerId"] = playerId;
+            if (aliasId != -1) query["aliasId"] = aliasId.ToString();
+            if (!string.IsNullOrEmpty(identifier)) query["identifier"] = identifier;
+            if (!string.IsNullOrEmpty(propKey)) query["propKey"] = propKey;
+            if (!string.IsNullOrEmpty(propValue)) query["propValue"] = propValue;
+            if (!string.IsNullOrEmpty(playerGroupId)) query["playerGroupId"] = playerGroupId;
+
+            return string.Join("&", query.Select((param) => $"{param.Key}={param.Value}"));
+        }
+    }
+
     public class CreateChannelOptions
     {
         public string name;
@@ -273,15 +297,17 @@ public async Task Invite(int channelId, int playerAliasId)
             await Call(uri, "POST", content);
         }
 
-        public async Task<PlayerAlias[]> GetMembers(int channelId)
+        public async Task<ChannelsMembersResponse> GetMembers(int channelId, GetMembersOptions options = null)
         {
             Talo.IdentityCheck();
 
-            var uri = new Uri($"{baseUrl}/{channelId}/members");
+            options ??= new GetMembersOptions();
+
+            var uri = new Uri($"{baseUrl}/{channelId}/members?{options.ToQueryString()}");
             var json = await Call(uri, "GET");
 
             var res = JsonUtility.FromJson<ChannelsMembersResponse>(json);
-            return res.members;
+            return res;
         }
 
         public async Task<ChannelStorageProp> GetStorageProp(int channelId, string propKey, bool bustCache = false)

Assets/Talo Game Services/Talo/Runtime/APIs/EventsAPI.cs

@@ -10,10 +10,10 @@ public class EventsAPI : BaseAPI
     {
         public event Action OnFlushed;
 
-        private List<Event> queue = new ();
+        internal List<Event> queue = new ();
         private readonly int minQueueSize = 10;
 
-        private List<Event> eventsToFlush = new ();
+        internal List<Event> eventsToFlush = new ();
         private bool lockFlushes;
         private bool flushAttemptedDuringLock;
 
@@ -107,9 +107,9 @@ public async Task Flush()
                 eventsToFlush.Clear();
                 lockFlushes = false;
             }
-            catch (Exception err)
+            catch (Exception ex)
             {
-                Debug.LogError(err.Message);
+                Debug.LogError(ex.Message);
             }
 
             if (flushAttemptedDuringLock)
@@ -118,5 +118,13 @@ public async Task Flush()
                 await Flush();
             }
         }
+
+        public void ClearQueue()
+        {
+            queue.Clear();
+            eventsToFlush.Clear();
+            lockFlushes = false;
+            flushAttemptedDuringLock = false;
+        }
     }
 }

Assets/Talo Game Services/Talo/Runtime/APIs/GameConfigAPI.cs

@@ -14,21 +14,49 @@ public GameConfigAPI() : base("v1/game-config") {
                 if (response.GetResponseType() == "v1.live-config.updated")
                 {
                     var data = response.GetData<GameConfigResponse>();
-                    OnLiveConfigUpdated?.Invoke(new LiveConfig(data.config));
+                    SetLiveConfig(new LiveConfig(data.config), true);
                 }
             };
         }
 
         public async Task<LiveConfig> Get()
         {
+            if (Talo.IsOffline())
+            {
+                return GetOfflineConfig();
+            }
+
             var uri = new Uri(baseUrl);
             var json = await Call(uri, "GET");
 
             var res = JsonUtility.FromJson<GameConfigResponse>(json);
-            Talo.LiveConfig = new LiveConfig(res.config);
-            OnLiveConfigLoaded?.Invoke(Talo.LiveConfig);
-
+            SetLiveConfig(new LiveConfig(res.config));
             return Talo.LiveConfig;
         }
+
+        public LiveConfig GetOfflineConfig()
+        {
+            var offlineConfig = LiveConfig.GetOfflineConfig();
+            if (offlineConfig != null)
+            {
+                SetLiveConfig(offlineConfig);
+            }
+            return offlineConfig;
+        }
+
+        private void SetLiveConfig(LiveConfig liveConfig, bool isUpdate = false)
+        {
+            Talo.LiveConfig = liveConfig;
+            liveConfig.WriteOfflineConfig();
+            
+            if (isUpdate)
+            {
+                OnLiveConfigUpdated?.Invoke(liveConfig);
+            }
+            else
+            {
+                OnLiveConfigLoaded?.Invoke(liveConfig);
+            }
+        }
     }
 }

Assets/Talo Game Services/Talo/Runtime/APIs/PlayerGroupsAPI.cs

@@ -8,13 +8,13 @@ public class PlayerGroupsAPI : BaseAPI
     {
         public PlayerGroupsAPI() : base("v1/player-groups") { }
 
-        public async Task<Group> Get(string groupId)
+        public async Task<PlayerGroupsGetResponse> Get(string groupId, int page = 0)
         {
-            var uri = new Uri($"{baseUrl}/{groupId}");
+            var uri = new Uri($"{baseUrl}/{groupId}?page={page}");
             var json = await Call(uri, "GET");
 
             var res = JsonUtility.FromJson<PlayerGroupsGetResponse>(json);
-            return res.group;
+            return res;
         }
     }
 }

Assets/Talo Game Services/Talo/Runtime/APIs/PlayersAPI.cs

@@ -10,8 +10,9 @@ public class PlayersAPI : BaseAPI
         public event Action<Player> OnIdentified;
         public event Action OnIdentificationStarted;
         public event Action OnIdentificationFailed;
+        public event Action OnIdentityCleared;
 
-        private readonly string _offlineDataPath = Application.persistentDataPath + "/ta.bin";
+        private readonly string offlineDataPath = Application.persistentDataPath + "/ta.bin";
 
         public PlayersAPI() : base("v1/players") { }
 
@@ -82,6 +83,8 @@ public async Task<Player> IdentifySteam(string ticket, string identity = "")
 
         public async Task<Player> Update()
         {
+            Talo.IdentityCheck();
+
             var uri = new Uri($"{baseUrl}/{Talo.CurrentPlayer.id}");
             var content = JsonUtility.ToJson(Talo.CurrentPlayer);
             var json = await Call(uri, "PATCH", Prop.SanitiseJson(content));
@@ -123,7 +126,7 @@ private async Task<Player> IdentifyOffline(string service, string identifier)
             {
                 try
                 {
-                    File.Delete(_offlineDataPath);
+                    File.Delete(offlineDataPath);
                 }
                 finally
                 {
@@ -137,13 +140,67 @@ private void WriteOfflineAlias(PlayerAlias alias)
         {
             if (!Talo.Settings.cachePlayerOnIdentify) return;
             var content = JsonUtility.ToJson(alias);
-            Talo.Crypto.WriteFileContent(_offlineDataPath, content);
+            Talo.Crypto.WriteFileContent(offlineDataPath, content);
         }
 
         private PlayerAlias GetOfflineAlias()
         {
-            if (!Talo.Settings.cachePlayerOnIdentify || !File.Exists(_offlineDataPath)) return null;
-            return JsonUtility.FromJson<PlayerAlias>(Talo.Crypto.ReadFileContent(_offlineDataPath));
+            if (!Talo.Settings.cachePlayerOnIdentify || !File.Exists(offlineDataPath)) return null;
+            return JsonUtility.FromJson<PlayerAlias>(Talo.Crypto.ReadFileContent(offlineDataPath));
+        }
+
+        private void DeleteOfflineAlias()
+        {
+            if (File.Exists(offlineDataPath))
+            {
+                try
+                {
+                    File.Delete(offlineDataPath);
+                }
+                catch (Exception ex)
+                {
+                    Debug.LogWarning($"Failed to delete offline player data: {ex.Message}");
+                }
+            }
+        }
+
+        public async Task ClearIdentity()
+        {
+            Talo.IdentityCheck();
+
+            try
+            {
+                DeleteOfflineAlias();
+            }
+            catch (Exception ex)
+            {
+                Debug.LogWarning($"Error deleting offline alias: {ex.Message}");
+            }
+
+            try
+            {
+                // clears the alias and resets the socket (doesn't require auth)
+                await Talo.PlayerAuth.SessionManager.ClearSession();
+            }
+            catch (Exception ex)
+            {
+                Debug.LogWarning($"Error clearing session: {ex.Message}");
+            }
+
+            Talo.Events.ClearQueue();
+            Talo.Continuity.ClearRequests();
+
+            OnIdentityCleared?.Invoke();
+        }
+
+        public async Task<PlayersSearchResponse> Search(string query)
+        {
+            var encodedQuery = Uri.EscapeDataString(query.Trim());
+            var uri = new Uri($"{baseUrl}/search?query={encodedQuery}");
+            var json = await Call(uri, "GET");
+
+            var res = JsonUtility.FromJson<PlayersSearchResponse>(json);
+            return res;
         }
     }
 }