fix: improve exported add-on compatibility and better-auth handlers (#359)

fix: harden exported add-on ids and better-auth sign-out handlers

Author: tannerlinsley

packages/cli/src/command-line.ts

@@ -136,6 +136,9 @@ export async function normalizeOptions(
       ])
       if (cliOptions.addOns && Array.isArray(cliOptions.addOns)) {
         for (const a of cliOptions.addOns) {
+          if (a.toLowerCase() === 'start') {
+            continue
+          }
           selectedAddOns.add(a)
         }
       }

packages/cli/src/options.ts

@@ -118,6 +118,9 @@ export async function promptForCreateOptions(
 
   if (Array.isArray(cliOptions.addOns)) {
     for (const addOn of cliOptions.addOns) {
+      if (addOn.toLowerCase() === 'start') {
+        continue
+      }
       addOns.add(addOn)
     }
   } else {

packages/cli/tests/command-line.test.ts

@@ -218,6 +218,35 @@ describe('normalizeOptions', () => {
     expect(options?.typescript).toBe(true)
   })
 
+  it('should ignore legacy start add-on id from exported commands', async () => {
+    __testRegisterFramework({
+      id: 'react-cra',
+      name: 'react',
+      getAddOns: () => [
+        {
+          id: 'tanstack-query',
+          name: 'TanStack Query',
+          modes: ['file-router'],
+        },
+        {
+          id: 'nitro',
+          name: 'nitro',
+          modes: ['file-router'],
+          default: true,
+        },
+      ],
+    })
+
+    const options = await normalizeOptions({
+      projectName: 'test',
+      addOns: ['start', 'tanstack-query'],
+      framework: 'react-cra',
+    })
+
+    expect(options?.chosenAddOns.map((a) => a.id)).toContain('tanstack-query')
+    expect(options?.chosenAddOns.map((a) => a.id)).not.toContain('start')
+  })
+
   it('should handle toolchain as an addon', async () => {
     __testRegisterFramework({
       id: 'react-cra',

packages/create/src/frameworks/react/add-ons/better-auth/assets/src/integrations/better-auth/header-user.tsx

@@ -23,7 +23,9 @@ export default function BetterAuthHeader() {
           </div>
         )}
         <button
-          onClick={() => authClient.signOut()}
+          onClick={() => {
+            void authClient.signOut()
+          }}
           className="flex-1 h-9 px-4 text-sm font-medium bg-white dark:bg-neutral-900 text-neutral-900 dark:text-neutral-50 border border-neutral-300 dark:border-neutral-700 hover:bg-neutral-50 dark:hover:bg-neutral-800 transition-colors"
         >
           Sign out

packages/create/src/frameworks/react/add-ons/better-auth/assets/src/routes/demo/better-auth.tsx

@@ -57,7 +57,9 @@ function BetterAuthDemo() {
           </div>
 
           <button
-            onClick={() => authClient.signOut()}
+            onClick={() => {
+              void authClient.signOut()
+            }}
             className="w-full h-9 px-4 text-sm font-medium border border-neutral-300 dark:border-neutral-700 hover:bg-neutral-100 dark:hover:bg-neutral-800 transition-colors"
           >
             Sign out

packages/create/src/frameworks/solid/add-ons/better-auth/assets/src/integrations/better-auth/header-user.tsx

@@ -38,7 +38,9 @@ export default function BetterAuthHeader() {
               {(image) => <img src={image()} alt="" class="h-8 w-8" />}
             </Show>
             <button
-              onClick={() => authClient.signOut()}
+              onClick={() => {
+                void authClient.signOut();
+              }}
               class="flex-1 h-9 px-4 text-sm font-medium bg-white dark:bg-neutral-900 text-neutral-900 dark:text-neutral-50 border border-neutral-300 dark:border-neutral-700 hover:bg-neutral-50 dark:hover:bg-neutral-800 transition-colors"
             >
               Sign out

packages/create/src/frameworks/solid/add-ons/better-auth/assets/src/routes/demo.better-auth.tsx

@@ -210,7 +210,9 @@ function BetterAuthDemo() {
               </div>
 
               <button
-                onClick={() => authClient.signOut()}
+                onClick={() => {
+                  void authClient.signOut();
+                }}
                 class="w-full h-9 px-4 text-sm font-medium border border-neutral-300 dark:border-neutral-700 hover:bg-neutral-100 dark:hover:bg-neutral-800 transition-colors"
               >
                 Sign out