Fix isLimitSubset to correctly handle unlimited subsets

Author: kevin-dp

packages/db/src/query/predicate-utils.ts

@@ -769,16 +769,17 @@ export function isLimitSubset(
   subset: number | undefined,
   superset: number | undefined
 ): boolean {
-  // No limit requirement is always satisfied
-  if (subset === undefined) {
-    return true
-  }
-
   // Unlimited superset satisfies any limit requirement
   if (superset === undefined) {
     return true
   }
 
+  // If requesting all data (no limit), we need unlimited data to satisfy it
+  // But we know superset is not unlimited so we return false
+  if (subset === undefined) {
+    return false
+  }
+
   // Otherwise, subset must be less than or equal to superset
   return subset <= superset
 }

packages/db/tests/predicate-utils.test.ts

@@ -621,8 +621,12 @@ describe(`isOrderBySubset`, () => {
 })
 
 describe(`isLimitSubset`, () => {
-  it(`should return true for undefined subset`, () => {
-    expect(isLimitSubset(undefined, 10)).toBe(true)
+  it(`should return false for undefined subset with limited superset (requesting all data but only have limited)`, () => {
+    expect(isLimitSubset(undefined, 10)).toBe(false)
+  })
+
+  it(`should return true for undefined subset with undefined superset (requesting all data and have all data)`, () => {
+    expect(isLimitSubset(undefined, undefined)).toBe(true)
   })
 
   it(`should return true for undefined superset`, () => {