Linting

Author: kevin-dp

packages/db/src/collection/sync.ts

@@ -10,8 +10,8 @@ import {
 import type { StandardSchemaV1 } from "@standard-schema/spec"
 import type {
   ChangeMessage,
-  CollectionConfig,
   CleanupFn,
+  CollectionConfig,
   OnLoadMoreOptions,
   SyncConfigRes,
 } from "../types"

packages/db/src/index.ts

@@ -1,4 +1,8 @@
 // Re-export all public APIs
+// Re-export IR types under their own namespace
+// because custom collections need access to the IR types
+import * as IR from "./query/ir.js"
+
 export * from "./collection/index.js"
 export * from "./SortedMap"
 export * from "./transactions"
@@ -10,10 +14,6 @@ export * from "./local-only"
 export * from "./local-storage"
 export * from "./errors"
 
-// Re-export IR types under their own namespace
-// because custom collections need access to the IR types
-import * as IR from "./query/ir.js"
-
 // Index system exports
 export * from "./indexes/base-index.js"
 export * from "./indexes/btree-index.js"

packages/db/src/query/compiler/expressions.ts

@@ -102,7 +102,9 @@ export function convertOrderByToBasicExpression(
     )
 
     if (!basicExp) {
-      throw new Error(`Failed to convert orderBy expression to a basic expression: ${clause.expression}`)
+      throw new Error(
+        `Failed to convert orderBy expression to a basic expression: ${clause.expression}`
+      )
     }
 
     return {
@@ -112,4 +114,4 @@ export function convertOrderByToBasicExpression(
   })
 
   return normalizedOrderBy
-}
+}

packages/db/src/query/live/collection-subscriber.ts

@@ -1,5 +1,8 @@
 import { MultiSet } from "@tanstack/db-ivm"
-import { convertOrderByToBasicExpression, convertToBasicExpression } from "../compiler/expressions.js"
+import {
+  convertOrderByToBasicExpression,
+  convertToBasicExpression,
+} from "../compiler/expressions.js"
 import type { FullSyncState } from "./types.js"
 import type { MultiSetArray, RootStreamBuilder } from "@tanstack/db-ivm"
 import type { Collection } from "../../collection/index.js"
@@ -168,7 +171,10 @@ export class CollectionSubscriber<
     subscription.setOrderByIndex(index)
 
     // Normalize the orderBy clauses such that the references are relative to the collection
-    const normalizedOrderBy = convertOrderByToBasicExpression(orderBy, this.collectionAlias)
+    const normalizedOrderBy = convertOrderByToBasicExpression(
+      orderBy,
+      this.collectionAlias
+    )
 
     // Load the first `offset + limit` values from the index
     // i.e. the K items from the collection that fall into the requested range: [offset, offset + limit[
@@ -240,7 +246,7 @@ export class CollectionSubscriber<
     const biggestSentValue = biggestSentRow
       ? valueExtractorForRawRow(biggestSentRow)
       : biggestSentRow
-    
+
     // Normalize the orderBy clauses such that the references are relative to the collection
     const normalizedOrderBy = convertOrderByToBasicExpression(
       orderBy,

packages/db/tests/query/order-by.test.ts

@@ -797,8 +797,8 @@ function createOrderByTests(autoIndex: `off` | `eager`): void {
         )
 
         const liveQuery = createLiveQueryCollection({
-          query: (q) =>
-            q
+          query: (qb) =>
+            qb
               .from({ vehicleDocuments: vehicleDocumentCollection })
               .groupBy((q) => q.vehicleDocuments.vin)
               .orderBy((q) => q.vehicleDocuments.vin, `asc`)
@@ -853,8 +853,8 @@ function createOrderByTests(autoIndex: `off` | `eager`): void {
         )
 
         const liveQuery = createLiveQueryCollection({
-          query: (q) =>
-            q
+          query: (qb) =>
+            qb
               .from({ vehicleDocuments: vehicleDocumentCollection })
               .groupBy((q) => q.vehicleDocuments.vin)
               .orderBy((q) => max(q.vehicleDocuments.updatedAt), `desc`)

packages/db/tests/transactions.test.ts

@@ -233,7 +233,7 @@ describe(`Transactions`, () => {
   })
   it(`commit() should throw errors when mutation function fails`, async () => {
     const tx = createTransaction({
-      mutationFn: async () => {
+      mutationFn: () => {
         throw new Error(`API failed`)
       },
       autoCommit: false,
@@ -269,7 +269,7 @@ describe(`Transactions`, () => {
   it(`commit() and isPersisted.promise should reject with the same error instance`, async () => {
     const originalError = new Error(`Original API error`)
     const tx = createTransaction({
-      mutationFn: async () => {
+      mutationFn: () => {
         throw originalError
       },
       autoCommit: false,
@@ -315,7 +315,7 @@ describe(`Transactions`, () => {
 
   it(`should handle non-Error throwables (strings)`, async () => {
     const tx = createTransaction({
-      mutationFn: async () => {
+      mutationFn: () => {
         throw `string error`
       },
       autoCommit: false,
@@ -355,7 +355,7 @@ describe(`Transactions`, () => {
 
   it(`should handle non-Error throwables (numbers, objects)`, async () => {
     const tx = createTransaction({
-      mutationFn: async () => {
+      mutationFn: () => {
         throw 42
       },
       autoCommit: false,
@@ -371,7 +371,7 @@ describe(`Transactions`, () => {
     }
 
     const tx2 = createTransaction({
-      mutationFn: async () => {
+      mutationFn: () => {
         throw { code: `ERR_FAILED`, details: `Something went wrong` }
       },
       autoCommit: false,
@@ -405,7 +405,7 @@ describe(`Transactions`, () => {
 
   it(`should throw TransactionNotPendingCommitError when commit() is called on failed transaction`, async () => {
     const tx = createTransaction({
-      mutationFn: async () => {
+      mutationFn: () => {
         throw new Error(`Failed`)
       },
       autoCommit: false,
@@ -440,7 +440,7 @@ describe(`Transactions`, () => {
   it(`should handle cascading rollbacks with proper error propagation`, async () => {
     const originalError = new Error(`Primary transaction failed`)
     const tx1 = createTransaction({
-      mutationFn: async () => {
+      mutationFn: () => {
         throw originalError
       },
       autoCommit: false,