-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Vue router RFC #5997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Vue router RFC #5997
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 937ea6c
☁️ Nx Cloud last updated this comment at |
The previous change to inferFullPath incorrectly affected layout routes by returning '/' for their fullPath instead of ''. This broke the FileRoutesByTo and FileRoutesByFullPath type mappings. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Updated TypeScript test versions from ts53-ts58 to ts54-ts59 - Fixed description to say "Vue applications" instead of "Solid" - Changed keyword from "react" to "vue" - Removed "solid" export condition - Updated build script to just "vite build" (no tsc) - Updated dependencies to match react-router-devtools pattern - Added @tanstack/router-core as optional peer dependency 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
The root index route was being excluded from FileRoutesByTo because inferFullPath returned empty string instead of '/'. The fix checks if fullPath equals '/' (after removing layout segments) and preserves it. This allows `<Link to="/">` to work correctly in components. Updated snapshots for route-groups and nested-route-groups-with-layouts-before-physical tests. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Since a Vue single-file component (SFC) only can export one component, and most tanstack router routes export multiple (main component, error compoentn, not found component etc.) the iteration here uses multiple vue files like this:
File-Based Routing Conventions
.route.ts.component.vue.errorComponent.vue.notFoundComponent.vue.lazy.ts_layoutprefix_suffix (e.g.,posts_.$postId)(groupName)directory$paramExamples from e2e/vue-router/basic-file-routes/