Skip to content

Commit 02b9d5e

Browse files
committed
CLAP-335 Refactor: 회원 등록 시 닉네임 및 이메일 중복 예외 처리 개선
<footer> - 관련: #429
1 parent 3745399 commit 02b9d5e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

src/main/java/clap/server/application/service/admin/RegisterMemberService.java

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
import lombok.RequiredArgsConstructor;
1818
import org.springframework.transaction.annotation.Transactional;
1919

20+
import java.util.Set;
21+
2022
@ApplicationService
2123
@RequiredArgsConstructor
2224
class RegisterMemberService implements RegisterMemberUsecase {
@@ -33,11 +35,10 @@ public void registerMember(Long adminId, RegisterMemberRequest request) {
3335
Department department = loadDepartmentPort.findById(request.departmentId())
3436
.orElseThrow(() -> new ApplicationException(DepartmentErrorCode.DEPARTMENT_NOT_FOUND));
3537

36-
loadMemberPort.findByNickname(request.nickname()).ifPresent(
37-
member -> {
38-
throw new ApplicationException(MemberErrorCode.DUPLICATE_NICKNAME);
39-
}
40-
);
38+
if (loadMemberPort.existsByNicknamesOrEmails(Set.of(request.nickname()), Set.of(request.email()))) {
39+
throw new ApplicationException(MemberErrorCode.DUPLICATE_NICKNAME_OR_EMAIL);
40+
}
41+
4142
managerDepartmentPolicy.validateDepartment(department, request.role());
4243
MemberInfo memberInfo = MemberInfo.toMemberInfo(request.name(), request.email(), request.nickname(), request.isReviewer(),
4344
department, request.role(), request.departmentRole());

0 commit comments

Comments
 (0)