Skip to content

Commit 7a03d28

Browse files
authored
Merge pull request #128 from TaskFlow-CLAP/CLAP-152
CLAP-152 잘못 반영된 코드 삭제
2 parents d721bbf + 532e75e commit 7a03d28

File tree

12 files changed

+10
-413
lines changed

12 files changed

+10
-413
lines changed

src/main/java/clap/server/adapter/inbound/web/dto/admin/FindManagersResponse.java

Lines changed: 0 additions & 23 deletions
This file was deleted.

src/main/java/clap/server/adapter/inbound/web/member/ManagerController.java

Lines changed: 0 additions & 33 deletions
This file was deleted.
Lines changed: 2 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,24 @@
11
package clap.server.adapter.outbound.persistense;
22

33
import clap.server.adapter.outbound.persistense.entity.member.MemberEntity;
4-
import clap.server.adapter.outbound.persistense.entity.member.constant.MemberRole;
54
import clap.server.adapter.outbound.persistense.entity.member.constant.MemberStatus;
65
import clap.server.adapter.outbound.persistense.mapper.MemberPersistenceMapper;
76
import clap.server.adapter.outbound.persistense.repository.member.MemberRepository;
87
import clap.server.application.port.outbound.member.CommandMemberPort;
98
import clap.server.application.port.outbound.member.LoadMemberPort;
109
import clap.server.common.annotation.architecture.PersistenceAdapter;
11-
import clap.server.domain.model.task.Task;
12-
import clap.server.adapter.outbound.persistense.entity.task.constant.TaskStatus ;
13-
import clap.server.adapter.outbound.persistense.entity.task.TaskEntity;
14-
import clap.server.adapter.outbound.persistense.repository.task.TaskRepository;
15-
import clap.server.adapter.outbound.persistense.mapper.TaskPersistenceMapper;
16-
import java.util.stream.Collectors;
17-
import java.util.List;
18-
1910
import clap.server.domain.model.member.Member;
2011
import lombok.RequiredArgsConstructor;
2112

13+
import java.util.List;
2214
import java.util.Optional;
15+
import java.util.stream.Collectors;
2316

2417
@PersistenceAdapter
2518
@RequiredArgsConstructor
2619
public class MemberPersistenceAdapter implements LoadMemberPort, CommandMemberPort {
2720
private final MemberRepository memberRepository;
2821
private final MemberPersistenceMapper memberPersistenceMapper;
29-
private final TaskRepository taskRepository;
30-
private final TaskPersistenceMapper taskPersistenceMapper;
3122

3223

3324
@Override
@@ -63,27 +54,5 @@ public void save(final Member member) {
6354
memberRepository.save(memberEntity);
6455
}
6556

66-
@Override
67-
public List<Member> findActiveManagers() {
68-
List<MemberEntity> memberEntities = memberRepository.findByRoleAndStatus(MemberRole.valueOf("ROLE_MANAGER"), MemberStatus.ACTIVE);
69-
return memberEntities.stream()
70-
.map(memberPersistenceMapper::toDomain)
71-
.collect(Collectors.toList());
72-
}
73-
74-
@Override
75-
public int getRemainingTasks(Long memberId) {
76-
List<TaskStatus> targetStatuses = List.of(TaskStatus.IN_PROGRESS, TaskStatus.PENDING_COMPLETED);
77-
return findTasksByMemberIdAndStatus(memberId, targetStatuses).size();
78-
}
79-
80-
81-
@Override
82-
public List<Task> findTasksByMemberIdAndStatus(Long memberId, List<TaskStatus> taskStatuses) {
83-
List<TaskEntity> taskEntities = taskRepository.findByProcessor_MemberIdAndTaskStatusIn(memberId, taskStatuses);
84-
return taskEntities.stream()
85-
.map(taskPersistenceMapper::toDomain)
86-
.collect(Collectors.toList());
87-
}
8857
}
8958

src/main/java/clap/server/adapter/outbound/persistense/TaskPersistenceAdapter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package clap.server.adapter.outbound.persistense;
22

3+
import clap.server.adapter.inbound.web.dto.task.FilterPendingApprovalResponse;
34
import clap.server.adapter.inbound.web.dto.task.FilterTaskListRequest;
45
import clap.server.adapter.inbound.web.dto.task.FilterTaskListResponse;
5-
import clap.server.adapter.inbound.web.dto.task.FilterPendingApprovalResponse;
66
import clap.server.adapter.outbound.persistense.entity.task.TaskEntity;
77
import clap.server.adapter.outbound.persistense.mapper.TaskPersistenceMapper;
88
import clap.server.adapter.outbound.persistense.repository.task.TaskRepository;
@@ -58,5 +58,4 @@ public List<Task> findYesterdayTaskByDate(LocalDateTime now) {
5858
.stream().map(taskPersistenceMapper::toDomain).toList();
5959
}
6060

61-
6261
}

src/main/java/clap/server/adapter/outbound/persistense/repository/task/TaskRepository.java

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,19 +2,12 @@
22

33

44
import clap.server.adapter.outbound.persistense.entity.task.TaskEntity;
5-
import clap.server.adapter.outbound.persistense.entity.task.constant.TaskStatus;
65
import io.lettuce.core.dynamic.annotation.Param;
7-
86
import org.springframework.data.jpa.repository.JpaRepository;
97
import org.springframework.data.jpa.repository.Query;
10-
118
import org.springframework.stereotype.Repository;
129

13-
1410
import java.time.LocalDateTime;
15-
import java.util.Collection;
16-
17-
1811
import java.util.List;
1912

2013
@Repository
@@ -27,10 +20,6 @@ List<TaskEntity> findYesterdayTaskByUpdatedAtIsBetween(
2720
@Param("updatedAtAfter") LocalDateTime updatedAtAfter,
2821
@Param("updatedAtBefore") LocalDateTime updatedAtBefore
2922
);
30-
31-
32-
// 'processor'의 'id'로 검색하기
33-
List<TaskEntity> findByProcessor_MemberIdAndTaskStatusIn(Long memberId, Collection<TaskStatus> taskStatuses);
3423
}
3524

3625

src/main/java/clap/server/application/mapper/MemberMapper.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,14 @@
11
package clap.server.application.mapper;
22

33

4-
import clap.server.adapter.outbound.persistense.entity.member.constant.MemberRole;
5-
import clap.server.domain.model.member.Department;
64
import clap.server.adapter.inbound.web.dto.member.MemberProfileResponse;
75
import clap.server.domain.model.member.Member;
8-
import clap.server.domain.model.member.MemberInfo;
96

107
public class MemberMapper {
118
private MemberMapper() {
129
throw new IllegalArgumentException();
1310
}
1411

15-
public static Member toMember(MemberInfo memberInfo) {
16-
return Member.builder()
17-
.memberInfo(memberInfo)
18-
.build();
19-
}
20-
2112
public static MemberProfileResponse toMemberProfileResponse(Member member) {
2213
return new MemberProfileResponse(
2314
member.getMemberId(),

src/main/java/clap/server/application/port/inbound/domain/FindManagersUsecase.java

Lines changed: 0 additions & 8 deletions
This file was deleted.

src/main/java/clap/server/application/port/inbound/domain/FindManagersUsecaseImpl.java

Lines changed: 0 additions & 41 deletions
This file was deleted.

src/main/java/clap/server/application/port/inbound/domain/MemberService.java

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
import clap.server.application.port.outbound.member.LoadMemberPort;
44
import clap.server.domain.model.member.Member;
5-
import clap.server.domain.model.task.Task;
6-
import clap.server.adapter.outbound.persistense.entity.task.constant.TaskStatus;
75
import clap.server.exception.ApplicationException;
86
import clap.server.exception.code.MemberErrorCode;
97
import lombok.RequiredArgsConstructor;
@@ -26,33 +24,6 @@ public Member findActiveMember(Long memberId) {
2624
() -> new ApplicationException(MemberErrorCode.ACTIVE_MEMBER_NOT_FOUND));
2725
}
2826

29-
public int getRemainingTasks(Long memberId) {
30-
List<TaskStatus> targetStatuses = List.of(TaskStatus.IN_PROGRESS, TaskStatus.PENDING_COMPLETED);
31-
return loadMemberPort.findTasksByMemberIdAndStatus(memberId, targetStatuses).size();
32-
}
33-
34-
public String getMemberNickname(Long memberId) {
35-
Member member = findById(memberId);
36-
if (member.getMemberInfo() == null) {
37-
throw new ApplicationException(MemberErrorCode.MEMBER_NOT_FOUND);
38-
}
39-
return member.getMemberInfo().getNickname();
40-
}
41-
42-
public String getMemberImageUrl(Long memberId) {
43-
Member member = findById(memberId);
44-
return member.getImageUrl() != null ? member.getImageUrl() : "default-image-url";
45-
}
46-
47-
public List<Member> findActiveManagers() {
48-
List<Member> activeManagers = loadMemberPort.findActiveManagers();
49-
50-
if (activeManagers.isEmpty()) {
51-
return List.of();
52-
}
53-
return activeManagers;
54-
}
55-
5627
public List<Member> findReviewers() {
5728
return loadMemberPort.findReviewers();
5829
}

src/main/java/clap/server/application/port/outbound/member/LoadMemberPort.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,7 @@
11
package clap.server.application.port.outbound.member;
22

33
import clap.server.domain.model.member.Member;
4-
import clap.server.domain.model.task.Task; // Task 클래스 임포트 확인
5-
import clap.server.adapter.outbound.persistense.entity.task.constant.TaskStatus; // TaskStatus 임포트
4+
65
import java.util.List;
76
import java.util.Optional;
87

@@ -11,12 +10,6 @@ public interface LoadMemberPort {
1110

1211
Optional<Member> findActiveMemberById(Long id);
1312

14-
List<Member> findActiveManagers();
15-
16-
List<Task> findTasksByMemberIdAndStatus(Long memberId, List<TaskStatus> taskStatuses);
17-
18-
int getRemainingTasks(Long memberId);
19-
2013
Optional<Member> findByNickname(String nickname);
2114

2215
List<Member> findReviewers();

0 commit comments

Comments
 (0)