CLAP-284 fix:RegisterMemberCSVService 수정에 따른 test code 수정

Author: Sihun23

src/test/java/clap/server/application/service/admin/RegisterMemberCSVServiceTest.java

@@ -12,7 +12,6 @@
 import org.springframework.mock.web.MockMultipartFile;
 import org.springframework.web.multipart.MultipartFile;
 
-import java.io.IOException;
 import java.util.List;
 
 import static org.junit.jupiter.api.Assertions.*;
@@ -25,7 +24,6 @@ class RegisterMemberCSVServiceTest {
     private CommandMemberPort commandMemberPort;
     private CsvParseService csvParseService;
 
-
     @BeforeEach
     void setup() {
         memberService = Mockito.mock(MemberService.class);
@@ -35,30 +33,30 @@ void setup() {
     }
 
     /**
-     *  정상적인 회원 등록 테스트
-     * - 주어진 CSV 파일을 정상적으로 파싱하여 회원이 등록되는지 검증
+     * ✅ 정상적인 회원 등록 테스트
      */
     @Test
     @DisplayName("CSV 파일에서 회원 정보를 성공적으로 파싱하고 등록하는지 검증한다.")
     void testRegisterMembersFromCsvSuccess() {
         Long adminId = 1L;
-        MultipartFile file = new MockMultipartFile("file", "members.csv", "text/csv", "dummy-content".getBytes());
+        MultipartFile file = new MockMultipartFile("file", "members.csv", "text/csv", "name,nickname,departmentId,departmentRole,email,role,isReviewer\nJohn,JohnDoe,1,Manager,john.doe@example.com,ROLE_USER,TRUE".getBytes());
 
         Member admin = Mockito.mock(Member.class);
-        List<Member> parsedMembers = List.of(Mockito.mock(Member.class), Mockito.mock(Member.class));
+        Member member1 = Mockito.mock(Member.class);
+        Member member2 = Mockito.mock(Member.class);
+        List<Member> parsedMembers = List.of(member1, member2);
 
         when(memberService.findActiveMember(adminId)).thenReturn(admin);
         when(csvParseService.parseDataAndMapToMember(file)).thenReturn(parsedMembers);
 
         int addedCount = registerMemberCSVService.registerMembersFromCsv(adminId, file);
 
-        assertEquals(2, addedCount);
-        verify(commandMemberPort).saveAll(parsedMembers);
-        verify(parsedMembers.get(0)).register(admin);
-        verify(parsedMembers.get(1)).register(admin);
+        assertEquals(2, addedCount); // 2명이 성공적으로 등록됨
+        verify(commandMemberPort).saveAll(parsedMembers); // 모든 회원 저장
+        verify(member1).register(admin); // 관리자와 연결
+        verify(member2).register(admin); // 관리자와 연결
     }
 
-
     /**
      * ❌ 관리자 찾기 실패 (MEMBER_NOT_FOUND)
      */
@@ -74,9 +72,8 @@ void testRegisterMembersFromCsvThrowsWhenAdminNotFound() {
             registerMemberCSVService.registerMembersFromCsv(adminId, file);
         });
 
-        // 검증: 발생한 예외가 `MEMBER_NOT_FOUND`인지 확인
         assertEquals(MemberErrorCode.MEMBER_NOT_FOUND.getCustomCode(), exception.getCode().getCustomCode());
-        verifyNoInteractions(commandMemberPort); // 회원 저장 로직이 실행안됨
+        verifyNoInteractions(commandMemberPort); // 저장 로직 실행 안됨
     }
 
     /**
@@ -88,45 +85,39 @@ void testRegisterMembersFromCsvThrowsWhenCsvParsingFails() {
         Long adminId = 1L;
         MultipartFile file = new MockMultipartFile("file", "members.csv", "text/csv", "dummy-content".getBytes());
 
-        // ✅ Mock 객체 설정: CSV 파싱 과정에서 예외 발생하도록 설정
         when(csvParseService.parseDataAndMapToMember(file)).thenThrow(new ApplicationException(MemberErrorCode.CSV_PARSING_ERROR));
 
-        // 🔹 유스케이스 실행 및 예외 검증
         ApplicationException exception = assertThrows(ApplicationException.class, () -> {
             registerMemberCSVService.registerMembersFromCsv(adminId, file);
         });
 
-        // ✅ 검증: 발생한 예외가 `CSV_PARSING_ERROR`인지 확인
         assertEquals(MemberErrorCode.CSV_PARSING_ERROR.getCustomCode(), exception.getCode().getCustomCode());
-        verifyNoInteractions(commandMemberPort); // ❗ 회원 저장 로직이 실행되지 않아야 함
+        verifyNoInteractions(commandMemberPort); // 저장 로직 실행 안됨
     }
 
     /**
      * ❌ 회원 등록 실패 (MEMBER_REGISTRATION_FAILED)
-     *
      */
-//    @Test
-//    @DisplayName("회원 등록 과정 중 실패 시 예외 발생 및 부분 저장 된다.")
-//    void testRegisterMembersFromCsvThrowsWhenSavingMemberFails() {
-//        Long adminId = 1L;
-//        MultipartFile file = new MockMultipartFile("file", "members.csv", "text/csv", "dummy-content".getBytes());
-//
-//        Member admin = Mockito.mock(Member.class);
-//        Member failingMember = Mockito.mock(Member.class);
-//        List<Member> parsedMembers = List.of(failingMember, Mockito.mock(Member.class));
-//
-//        //  특정 회원 등록 중 예외 발생
-//        when(memberService.findActiveMember(adminId)).thenReturn(admin);
-//        when(csvParseService.parseDataAndMapToMember(file)).thenReturn(parsedMembers);
-//        doThrow(new ApplicationException(MemberErrorCode.MEMBER_REGISTRATION_FAILED))
-//                .when(commandMemberPort).save(failingMember);
-//
-//        // Usecase 실행
-//        ApplicationException exception = assertThrows(ApplicationException.class, () -> {
-//            registerMemberCSVService.registerMembersFromCsv(adminId, file);
-//        });
-//
-//        assertEquals(MemberErrorCode.MEMBER_REGISTRATION_FAILED.getCustomCode(), exception.getCode().getCustomCode());
-//        verify(commandMemberPort, times(1)).save(failingMember); // ❗ 실패한 회원만 저장 시도해야 함
-//    }
+    @Test
+    @DisplayName("회원 등록 과정 중 실패 시 예외 발생 및 회원 저장이 중단된다.")
+    void testRegisterMembersFromCsvThrowsWhenSavingMemberFails() {
+        Long adminId = 1L;
+        MultipartFile file = new MockMultipartFile("file", "members.csv", "text/csv", "dummy-content".getBytes());
+
+        Member admin = Mockito.mock(Member.class);
+        Member failingMember = Mockito.mock(Member.class);
+        List<Member> parsedMembers = List.of(failingMember);
+
+        when(memberService.findActiveMember(adminId)).thenReturn(admin);
+        when(csvParseService.parseDataAndMapToMember(file)).thenReturn(parsedMembers);
+        doThrow(new ApplicationException(MemberErrorCode.MEMBER_REGISTRATION_FAILED))
+                .when(commandMemberPort).saveAll(parsedMembers);
+
+        ApplicationException exception = assertThrows(ApplicationException.class, () -> {
+            registerMemberCSVService.registerMembersFromCsv(adminId, file);
+        });
+
+        assertEquals(MemberErrorCode.MEMBER_REGISTRATION_FAILED.getCustomCode(), exception.getCode().getCustomCode());
+        verify(commandMemberPort).saveAll(parsedMembers);
+    }
 }