Skip to content

Commit a652e54

Browse files
committed
CLAP-441 Refactor: 회원의 잔여 작업을 계산하는 메서드를 사용하도록 수정
#578
1 parent 1722873 commit a652e54

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/main/java/clap/server/application/mapper/response/TaskResponseMapper.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,12 +179,12 @@ public static FindApprovalFormResponse toFindApprovalFormResponse(Task task) {
179179
);
180180
}
181181

182-
public static FindManagersResponse toFindManagersResponse(Member manager, int remainingTasks) {
182+
public static FindManagersResponse toFindManagersResponse(Member manager) {
183183
return new FindManagersResponse(
184184
manager.getMemberId(),
185185
manager.getNickname(),
186186
manager.getImageUrl(),
187-
remainingTasks
187+
manager.getRemainingTasks()
188188
);
189189
}
190190

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package clap.server.application.service.task;
22

33
import clap.server.adapter.inbound.web.dto.task.response.FindManagersResponse;
4+
import clap.server.application.mapper.response.TaskResponseMapper;
45
import clap.server.application.port.inbound.domain.MemberService;
56
import clap.server.application.port.inbound.task.FindManagersUsecase;
67
import clap.server.common.annotation.architecture.ApplicationService;
@@ -10,8 +11,6 @@
1011

1112
import java.util.List;
1213

13-
import static clap.server.application.mapper.response.TaskResponseMapper.toFindManagersResponse;
14-
1514
@ApplicationService
1615
@RequiredArgsConstructor
1716
public class FindManagersService implements FindManagersUsecase {
@@ -23,10 +22,7 @@ public class FindManagersService implements FindManagersUsecase {
2322
public List<FindManagersResponse> findManagers() {
2423
List<Member> managers = memberService.findActiveManagers();
2524
return managers.stream()
26-
.map(manager -> {
27-
int remainingTasks = manager.getInProgressTaskCount() + manager.getInReviewingTaskCount();
28-
return toFindManagersResponse(manager, remainingTasks);
29-
}).toList();
25+
.map(TaskResponseMapper::toFindManagersResponse).toList();
3026
}
3127
}
3228
;

0 commit comments

Comments
 (0)