Skip to content

Commit b24a41c

Browse files
authored
Merge pull request #425 from TaskFlow-CLAP/CLAP-333
Clap-333 워딩 및 dto 수정
2 parents e82eed2 + 1f40f95 commit b24a41c

File tree

8 files changed

+25
-12
lines changed

8 files changed

+25
-12
lines changed

src/main/java/clap/server/adapter/inbound/web/dto/task/request/ApprovalTaskRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public record ApprovalTaskRequest(
1212
Long categoryId,
1313

1414
@NotNull
15-
@Schema(description = "처리자 ID",
15+
@Schema(description = "담당자 ID",
1616
example = "2")
1717
Long processorId,
1818

src/main/java/clap/server/adapter/inbound/web/dto/task/request/FilterTaskListRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public record FilterTaskListRequest(
2424
@NotNull
2525
String title,
2626

27-
@Schema(description = "요청자/처리자 닉네임", example = "atom.park")
27+
@Schema(description = "요청자/담당자 닉네임", example = "atom.park")
2828
@NotNull
2929
String nickName,
3030

src/main/java/clap/server/adapter/inbound/web/dto/task/request/FilterTeamStatusRequest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@ public record FilterTeamStatusRequest(
1212
SortBy sortBy,
1313

1414
@Schema(description = "1차 카테고리 ID 목록", example = "[10, 20, 30]")
15-
@NotBlank
15+
@NotNull
1616
List<Long> mainCategoryIds,
1717

1818
@Schema(description = "2차 카테고리 ID 목록", example = "[1, 2, 3]")
19+
@NotNull
1920
List<Long> categoryIds,
2021

2122
@Schema(description = "작업 타이틀 검색", example = "타이틀1")
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
package clap.server.adapter.inbound.web.dto.task.request;
2+
3+
import clap.server.adapter.outbound.persistense.entity.task.constant.TaskStatus;
4+
import jakarta.validation.constraints.NotNull;
5+
6+
public record UpdateTaskStatusRequest(
7+
@NotNull
8+
TaskStatus taskStatus
9+
) {
10+
}

src/main/java/clap/server/adapter/inbound/web/task/ChangeTaskController.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
import clap.server.adapter.inbound.web.dto.task.request.ApprovalTaskRequest;
55
import clap.server.adapter.inbound.web.dto.task.request.UpdateTaskLabelRequest;
66
import clap.server.adapter.inbound.web.dto.task.request.UpdateTaskProcessorRequest;
7+
import clap.server.adapter.inbound.web.dto.task.request.UpdateTaskStatusRequest;
78
import clap.server.adapter.inbound.web.dto.task.response.ApprovalTaskResponse;
89
import clap.server.adapter.outbound.persistense.entity.log.constant.LogStatus;
9-
import clap.server.adapter.outbound.persistense.entity.task.constant.TaskStatus;
1010
import clap.server.application.port.inbound.task.ApprovalTaskUsecase;
1111
import clap.server.application.port.inbound.task.UpdateTaskLabelUsecase;
1212
import clap.server.application.port.inbound.task.UpdateTaskProcessorUsecase;
@@ -36,6 +36,7 @@ public class ChangeTaskController {
3636
private final UpdateTaskProcessorUsecase updateTaskProcessorUsecase;
3737
private final UpdateTaskLabelUsecase updateTaskLabelUsecase;
3838
private final ApprovalTaskUsecase approvalTaskUsecase;
39+
3940
@LogType(LogStatus.STATUS_CHANGED)
4041
@Operation(summary = "작업 상태 변경")
4142
@Secured("ROLE_MANAGER")
@@ -45,13 +46,13 @@ public void updateTaskState(
4546
@AuthenticationPrincipal SecurityUserDetails userInfo,
4647
@Parameter(description = "변경하고 싶은 작업 상태",
4748
schema = @Schema(allowableValues = {"IN_PROGRESS", "IN_REVIEWING", "COMPLETED"}))
48-
@RequestBody TaskStatus taskStatus) {
49+
@RequestBody @Valid UpdateTaskStatusRequest request) {
4950

50-
updateTaskStatusUsecase.updateTaskStatus(userInfo.getUserId(), taskId, taskStatus);
51+
updateTaskStatusUsecase.updateTaskStatus(userInfo.getUserId(), taskId, request.taskStatus());
5152
}
5253

5354
@LogType(LogStatus.ASSIGNER_CHANGED)
54-
@Operation(summary = "작업 처리자 변경")
55+
@Operation(summary = "작업 담당자 변경")
5556
@Secured({"ROLE_MANAGER"})
5657
@PatchMapping("/{taskId}/processor")
5758
public void updateTaskProcessor(
@@ -70,6 +71,7 @@ public void updateTaskLabel(
7071
@Valid @RequestBody UpdateTaskLabelRequest updateTaskLabelRequest) {
7172
updateTaskLabelUsecase.updateTaskLabel(taskId, userInfo.getUserId(), updateTaskLabelRequest);
7273
}
74+
7375
@LogType(LogStatus.REQUEST_APPROVED)
7476
@Operation(summary = "작업 승인")
7577
@Secured({"ROLE_MANAGER"})

src/main/java/clap/server/adapter/outbound/persistense/entity/log/constant/LogStatus.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ public enum LogStatus {
1212
REQUEST_UPDATED("요청 수정"),
1313
REQUEST_CANCELLED("요청 취소"),
1414
REQUEST_APPROVED("요청 승인"),
15-
ASSIGNER_CHANGED("처리자 변경"),
15+
ASSIGNER_CHANGED("담당자 변경"),
1616
COMMENT_ADDED("댓글 추가"),
1717
COMMENT_UPDATED("댓글 수정"),
1818
STATUS_CHANGED("작업 상태 변경"),

src/main/java/clap/server/adapter/outbound/persistense/entity/notification/constant/NotificationType.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ public enum NotificationType {
99
COMMENT("댓글"),
1010
TASK_REQUESTED("작업 요청"),
1111
STATUS_SWITCHED("상태 전환"),
12-
PROCESSOR_ASSIGNED("처리자 할당"),
13-
PROCESSOR_CHANGED("처리자 변경"),
12+
PROCESSOR_ASSIGNED("담당자 할당"),
13+
PROCESSOR_CHANGED("담당자 변경"),
1414
INVITATION("회원가입 초대");
1515

1616
private final String description;

src/main/java/clap/server/adapter/outbound/persistense/entity/task/constant/TaskHistoryType.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ public enum TaskHistoryType {
99
COMMENT("댓글"),
1010
COMMENT_FILE("댓글 첨부파일"),
1111
STATUS_SWITCHED("상태 전환"),
12-
PROCESSOR_ASSIGNED("처리자 할당"),
13-
PROCESSOR_CHANGED("처리자 변경"),
12+
PROCESSOR_ASSIGNED("담당자 할당"),
13+
PROCESSOR_CHANGED("담당자 변경"),
1414
TASK_TERMINATED("작업 종료됨");
1515

1616
private final String description;

0 commit comments

Comments
 (0)