Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publishing NewPipe to Flathub #11597

Closed
6 tasks done
julianwi opened this issue Oct 7, 2024 · 15 comments
Closed
6 tasks done

Publishing NewPipe to Flathub #11597

julianwi opened this issue Oct 7, 2024 · 15 comments
Labels
feature request Issue is related to a feature in the app meta Related to the project but not strictly to code

Comments

@julianwi
Copy link

julianwi commented Oct 7, 2024

Checklist

  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I'm aware that this is a request for NewPipe itself and that requests for adding a new service need to be made at NewPipeExtractor.
  • I have taken the time to fill in all the required details. I understand that the feature request will be dismissed otherwise.
  • This issue contains only one feature request.
  • I have read and understood the contribution guidelines.

Feature description

Hi, I'm involved in the android translation layer project (https://gitlab.com/android_translation_layer). We are reimplementing the Android application API on top of GNU/Linux and Freedesktop technology. NewPipe is currently one of the best supported apps (nearly feature complete). We would like to know if you would be fine with publishing NewPipe to Flathub.

Why do you want this feature?

Our translation layer is very lightweight and can therefore be bundled into a Flatpak. I have created a Flatpak manifest for NewPipe here: https://gitlab.com/julianwi/newpipe_flatpak. It works really great and I think it would make sense to put it on Flathub, so that other people can use it as well.

Additional information

The size of the Flatpak is about 59MB. The largest parts are libart, libicu, libskia, framework-res.apk and NewPipe.apk, each of them about 10MB plus some smaller libraries. The common libraries can be split out into a Flatpak baseapp to be reused once we support more applications.
The first launch will take a few seconds to do the ahead-of-time compilation. Subsequent launches are nearly instant.
With the help of android translation layer, NewPipe integrates nicely into the Linux Desktop environment. Notifications are published to the XDG-desktop-portal, the playback can be controlled using MPRIS, the Light/Dark theme is automatically selected on startup, and the widget tree can be inspected using GTK-Inspector.

@julianwi julianwi added feature request Issue is related to a feature in the app needs triage Issue is not yet ready for PR authors to take up labels Oct 7, 2024
@theScrabi
Copy link
Member

Can you provide a Single File Bundle, so we can test it?

IMO You can do this, but you will have to be responsible for maintaining the flatpack package and the desktop experience. I think we are currently exhausted with the things we already have to do.

When you put NP on Flathub please mark it as experimental so if certain things don't yet work people will not come here and complain about things not working on Desktop.

@julianwi
Copy link
Author

julianwi commented Oct 7, 2024

Marking it as experimental is a good idea, as it has not been tested widely.

I created a single file bundle (arch=x86_64) of it here: https://gitlab.com/-/project/58175993/uploads/e45086f66a720cd4d354ed88ab3044ff/NewPipe.flatpak

@theScrabi
Copy link
Member

OMG this is awesome. Just in case someone is interested how it looks like:

NewPipe_flatpak.mov

@opusforlife2 opusforlife2 added meta Related to the project but not strictly to code and removed needs triage Issue is not yet ready for PR authors to take up labels Oct 7, 2024
@julianwi
Copy link
Author

Flathub submission was accepted. I will close this issue

@TobiGr
Copy link
Contributor

TobiGr commented Oct 27, 2024

@Poolitzer @opusforlife2 We might need to update the supported devices section on our website: https://newpipe.net/FAQ/#supported-devices

@Poolitzer
Copy link
Member

Poolitzer commented Oct 28, 2024

Appended in TeamNewPipe/website/pull/380 though I will try and add it to the next blog post.

@theScrabi
Copy link
Member

@julianwi how is the Android translation layer holding up with compose. Will NewPipe still be compatible once we do the transition?

@julianwi
Copy link
Author

@theScrabi, since composeui uses a lot of custom drawing, we need to implement some additional methods in android.graphics.Canvas, so it won't work out of the box, but there is no hard blocker.

@jhorner6511
Copy link

Honestly, making NewPipe available for Linux Desktop would be a game-changer. I haven't installed it from Flathub yet until it's verified and the kinks have all been worked out. But I'll be keeping an eye on it.

@theScrabi
Copy link
Member

@jhorner6511 keep in mind FreeTube is also an awesome alternative for desktop :)

@Fuseteam
Copy link

Fuseteam commented Nov 1, 2024

hey @julianwi i would like to test building a different app like you did with newpipe, where would the right avenue be for asking for details on how this works?

@julianwi
Copy link
Author

julianwi commented Nov 1, 2024

Hi @Fuseteam, the Translation Layer is not very feature complete in its current state. Basically we just implemented the APIs used by NewPipe and some other apps we care about. Therefore, any other random app will likely not work out of the box. To bring up a new app, you would need to build https://gitlab.com/android_translation_layer/android_translation_layer from source and implement the missing APIs yourself. Depending on the exact app that could be quite some work.

@Fuseteam
Copy link

Fuseteam commented Nov 1, 2024

hi @julianwi i understand that, the app i have in mind might be very similar to newpipe. but i don't want to derail this issue further by going into specifics. Is there a group/room where i can asks questions when i get stuck? or would a issue on gitlab suffice?

@julianwi
Copy link
Author

julianwi commented Nov 1, 2024

Hi @Fuseteam, yes, we recently created a matrix chat room: #android-translation-layer:matrix.org . Opening issues on Gitlab is also fine

@vitaly-zdanevich

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app meta Related to the project but not strictly to code
Projects
None yet
Development

No branches or pull requests

8 participants