From a85ece1980a8b6c72e1cc8c968440859d153592e Mon Sep 17 00:00:00 2001 From: Stypox Date: Tue, 16 Jul 2024 06:23:09 +0200 Subject: [PATCH] Improve wording in 2024-06-23-schabi-contract.md --- _posts/2024-06-23-schabi-contract.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/_posts/2024-06-23-schabi-contract.md b/_posts/2024-06-23-schabi-contract.md index 5cc33e7..3a7749e 100644 --- a/_posts/2024-06-23-schabi-contract.md +++ b/_posts/2024-06-23-schabi-contract.md @@ -29,9 +29,9 @@ After consultation between the members of the e.V., we decided to accept his pro Schabi's main job will be to rewrite the player code, one of the most important yet most broken parts of the NewPipe app. The NewPipe team will provide him with specific tasks in a timely manner, which might include reviewing, bugfixing, documenting or releasing, but will mostly revolve around the player, due to the short nature of the contract. All of the code Schabi writes will obviously be published under the GPLv3 free software license, like the rest of the app. -Rewriting the player is an important part of [the refactoring process](https://github.com/TeamNewPipe/NewPipe/discussions/10118) we announced a year ago. After hearing the feedback from many experts in that discussion, we decided not to rewrite everything from scratch, since it would just take too much time, and risk the app being abandoned entirely. Rather, it will be done incrementally. +Rewriting the player is an important part of [the refactoring process](https://github.com/TeamNewPipe/NewPipe/discussions/10118) we announced a year ago. After hearing the feedback from many experts in that discussion, we decided not to rewrite the whole app from scratch, since it would just take too much time, and risk the app being abandoned entirely. Rather, it will be done incrementally. -However, the situation with the player is different: there have already been [too](https://github.com/TeamNewPipe/NewPipe/pull/8170) [many](https://github.com/TeamNewPipe/NewPipe/pull/10578) [failed](https://github.com/TeamNewPipe/NewPipe/pull/8678) [or](https://github.com/TeamNewPipe/NewPipe/pull/2907) [incomplete](https://github.com/TeamNewPipe/NewPipe/pull/7349) [attempts](https://github.com/TeamNewPipe/NewPipe/issues/8616) at refactoring it one piece at a time, so rewriting it from scratch is probably the best idea. Moreover, the ExoPlayer standalone library was deprecated in favour of its integration in the Jetpack Media3 library, which has partially different APIs, so we would need to rethink large parts of the code anyway. +However, the situation with the player is different than the rest of the app: there have already been [too](https://github.com/TeamNewPipe/NewPipe/pull/8170) [many](https://github.com/TeamNewPipe/NewPipe/pull/10578) [failed](https://github.com/TeamNewPipe/NewPipe/pull/8678) [or](https://github.com/TeamNewPipe/NewPipe/pull/2907) [incomplete](https://github.com/TeamNewPipe/NewPipe/pull/7349) [attempts](https://github.com/TeamNewPipe/NewPipe/issues/8616) at refactoring it one piece at a time, so rewriting it from scratch is probably the best idea. Moreover, the ExoPlayer standalone library was deprecated in favour of its integration in the Jetpack Media3 library, which has partially different APIs, so we would need to rethink large parts of the code anyway. Side note, if you are reading this blog post and would like to contribute to the refactoring process, take a look at the tracking issues [one (Jetpack Compose)](https://github.com/TeamNewPipe/NewPipe/issues/11198) and [two (Kotlin)](https://github.com/TeamNewPipe/NewPipe/issues/11199) that were recently opened. Also, please reach out to us via Matrix [#newpipe:matrix.newpipe-ev.de](https://matrix.to/#/#newpipe:matrix.newpipe-ev.de) or IRC ([#newpipe on Libera.Chat](https://web.libera.chat/#newpipe)).