Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] [BUG] Cannot adjust sync on songs played from new Favorites feature #717

Open
cilynx opened this issue Jan 2, 2024 · 2 comments
Labels
Branch: Alpha-5-Steam Bugs related to Alpha V mainline (0.5.x) on Steam Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) Community: Good First Issue Good for newcomers Engine: Gameplay Gameplay Related Issues Engine: Profiles This issue affects the profile system, or adds to the new profile system Engine: Theme Affects the Theme Platform: ARM/Raspberry/Rock Pi ARM / Raspberry Pi / Rock Pi Platform Priority: Medium Things we should really fix! Status: Investigating We are looking into this one! Status: Not Implemented Yet! This is a request that has no codepath or is incomplete/not implemented yet in the codebase Type: Bug Something is broken in the code

Comments

@cilynx
Copy link

cilynx commented Jan 2, 2024

Game Mode

dance

Give an example of what is wrong

Playing on OutFox-alpha-0.5.0-pre042-18.04-arm64-arm64v8-modern-date-20231225, adding and removing favorites works and the special Favorites category shows up in the chooser, but when songs are played from Favorites as opposed to their actual location, the song sync features do not work correctly. The proper text shows up on the screen and when adjusting manually, the text updates with the new offset, but the actual offset doesn't change -- the arrows don't advance / retard relative to the music like they do when playing a song from the folder it's actually in.

Give an example of what it should look like

Arrows should advance / retard relative to the music when the sync is adjusted on songs played from Favorites the same way it works when songs are played from their actual folders.

@Scraticus Scraticus added Type: Bug Something is broken in the code Community: Good First Issue Good for newcomers Platform: ARM/Raspberry/Rock Pi ARM / Raspberry Pi / Rock Pi Platform Engine: Gameplay Gameplay Related Issues Engine: Theme Affects the Theme Status: Investigating We are looking into this one! Engine: Profiles This issue affects the profile system, or adds to the new profile system Priority: Medium Things we should really fix! Status: Not Implemented Yet! This is a request that has no codepath or is incomplete/not implemented yet in the codebase Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) Branch: Alpha-5-Steam Bugs related to Alpha V mainline (0.5.x) on Steam labels Jan 14, 2024
@Scraticus
Copy link
Member

confirmed, needs to be coded to support that feature.

@Scraticus Scraticus changed the title [Nitpick] Cannot adjust sync on songs played from new Favorites feature [Feature Request] [BUG] Cannot adjust sync on songs played from new Favorites feature Jan 14, 2024
@JoseVarelaP
Copy link
Member

JoseVarelaP commented Jan 27, 2024

After checking the issue, and seeing it happen, I can confirm that this is caused by another issue: The file flush bug found in #718.

The sync screen does save the data, but because of that bug, its not reflected immediately in-game.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch: Alpha-5-Steam Bugs related to Alpha V mainline (0.5.x) on Steam Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) Community: Good First Issue Good for newcomers Engine: Gameplay Gameplay Related Issues Engine: Profiles This issue affects the profile system, or adds to the new profile system Engine: Theme Affects the Theme Platform: ARM/Raspberry/Rock Pi ARM / Raspberry Pi / Rock Pi Platform Priority: Medium Things we should really fix! Status: Investigating We are looking into this one! Status: Not Implemented Yet! This is a request that has no codepath or is incomplete/not implemented yet in the codebase Type: Bug Something is broken in the code
Projects
None yet
Development

No branches or pull requests

3 participants