Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] chart editor playback rate is broken [in 48khz] #720

Open
1 task done
teleshoes opened this issue Jan 25, 2024 · 4 comments
Open
1 task done

[BUG] chart editor playback rate is broken [in 48khz] #720

teleshoes opened this issue Jan 25, 2024 · 4 comments
Labels
Type: Bug Something is broken in the code

Comments

@teleshoes
Copy link

Is there an existing issue for this?

  • I have searched the existing issues and none matched.

Operating System

Linux

CPU

No response

GPU

No response

Storage

No response

Game Version

5.0.0-042

Game Mode

I was using the editor!

Theme

No response

Describe the problem

  • open editor, select a song and difficulty, edit existing
  • play a song to see the rate
  • change playback Rate in the Options menu from 1.0 to 0.5
  • start playing song again. rate is FASTER, AND the pitch is higher. (pitch adjusting used to work correctly)
  • arrow timing is now unrelated to the song playback, though both are faster than they were before
  • without changing the rate, select a region of arrows, and start playing again. rate is faster again, and pitch is even higher (interestingly, by about a semitone)

one more thing that might warrant a separate bug report, but is worth mentioning here in case its somehow related.
in the editor, the song options menu behaves as if there are two players, and both players must confirm the options before continuing. this confused me for awhile since i dont have bindings set for P2 and couldn't figure out how to even set the options for awhile.

Describe what should happen

rate should match the selected rate, audio playback should be faster but pitch-adjusted so the pitch sounds the same, and arrow timings should be correct.

it is, obviously, important that arrow timings be perfectly accurate (which they are in sm5.0b2 and sm5.1). my main purpose when using this tool is to micro-adjust BPM and timings measure-by-measure in non-edm songs with organic tempos.

Relevant Log output

No response

@JoseVarelaP
Copy link
Member

Can you show in video form how this is happening? Or share your Preferences.ini file? I legit cannot recreate this issue on my Mac and another one in the team who runs Linux cannot either after testing every audio driver.

The two player issue has already been reported for a while: #467

@teleshoes
Copy link
Author

sent on discord. (ah, i didn't search for the 2p bug, thanks!)
maybe it's the sample rate? the songs i'm editing are 48k vorbis. i just tried a 44k vorbis and it worked fine (both songs work fine in sm5.1)

working: Stream #0:0: Audio: vorbis, 44099 Hz, stereo, fltp, 196 kb/s
broken: Stream #0:0: Audio: vorbis, 48000 Hz, stereo, fltp, 112 kb/s

@teleshoes
Copy link
Author

ok, it DOES seem to only be broken for 48khz sample rate songs. i converted my song to 44.1khz and its working fine.
(48khz is apparently the default for vorbis audio output in ffmpeg, for whatever reason, so this is why all of the step charts i write have been broken)

@teleshoes
Copy link
Author

teleshoes commented Jan 28, 2024

EDIT: removed this comment. i mixed up global offset while switching prefs back and forth between sm and outfox

=> with songs at 44.1kHz, rate works perfectly in pre042 and sm5.1, as far as i can tell
48kHz songs are still broken in pre042 (and working in sm5.1)

@teleshoes teleshoes changed the title [BUG] chart editor playback rate is broken [BUG] chart editor playback rate is broken [in 48khz] Jan 28, 2024
@JoseVarelaP JoseVarelaP added the Type: Bug Something is broken in the code label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something is broken in the code
Projects
None yet
Development

No branches or pull requests

2 participants