Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nitpick] Edit Mode play preview breaks select-start command #722

Open
teleshoes opened this issue Jan 28, 2024 · 2 comments
Open

[Nitpick] Edit Mode play preview breaks select-start command #722

teleshoes opened this issue Jan 28, 2024 · 2 comments
Assignees
Labels
Engine: Different SM5 behaviour This feature or action is different in SM5 or below Status: Investigating We are looking into this one! Type: Nitpick Just one more thing,

Comments

@teleshoes
Copy link

Game Mode

dance

Give an example of what is wrong

spacebar toggles the new play-preview mode, which plays the music and scrolls the arrows without leaving the editor screen.
(which sounds like a cool feature, but in practice, i have found it is useless compared to just normal play-testing with P, since it doesn't respect speedmod or let you test judgments)

spacebar used to mark the selection start, and then the selection end, which can be accomplished in either version with shift+arrow or shift+pgup/dn etc.

HOWEVER, spacebar to mark the selection start, WITHOUT marking the selection end, was a very useful feature. it let you play from that spot on, without looping back, and then hit ESC and p again to start at the same spot (setting just a start time, not an end time). this lets you quickly playtest a section a few times, going as far as you like each time, then mark a different start spot.

there is no way (that i know of) to do that now, you are forced to make a full selection, which involves many keystrokes instead of literally just one, and also forces you to pick an end time, which is usually irrelevant.

maybe someone else would find the play-preview mode useful, but it shouldn't come at the expense of the most valuable keybinding, and shouldn't remove a feature completely.

Give an example of what it should look like

  • add back in a way to mark selection-start, even if its not mapped to spacebar
  • move the play-preview mode to shift+p or something, since it's so similar, and definitely not the most vital command
  • have spacebar mark selection-start again, or maybe do something else useful
@JoseVarelaP JoseVarelaP added Engine: Different SM5 behaviour This feature or action is different in SM5 or below Type: Nitpick Just one more thing, labels Feb 5, 2024
@JoseVarelaP
Copy link
Member

HOWEVER, spacebar to mark the selection start, WITHOUT marking the selection end, was a very useful feature. it let you play from that spot on, without looping back, and then hit ESC and p again to start at the same spot (setting just a start time, not an end time).

This feature was never removed, it is still present when using the current selection marker key (Tab). This is a case of usage of legacy editor controls.
I am working on a mapping screen so you can just remap these buttons back, but it might take a bit given how the input system was added before I took a crack at it.

2024-02-06.13-58-21.mp4

@JoseVarelaP JoseVarelaP self-assigned this Feb 6, 2024
@JoseVarelaP JoseVarelaP added the Status: Investigating We are looking into this one! label Feb 6, 2024
@teleshoes
Copy link
Author

awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engine: Different SM5 behaviour This feature or action is different in SM5 or below Status: Investigating We are looking into this one! Type: Nitpick Just one more thing,
Projects
None yet
Development

No branches or pull requests

2 participants