Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Noteskin texture coord offsets don't seem to be accurate #747

Open
1 task done
bonimy opened this issue Jul 9, 2024 · 1 comment
Open
1 task done

[BUG] Noteskin texture coord offsets don't seem to be accurate #747

bonimy opened this issue Jul 9, 2024 · 1 comment
Labels
Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) Engine: Noteskins Affects Noteskins

Comments

@bonimy
Copy link

bonimy commented Jul 9, 2024

Is there an existing issue for this?

  • I have searched the existing issues and none matched.

Operating System

Windows 10

CPU

Intel

GPU

gefore 3080 ti

Storage

2TB SSD

Game Version

5.0.0-042

Game Mode

dance

Theme

No response

Describe the problem

I have a 1x9 hold note graphic
_Down holda 1x9 (res 64x576)

And I'm still using a 16x8 tap note graphic
_Down Tap Note 16x8

I'm following the advice that came in my metrics.ini

#This is the TextureCoordOffset which we use for Rhythm colored noteskins
#If you dont want to use it, just keep the value 0
#Rhythm colored noteskins are noteskins that have different colors for every
#4th, 8th, 12th, 16th and so on
#To use this you need to use simple math because it isnt based on the size of
#the image but its based on the total value of the size which is 1
#So if you got 9 frames (including  192nd)
#You need to run this simple math
# 1 / 9 = 0.11111111111111111111111111 (and so on)

But when I set HoldHeadNoteColorTextureCoordSpacingY=0.111111111, the graphics get cut off incorrectly. I have to set it to 0.0625 (halving its original value of 0.125). I'm not sure if this is supposed to be right. If so, why do I need to halve this offset just for changing the graphic from 1x8 to 1x9.

Another issue: Zero length holds seem to still use TapNoteNoteColorTextureCoordSpacingY for its offset, so I get results like this
image

Describe what should happen

No response

Relevant Log output

No response

@moruzerinho6 moruzerinho6 added Engine: Noteskins Affects Noteskins Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) labels Jul 9, 2024
@MrThatKid
Copy link
Member

first issue:
That sounds like you need to add another metric to your noteskin
HoldHeadNoteColorCount=9
This tells the game that your hold heads have a 192nd color and your 0.111111111 texture coord offset should work afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Branch: Alpha-5 Bugs related to Alpha V mainline (0.5.x) Engine: Noteskins Affects Noteskins
Projects
None yet
Development

No branches or pull requests

3 participants