Add additional data-loss prevention logic

Author: TechUnRestricted

WinDiskWriter GUI/Windows/MainWindow/MainWindow.m

@@ -527,10 +527,14 @@ - (void)writeAction {
     [self setIsScheduledForStop: NO];
     [self setEnabledUIState: NO];
 
-    DiskInfo *destinationDiskInfo = [(IdentifiableMenuItem *)devicePickerView.selectedItem diskInfo];
-    DiskManager *destinationDiskDM = [[DiskManager alloc] initWithBSDName:destinationDiskInfo.BSDName];
+    // Saved information from the last device scanning operation
+    DiskInfo *destinationSavedDiskInfo = [(IdentifiableMenuItem *)devicePickerView.selectedItem diskInfo];
 
-    if (destinationDiskDM == NULL || !destinationDiskInfo.isDeviceUnit) {
+    // Making sure that the selected BSD Device name is still available
+    DiskManager *secondVerifyingStageDiskManager = [[DiskManager alloc] initWithBSDName:destinationSavedDiskInfo.BSDName];
+    DiskInfo *secondVerifyingStageDiskInfo = [secondVerifyingStageDiskManager diskInfo];
+
+    if (secondVerifyingStageDiskManager == NULL || !destinationSavedDiskInfo.isDeviceUnit) {
         [self displayWarningAlertWithTitle: BSD_DEVICE_IS_NO_LONGER_AVAILABLE_TITLE
                                   subtitle: PRESS_UPDATE_BUTTON_SUBTITLE
                                       icon: NSImageNameCaution];
@@ -540,6 +544,23 @@ - (void)writeAction {
         WriteExitForce();
     }
 
+    /* !!DATA-LOSS PREVENTION!!
+    - We need to make sure that we will format exactly the device that was selected in the list
+    of available devices, and not the one that managed to occupy the vacated BSD Name.
+    - The most adequate way in this case is to verify the initialization date of the bsd device. */
+    
+    if (destinationSavedDiskInfo.appearanceTime.doubleValue != secondVerifyingStageDiskInfo.appearanceTime.doubleValue) {
+        [self displayWarningAlertWithTitle: BSD_DEVICE_INFO_IS_OUTDATED_OR_INVALID
+                                  subtitle: PRESS_UPDATE_BUTTON_SUBTITLE
+                                      icon: NSImageNameCaution];
+        
+        [logsAutoScrollTextView appendTimestampedLine: BSD_DEVICE_INFO_IS_OUTDATED_OR_INVALID
+                                              logType: ASLogTypeFatal];
+        
+        WriteExitForce();
+    }
+    
+    
     NSError *imageMountError = NULL;
     NSString *mountedImagePath = [HelperFunctions getWindowsSourceMountPath: windowsImageInputView.stringValue
                                                                       error: &imageMountError];
@@ -583,9 +604,9 @@ - (void)writeAction {
                                           logType: ASLogTypeLog];
 
     NSString *diskEraseOperationText = [NSString stringWithFormat:@"Device %@ (%@ %@) is ready to be erased with the following properties: (partition_name: \"%@\", partition_scheme: \"%@\", filesystem: \"%@\", patch_security_checks: \"%d\").",
-                                        destinationDiskInfo.BSDName,
-                                        destinationDiskInfo.deviceVendor,
-                                        destinationDiskInfo.deviceModel,
+                                        destinationSavedDiskInfo.BSDName,
+                                        destinationSavedDiskInfo.deviceVendor,
+                                        destinationSavedDiskInfo.deviceModel,
                                         newPartitionName,
                                         selectedPartitionScheme,
                                         selectedFileSystem,
@@ -600,7 +621,7 @@ - (void)writeAction {
         [self setCurrentProgressTitle: @"Formatting the drive"];
 
         NSError *diskEraseError = NULL;
-        [destinationDiskDM diskUtilEraseDiskWithPartitionScheme: selectedPartitionScheme
+        [secondVerifyingStageDiskManager diskUtilEraseDiskWithPartitionScheme: selectedPartitionScheme
                                                      filesystem: selectedFileSystem
                                                         newName: newPartitionName
                                                           error: &diskEraseError];

windiskwriter.xcodeproj/project.xcworkspace/xcuserdata/macintosh.xcuserdatad/UserInterfaceState.xcuserstate

@@ -8,7 +8,7 @@
          BreakpointExtensionID = "Xcode.Breakpoint.FileBreakpoint">
          <BreakpointContent
             uuid = "4DBFFC7E-88C3-4A3B-A0DF-311137DBE2FB"
-            shouldBeEnabled = "Yes"
+            shouldBeEnabled = "No"
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "windiskwriter/DiskManager/DiskManager.m"
@@ -20,5 +20,21 @@
             landmarkType = "7">
          </BreakpointContent>
       </BreakpointProxy>
+      <BreakpointProxy
+         BreakpointExtensionID = "Xcode.Breakpoint.FileBreakpoint">
+         <BreakpointContent
+            uuid = "82B006E0-C658-4F1B-BEA4-5E77555847F0"
+            shouldBeEnabled = "Yes"
+            ignoreCount = "0"
+            continueAfterRunningActions = "No"
+            filePath = "WinDiskWriter GUI/Windows/MainWindow/MainWindow.m"
+            startingColumnNumber = "9223372036854775807"
+            endingColumnNumber = "9223372036854775807"
+            startingLineNumber = "553"
+            endingLineNumber = "553"
+            landmarkName = "-writeAction"
+            landmarkType = "7">
+         </BreakpointContent>
+      </BreakpointProxy>
    </Breakpoints>
 </Bucket>

windiskwriter.xcodeproj/xcuserdata/macintosh.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist

@@ -29,6 +29,8 @@ extern NSString * const CHECK_DATA_CORRECTNESS_TITLE;
 extern NSString * const NO_AVAILABLE_DEVICES_TITLE;
 extern NSString * const PRESS_UPDATE_BUTTON_SUBTITLE;
 extern NSString * const BSD_DEVICE_IS_NO_LONGER_AVAILABLE_TITLE;
+extern NSString * const BSD_DEVICE_INFO_IS_OUTDATED_OR_INVALID;
+
 extern NSString * const IMAGE_VERIFICATION_ERROR_TITLE;
 extern NSString * const DISK_ERASE_FAILURE_TITLE;
 extern NSString * const DISK_ERASE_SUCCESS_TITLE;

windiskwriter/Constants.h

@@ -28,6 +28,8 @@ @implementation Constants
 NSString * const NO_AVAILABLE_DEVICES_TITLE = @"No writable devices found.";
 NSString * const PRESS_UPDATE_BUTTON_SUBTITLE = @"Connect a compatible USB device and click on the Update button.";
 NSString * const BSD_DEVICE_IS_NO_LONGER_AVAILABLE_TITLE = @"Chosen Device is no longer available.";
+NSString * const BSD_DEVICE_INFO_IS_OUTDATED_OR_INVALID = @"The information about this device is outdated or invalid.";
+
 NSString * const IMAGE_VERIFICATION_ERROR_TITLE = @"Can't verify this Image.";
 NSString * const DISK_ERASE_FAILURE_TITLE = @"Can't erase the destionation device.";
 NSString * const DISK_ERASE_SUCCESS_TITLE = @"The destination device was successfully erased.";