Peer code review - business site - Julia #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
September 11, 2025 23:11
HIPPIEKICK
approved these changes
Sep 24, 2025
Contributor
HIPPIEKICK
left a comment
HIPPIEKICK
left a comment
There was a problem hiding this comment.
You’ve managed well with implementing both Flexbox and CSS Grid. Your JS works well - kudos for adding some extra features there 🥳
Just be aware that when adding preventDefault() the form will not actually be submitted (which I think is fine, because this is not an actual form where users submit data).
Another thing to be mindful of is your sticky header - I think it looks so nice but it gets a bit hard to read when there’s other content behind it. Consider adding some background to it for better readability.
Comment on lines
+338
to
+343
| <form | ||
| id="contact-form" | ||
| class="form-contact" | ||
| action="http://httpbin.org/anything" | ||
| method="post" | ||
| > |
Contributor
There was a problem hiding this comment.
Make sure to use the https method, as some browser will otherwise block this action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://demijuls-technigo-project1.netlify.app/