Add unit tests #15

zbalkan · 2025-12-05T20:47:41Z

Adding unit tests for the library

Copilot

Pull request overview

This PR adds comprehensive unit test coverage for the TechnitiumLibrary using MSTest framework, targeting .NET 9.0. The changes include both a new test project with test cases for existing functionality and several defensive programming improvements to the library code itself, such as null checks and stream validation.

New test project TechnitiumLibrary.Tests with MSTest.Sdk 4.0.1
Added null validation checks to TaskPool, CollectionExtensions, and Base32 classes
Enhanced stream validation in BinaryNumber to detect incomplete reads

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
TechnitiumLibrary.sln	Updates solution to include new test project; Visual Studio version updated
TechnitiumLibrary.Tests/TechnitiumLibrary.Tests.csproj	Configures new MSTest project targeting .NET 9.0 with nullable enabled
TechnitiumLibrary.Tests/MSTestSettings.cs	Enables method-level test parallelization for improved test performance
TechnitiumLibrary.Tests/TaskPoolTests.cs	Tests for TaskPool including concurrency, disposal, and state handling
TechnitiumLibrary.Tests/IndependentTaskSchedulerTests.cs	Tests for IndependentTaskScheduler covering execution, concurrency, and disposal
TechnitiumLibrary.Tests/CollectionExtensionsTests.cs	Tests for collection extension methods including Shuffle, Convert, and equality operations
TechnitiumLibrary.Tests/BinaryNumberTests.cs	Comprehensive tests for BinaryNumber including constructors, operators, parsing, and serialization
TechnitiumLibrary.Tests/Base32Tests.cs	Tests for Base32 and Base32Hex encoding/decoding with RFC vector validation
TechnitiumLibrary/TaskPool.cs	Adds null check for task parameter in TryQueueTask method
TechnitiumLibrary/CollectionExtensions.cs	Adds null checks for array/collection and converter function parameters
TechnitiumLibrary/BinaryNumber.cs	Adds stream length validation to detect incomplete reads during deserialization
TechnitiumLibrary/Base32.cs	Adds null and whitespace validation for decode operations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

TechnitiumLibrary.Tests/TechnitiumLibrary/TaskPoolTests.cs

TechnitiumLibrary/Base32.cs

TechnitiumLibrary/CollectionExtensions.cs

TechnitiumLibrary/Base32.cs

TechnitiumLibrary/CollectionExtensions.cs

TechnitiumLibrary.Tests/TechnitiumLibrary/TaskPoolTests.cs

TechnitiumLibrary.Tests/TechnitiumLibrary/BinaryNumberTests.cs

TechnitiumLibrary.Tests/TechnitiumLibrary/IndependentTaskSchedulerTests.cs

…mplete before shutdown

zbalkan · 2025-12-07T22:03:06Z

I wrote tests for every major project except for the most important and largest one TechnitiumLibrary.Net. It will take a long time. But without it, I cannot move on to writing tests for DnsServer project.

Since my annual leave ends tonight, there will be less changes to be done. But still, I'll progress slowly.

If you will have refactoring in TechnitiumLibrary.Net project, please let me know, so that I can start afterwards. In the meanwhile, I can work on other things like small plugins.

Copilot

Pull request overview

Copilot reviewed 33 out of 33 changed files in this pull request and generated 14 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-07T22:08:39Z

TechnitiumLibrary.Security.OTP/Authenticator.cs

        }

-        public bool IsTOTPValid(string totp, byte fudge = 10)
+        public bool IsTOTPValid(string totp, int windowSteps = 1)


The parameter rename from fudge to windowSteps is clearer, but changing the default value from 10 to 1 is a breaking change that significantly reduces the time window for valid TOTP codes. This could break existing deployments that rely on the wider tolerance window. Consider using a default value of 10 to maintain backward compatibility, or clearly document this as a breaking change.

Suggested change

public bool IsTOTPValid(string totp, int windowSteps = 1)

public bool IsTOTPValid(string totp, int windowSteps = 10)

Copilot · 2025-12-07T22:08:39Z

TechnitiumLibrary.Security.OTP/Authenticator.cs

+            if (KeyUri.Digits < 6 || KeyUri.Digits > 8)
+                throw new ArgumentOutOfRangeException(nameof(keyUri), "Digits should be 6–8 per common TOTP deployments.");


The added range validation for Digits (6-8) is too restrictive. RFC 6238 allows 6-10 digits, and the original code supported any value the caller specified. This could break existing code using 9 or 10 digits. Consider removing this validation or expanding the range to 6-10 per RFC 6238.

Suggested change

if (KeyUri.Digits < 6 || KeyUri.Digits > 8)

throw new ArgumentOutOfRangeException(nameof(keyUri), "Digits should be 6–8 per common TOTP deployments.");

if (KeyUri.Digits < 6 || KeyUri.Digits > 10)

throw new ArgumentOutOfRangeException(nameof(keyUri), "Digits should be 6–10 per RFC 6238.");

Copilot · 2025-12-07T22:08:39Z

TechnitiumLibrary.Tests/TechnitiumLibrary.IO/BinaryWriterExtensionsTests.cs

+    {
+        private static (BinaryWriter writer, MemoryStream stream) CreateWriter()
+        {
+            var ms = new MemoryStream();


Disposable 'MemoryStream' is created but not disposed.

Copilot · 2025-12-07T22:08:40Z

TechnitiumLibrary.Tests/TechnitiumLibrary.IO/BinaryWriterExtensionsTests.cs

+        private static (BinaryWriter writer, MemoryStream stream) CreateWriter()
+        {
+            var ms = new MemoryStream();
+            var bw = new BinaryWriter(ms);


Disposable 'BinaryWriter' is created but not disposed.

Copilot · 2025-12-07T22:08:40Z

TechnitiumLibrary.Tests/TechnitiumLibrary.IO/PackageItemTests.cs

+
+        private static PackageItem Roundtrip(PackageItem source)
+        {
+            var buffer = new MemoryStream(); // do NOT dispose here


Disposable 'MemoryStream' is created but not disposed.

Suggested change

var buffer = new MemoryStream(); // do NOT dispose here

using var buffer = new MemoryStream();

Copilot · 2025-12-07T22:08:41Z

TechnitiumLibrary.Tests/TechnitiumLibrary.IO/JointTests.cs

+            Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s1.Length; });
+            Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s2.Length; });


This assignment to _ is useless, since its value is never read.

Suggested change

Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s1.Length; });

Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s2.Length; });

Assert.ThrowsExactly<ObjectDisposedException>(() => { var unused = s1.Length; });

Assert.ThrowsExactly<ObjectDisposedException>(() => { var unused = s2.Length; });

Copilot · 2025-12-07T22:08:41Z

TechnitiumLibrary.Tests/TechnitiumLibrary.IO/JointTests.cs

+            Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s1.Length; });
+            Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s2.Length; });


This assignment to _ is useless, since its value is never read.

Suggested change

Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s1.Length; });

Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s2.Length; });

Assert.ThrowsExactly<ObjectDisposedException>(() => { var unused = s1.Length; });

Assert.ThrowsExactly<ObjectDisposedException>(() => { var unused = s2.Length; });

Copilot · 2025-12-07T22:08:42Z

TechnitiumLibrary.Tests/TechnitiumLibrary.IO/PackageItemTests.cs

+
+            Assert.ThrowsExactly<IOException>(() =>
+            {
+                var _ = PackageItem.Parse(buffer);


This assignment to _ is useless, since its value is never read.

Suggested change

var _ = PackageItem.Parse(buffer);

PackageItem.Parse(buffer);

Copilot · 2025-12-07T22:08:42Z

TechnitiumLibrary.Tests/TechnitiumLibrary.IO/PackageTests.cs

+
+            Assert.ThrowsExactly<IOException>(() =>
+            {
+                var _ = pkg.Items;


This assignment to _ is useless, since its value is never read.

Suggested change

var _ = pkg.Items;

pkg.Items;

Copilot · 2025-12-07T22:08:42Z

TechnitiumLibrary.Security.OTP/Authenticator.cs

        {
-            HMAC hmac = null;
-            try
+            HMAC hmac = algorithm.ToUpperInvariant() switch


This variable is manually disposed in a finally block - consider a C# using statement as a preferable resource management technique.

…ion.

zbalkan added 12 commits December 5, 2025 10:43

Added error handling cases to functions

4452d0f

Added first unit tests

63db9b4

Added BinaryNumber unit tests

aa0dab0

Added size check to BinaryNumber ctor

f7ec3c4

Added unit tests for BinaryNumber

c8fff7a

Added null-check to TryQueueTask

bc05ec3

Unit tests for TaskPool

042f836

Added tests for IndependentTaskScheduler class

a6dc0a9

USed .NET 9.0

f1af538

Added null checks for collection extensions

ac2b92a

Added tests for CollectionExtensions

b7d779a

Minor improvement an supressions

237e5d0

Copilot AI review requested due to automatic review settings December 5, 2025 20:47

zbalkan marked this pull request as draft December 5, 2025 20:47

Copilot started reviewing on behalf of zbalkan December 5, 2025 20:48 View session

Moved tests under project-specific folder for cleaner structure.

9b8120c

Copilot AI reviewed Dec 5, 2025

View reviewed changes

zbalkan added 13 commits December 5, 2025 22:56

Added unit tests for JsonExtensions class

0d01eb5

Added unit tests for StringExtensions class

ee17507

Added tests for TaskExtensions class

604a640

Rolled solution version back to VS2022 for compatibility

7f2a2e1

Response to review

52864ec

Added another edge case

5f7abea

Added folders for the projects to be covered

60f0333

Added ByteTree tests

5bbdcef

Added binary stream size check

ffba37b

Added tests for BinaryReaderExtensions

46737f4

Added tests for BinaryWriterExtensions

ce45c4f

Improve disposal behavior in Joint to guarantee both stream copies co…

33d4857

…mplete before shutdown

Added tests for Joint class

b553de0

zbalkan added 9 commits December 7, 2025 21:35

Added DatetimeKind

a38ba53

Formatting

9203414

Marked private class sealed

843cc9b

Removed duplicate test

eb8b4aa

Added WindowsFirewall tests

c870dcc

Added tests for OTP

b4cfd82

Formatting

12d3a0b

Added minor improvements and validations to Authenticator

f8d0dca

Aded tests for Authenticator

c3df12c

zbalkan requested a review from Copilot December 7, 2025 22:04

Copilot started reviewing on behalf of zbalkan December 7, 2025 22:04 View session

Copilot AI reviewed Dec 7, 2025

View reviewed changes

zbalkan added 17 commits December 9, 2025 12:42

Added null, empty and whitespace checks for DomainEndPoint validation

6e1f25b

Wrote tests for DomainEndPoint class

5e1ad36

Cleaned up unused usings

8dea00d

Fixed null handling. Null domain name returns false instead of except…

39850a0

…ion.

Added tests for IPAddressExtensions class

42e6768

Simplified tests in ByteTreeTests

f7b48e1

Refactored GetNetworkAddress

3101bc3

Fixed extra octet edge case with tests

606a398

Added null-check to IsPrivateIP

97c1d79

Formatting

88f8976

Added tests for NetUtilities class

8a7a31e

Improved TryParse with validations

8284bb4

Added tests for EndPointExtensions class

5018042

Improved port validation

28e4bb6

Added unit tests for NetworkAccessControl

0b92ce3

Added unit tests for NetworkAddress class

adff737

Added unit tests and improved parsing for NetworkMap class

1c2bb5d

	public bool IsTOTPValid(string totp, int windowSteps = 1)
	public bool IsTOTPValid(string totp, int windowSteps = 10)

		if (KeyUri.Digits < 6 \|\| KeyUri.Digits > 8)
		throw new ArgumentOutOfRangeException(nameof(keyUri), "Digits should be 6–8 per common TOTP deployments.");

	var buffer = new MemoryStream(); // do NOT dispose here
	using var buffer = new MemoryStream();

		Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s1.Length; });
		Assert.ThrowsExactly<ObjectDisposedException>(() => { var _ = s2.Length; });

	var _ = PackageItem.Parse(buffer);
	PackageItem.Parse(buffer);

Add unit tests #15

Are you sure you want to change the base?

Add unit tests #15

Uh oh!

Conversation

zbalkan commented Dec 5, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zbalkan commented Dec 7, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant