Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup failure when using %d on db_filter #312

Open
pedrocs-exo opened this issue Jan 29, 2022 · 0 comments
Open

Backup failure when using %d on db_filter #312

pedrocs-exo opened this issue Jan 29, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@pedrocs-exo
Copy link

Since #286, file common.yaml.jinja contains this:

services:
backup:
environment:
DBS_TO_INCLUDE: "{{ odoo_dbfilter }}"

meaning that databases will be backed up only if they match the odoo_dbfilter regular expression. However, on multi-tenant deployments, it's quite common to have a value of ^%d$ on that parameter leading to a configuration where no database backups will be performed.

Replacing it with odoo_dbname doesn't work either. We may want to use values like db1,db2,dbx. and that also disables backups.

IMHO a better solution would be to turn it into a user defined param. And it's default value could eventually be the result of replacing comma (,) by pipe (|) on odoo_dbname. For example: db1,db2,dbx would become db1|db2|dbx. It would work for single databases as well as for database lists.

@pedrocs-exo pedrocs-exo added the bug Something isn't working label Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant