From b6e4651f83a6d53cebdcf65eade576d55d2a4860 Mon Sep 17 00:00:00 2001 From: mingshewhe Date: Thu, 17 Dec 2020 18:16:25 +0800 Subject: [PATCH] =?UTF-8?q?fix:=20ScmFactory=E5=AF=B9svn=E7=9A=84region?= =?UTF-8?q?=E5=AD=97=E6=AE=B5=E4=B8=8D=E5=90=88=E7=90=86=E7=9A=84=E4=BD=BF?= =?UTF-8?q?=E7=94=A8=20#3288?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../src/main/kotlin/com/tencent/devops/scm/ScmFactory.kt | 9 +-------- .../kotlin/com/tencent/devops/scm/ScmOauthFactory.kt | 9 +-------- 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/src/backend/ci/core/common/common-scm/src/main/kotlin/com/tencent/devops/scm/ScmFactory.kt b/src/backend/ci/core/common/common-scm/src/main/kotlin/com/tencent/devops/scm/ScmFactory.kt index c6e7d7b18b5..86b77f8b4d4 100644 --- a/src/backend/ci/core/common/common-scm/src/main/kotlin/com/tencent/devops/scm/ScmFactory.kt +++ b/src/backend/ci/core/common/common-scm/src/main/kotlin/com/tencent/devops/scm/ScmFactory.kt @@ -56,13 +56,6 @@ object ScmFactory { ): IScm { return when (type) { ScmType.CODE_SVN -> { - if (region == null) { - throw TaskExecuteException( - errorCode = ErrorCode.USER_RESOURCE_NOT_FOUND, - errorType = ErrorType.USER, - errorMsg = "The svn region is null" - ) - } if (userName == null) { throw TaskExecuteException( @@ -168,4 +161,4 @@ object ScmFactory { ) } } -} \ No newline at end of file +} diff --git a/src/backend/ci/core/common/common-scm/src/main/kotlin/com/tencent/devops/scm/ScmOauthFactory.kt b/src/backend/ci/core/common/common-scm/src/main/kotlin/com/tencent/devops/scm/ScmOauthFactory.kt index 52c73991ab9..b16878dcbeb 100644 --- a/src/backend/ci/core/common/common-scm/src/main/kotlin/com/tencent/devops/scm/ScmOauthFactory.kt +++ b/src/backend/ci/core/common/common-scm/src/main/kotlin/com/tencent/devops/scm/ScmOauthFactory.kt @@ -54,13 +54,6 @@ object ScmOauthFactory { ): IScm { return when (type) { ScmType.CODE_SVN -> { - if (region == null) { - throw TaskExecuteException( - errorCode = ErrorCode.USER_INPUT_INVAILD, - errorType = ErrorType.USER, - errorMsg = "The svn region is null" - ) - } if (userName == null) { throw TaskExecuteException( @@ -126,4 +119,4 @@ object ScmOauthFactory { ) } } -} \ No newline at end of file +}