Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port GenericTensorNetworks #57

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Port GenericTensorNetworks #57

merged 4 commits into from
Aug 14, 2023

Conversation

GiggleLiu
Copy link
Member

@GiggleLiu GiggleLiu commented Aug 13, 2023

  1. Convert a GraphProblem to a TensorNetworkModel or a MMAPModel
  2. Allows setting unity tensors manually with the flexibility to compute joint marginal probabilities.

We can solve a set of inference problems on a collection of combinatorial optimization problems now, cheers!

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #57 (3059164) into main (2615430) will increase coverage by 0.65%.
The diff coverage is 96.15%.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   81.59%   82.24%   +0.65%     
==========================================
  Files           9       10       +1     
  Lines         489      507      +18     
==========================================
+ Hits          399      417      +18     
  Misses         90       90              
Files Changed Coverage Δ
src/mar.jl 94.54% <50.00%> (-0.10%) ⬇️
src/Core.jl 46.29% <100.00%> (ø)
src/TensorInference.jl 100.00% <100.00%> (ø)
src/generictensornetworks.jl 100.00% <100.00%> (ø)
src/map.jl 100.00% <100.00%> (ø)

@GiggleLiu GiggleLiu requested a review from mroavi August 14, 2023 03:59
Copy link
Collaborator

@mroavi mroavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good.
My only suggestion would be: what about if we use marvars instead of mars? Adds a little bit more of a self-description since mars is a little too vague in my opinion. What do you think?

@GiggleLiu
Copy link
Member Author

mars is a vector containing vectors of variables. Each inner vector is a set of variables for computing joint marginal probability distribution.

To make it distinct from openvars, I use mars rather than marvars.

@mroavi mroavi merged commit b292dd4 into main Aug 14, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants