Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ModuleTestingEnvironment and CoreAdvancedAssets dependencies optional #16

Open
jdrueckert opened this issue May 18, 2020 · 1 comment
Open

Make ModuleTestingEnvironment and CoreAdvancedAssets dependencies optional #16

jdrueckert opened this issue May 18, 2020 · 1 comment
Labels
Good First Issue Good for learners that are new to Terasology

Comments

@jdrueckert
Copy link
Member

Only references to CoreAdvancedAssets are in tests.
Health has ModuleTestingEnvironment as optional dependency as it's only required for testing (see https://github.com/Terasology/Health/blob/develop/module.txt#L9).
Also, consider to not test with chest from CoreAdvancedAssets but with another block.
@jdrueckert jdrueckert added the Good First Issue Good for learners that are new to Terasology label May 18, 2020
@skaldarnar
Copy link
Contributor

In #17 @keturn revealed that the tests rely on Health module to be able to send DoDamage events.
We should investigate whether this test really makes sense as it is, or whether we can reduce the amount of (optional) dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for learners that are new to Terasology
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@skaldarnar @jdrueckert