Merge #7

7: Producer#CreateMessage: Separate from struct and use []byte values r=Jaskaranbir a=Jaskaranbir



Co-authored-by: Jaskaranbir <jaskaranbir.dhillon@gmail.com>

Author: ninja-bruh

README.md

@@ -72,7 +72,7 @@ go func() {
 }()
 
 strTime := strconv.Itoa(int(time.Now().Unix()))
-msg := asyncProducer.CreateKeyMessage("test", strTime, "testValue")
+msg := producer.CreateKeyMessage("test", strTime, []byte("testValue"))
 
 input, _ := asyncProducer.Input()
 input <- msg // Produce message

producer/producer.go

@@ -68,25 +68,6 @@ func (p *Producer) EnableLogging() {
 	p.isLoggingEnabled = true
 }
 
-// CreateKeyMessage creates producer-formatted message with key
-func (p *Producer) CreateKeyMessage(topic string, key string, value string) *sarama.ProducerMessage {
-	msg := &sarama.ProducerMessage{
-		Topic: topic,
-		Value: sarama.StringEncoder(value),
-	}
-
-	if key != "" {
-		msg.Key = sarama.StringEncoder(key)
-	}
-
-	return msg
-}
-
-// CreateMessage creates keyless producer-formatted message
-func (p *Producer) CreateMessage(topic string, value string) *sarama.ProducerMessage {
-	return p.CreateKeyMessage(topic, "", value)
-}
-
 // IsClosed returns a bool specifying if Kafka producer is closed
 func (p *Producer) IsClosed() bool {
 	return p.isClosed

producer/producerutils.go

@@ -0,0 +1,22 @@
+package producer
+
+import "github.com/Shopify/sarama"
+
+// CreateKeyMessage creates producer-formatted message with key
+func CreateKeyMessage(topic string, key string, value []byte) *sarama.ProducerMessage {
+	msg := &sarama.ProducerMessage{
+		Topic: topic,
+		Value: sarama.ByteEncoder(value),
+	}
+
+	if key != "" {
+		msg.Key = sarama.StringEncoder(key)
+	}
+
+	return msg
+}
+
+// CreateMessage creates keyless producer-formatted message
+func CreateMessage(topic string, value []byte) *sarama.ProducerMessage {
+	return CreateKeyMessage(topic, "", value)
+}