Merge #10

10: Remove interrupt-signal handler r=Jaskaranbir a=Jaskaranbir

Its better to be implemented by the library-user side.

Co-authored-by: Jaskaranbir <jaskaranbir.dhillon@gmail.com>

Author: ninja-bruh

kafka/consumer.go

@@ -2,10 +2,6 @@ package kafka
 
 import (
 	"context"
-	"log"
-	"os"
-	"os/signal"
-	"syscall"
 	"time"
 
 	"github.com/Shopify/sarama"
@@ -70,7 +66,6 @@ func NewConsumer(config *ConsumerConfig) (*Consumer, error) {
 		consumerGroup: consumerGroup,
 		topics:        config.Topics,
 	}
-	consumer.handleKeyInterrupt()
 	return consumer, nil
 }
 
@@ -98,23 +93,6 @@ func (c *Consumer) SaramaConsumer() *sarama.ConsumerGroup {
 	return &c.consumerGroup
 }
 
-func (c *Consumer) handleKeyInterrupt() {
-	// Capture the Ctrl+C signal (interrupt or kill)
-	sigChan := make(chan os.Signal, 1)
-	signal.Notify(sigChan,
-		syscall.SIGINT,
-		syscall.SIGTERM,
-		syscall.SIGQUIT)
-
-	// Elegant exit
-	go func() {
-		<-sigChan
-		log.Println("Keyboard-Interrupt signal received, cleaning up before closing")
-		closeError := c.consumerGroup.Close()
-		log.Println(closeError)
-	}()
-}
-
 // Close stops the ConsumerGroup and detaches any running sessions. It is required to call
 // this function before the object passes out of scope, as it will otherwise leak memory.
 func (c *Consumer) Close() error {

kafka/producer.go

@@ -1,11 +1,6 @@
 package kafka
 
 import (
-	"log"
-	"os"
-	"os/signal"
-	"syscall"
-
 	"github.com/Shopify/sarama"
 	"github.com/pkg/errors"
 )
@@ -46,26 +41,5 @@ func NewProducer(config *ProducerConfig) (*Producer, error) {
 	}
 
 	asyncProducer := Producer{producer}
-	asyncProducer.handleKeyInterrupt()
 	return &asyncProducer, nil
 }
-
-func (p *Producer) handleKeyInterrupt() {
-	// Capture the Ctrl+C signal (interrupt or kill)
-	sigChan := make(chan os.Signal, 1)
-	signal.Notify(sigChan,
-		syscall.SIGINT,
-		syscall.SIGTERM,
-		syscall.SIGQUIT)
-
-	// Elegant exit
-	go func() {
-		<-sigChan
-		// We always log here, special situation
-		log.Println("Keyboard-Interrupt signal received.")
-		err := p.Close()
-		if err != nil {
-			log.Println(err.Error())
-		}
-	}()
-}