Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webpack 5 Regression] TerriaMap now requires terriajs devDependencies #730

Open
pjonsson opened this issue Feb 19, 2025 · 0 comments
Open

Comments

@pjonsson
Copy link
Contributor

pjonsson commented Feb 19, 2025

@na9da #726 passed the CI before this change (but after the ESLint update), but I just rebased it and it now fails:

ERROR in ./node_modules/terriajs/test/Models/Catalog/CatalogGroups/OpenDataSoftCatalogGroupSpec.ts:6:23
TS2307: Cannot find module 'fetch-mock' or its corresponding type declarations.
    4 | import OpenDataSoftCatalogItem from "../../../../lib/Models/Catalog/CatalogItems/OpenDataSoftCatalogItem";
    5 | import Terria from "../../../../lib/Models/Terria";
  > 6 | import fetchMock from "fetch-mock";
      |                       ^^^^^^^^^^^^
    7 |
    8 | import facets from "../../../../wwwroot/test/ods/facets.json";
    9 | import datasets from "../../../../wwwroot/test/ods/datasets.json";

The difference is from commit 28aa111 to commit 10c2192.

Originally posted by @pjonsson in #718 (comment)

It seems the test files have been included in the terriajs-package before, so I'm guessing something changed with the updated webpack config.

@pjonsson pjonsson changed the title [Webpack 5 Regession] TerriaMap now requires terriajs devDependencies [Webpack 5 Regression] TerriaMap now requires terriajs devDependencies Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant