Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPretty Py3 Support #80

Closed
BenjamenMeyer opened this issue Oct 23, 2019 · 2 comments
Closed

HTTPretty Py3 Support #80

BenjamenMeyer opened this issue Oct 23, 2019 · 2 comments
Labels
bug enhancement help wanted
Milestone
Future Work/Backlog

Comments

@BenjamenMeyer
Copy link
Member

The current unit tests support HTTPretty 0.8.6 without any issue; however, 0.8.6 only supports Python2. For Python3 support HTTPretty 0.9.7 is required, but this breaks the unit tests.

For now, HTTPretty on Py3 is officially unsupported here. That's not to say it won't work just that it has been too big an issue to get working with the time available to do so as there seems to be some kind of regex related error internal to HTTPretty 0.9.7 related to StackInABox's callback usage.

Help to fix this is of course welcome and appreciated.
@BenjamenMeyer BenjamenMeyer added this to the Future Work/Backlog milestone Oct 23, 2019
BenjamenMeyer added a commit to BenjamenMeyer/stackInABox that referenced this issue Oct 23, 2019
@BenjamenMeyer
Enhancement: Update test environment and dependencies
a97d406 
- Enhancement: Update the dependencies to the latest supported
  versions.
- Note: See Issue TestInABox#80 related to updating HTTPretty
- Enhancement: Moved generic infrastructure to generic Py3 support
  so that it should always run.
- Bug: Added a note regarding HTTPretty support
- Enhancement: Refactored how the thread local object is accessed;
  this should improve parallel processing support.
- Enhancement: Various Py3 support enhancements
- Enhancement: Moved general tests that utilize a util module to
  requests_mock from HTTPretty due to the issues with HTTPretty
- Enhancement: Added a Pypy3 test environment
@BenjamenMeyer BenjamenMeyer mentioned this issue Oct 23, 2019
Merged
@BenjamenMeyer
Copy link
Member Author

This seems to be fixed in httpretty now, so once the dependencies can get fully updated per #87 then this can be closed.

@BenjamenMeyer
Copy link
Member Author

Latest httpretty is now used by the tests per #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement help wanted
Projects
None yet
Milestone
Future Work/Backlog
Development

No branches or pull requests
1 participant
@BenjamenMeyer