Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiwikDeviceDetector Provider error #77

Closed
simtabi opened this issue Mar 30, 2016 · 2 comments
Closed

PiwikDeviceDetector Provider error #77

simtabi opened this issue Mar 30, 2016 · 2 comments
Labels

Comments

@simtabi
Copy link

simtabi commented Mar 30, 2016

Hi,
I a using the latest version of this library. Now theres an issue. Not sure if its a bug.
I already have this library installed PiwikDeviceDetector but i keep getting the following exception error. You need to install the package piwik/device-detector to use this provider. I have done all i could to debug but i can seem to find a solution. The only one is to comment out the following:
public function __construct(DeviceDetector $parser = null)

    {
        if ($parser === null && ! file_exists('vendor/' . $this->getPackageName() . '/composer.json')) {
         Icommented this line - // throw new PackageNotLoadedException('You need to install the package ' . $this->getPackageName() . ' to use this provider');
        }

        $this->parser = $parser;
    }

I moved the requested library into the vendor/ directory as its supposed to, but it didn't solve either.

I am on windows and it doesn't allow this kind of file naming structure piwik/device-detector, because i believe this is the directory that is being looked, and since it can not be located, an error is thrown.

Any suggestions?

@ThaDafinser
Copy link
Owner

he ho @simtabi 😄

It seems you have not installed the two packages with https://getcomposer.org/

Currently that is the only supported way to install this package. Otherwise you need to uncomment that check like you mentioned above.

A bit releated to #61 (custom vendor directory with composer)

@ThaDafinser
Copy link
Owner

I am on windows and it doesn't allow this kind of file naming structure piwik/device-detector

@simtabi i'm on windows as well - that work. Those are 2 seperate directories (maybe then you get it working without composer)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant