You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve#3
Edited the angle part for the sp3d2 hybridisation
Even Created a case for the molecule SF6(sp3d2 hybridised)
Included the radio button for sp3d2 and added sf6 to sample molucules
Added S and F to the Atom counters useState to be shown in the dropdown
This for the second atom for the bond to be made
Now in the molecule.js
Created a function calcSp3d2bondDirection which aclculates the unit vector representing the bond direction for a new ligand in an sp3d2 system.and also returns a default unit vector ([1,0,0]) if no good direction found.
Used normalizeVector which convert calculated directions into unit vectors.
Used validatePlanarArrangement checks if a set of bonds forms a planar arrangement(all bonds with same plaen).
and used getPlaneNormal which calculates the normal vector to the plane formed by the first two bonds .
OUTPUT SCREEN
Showing for the double bond.
Pls review.🫡🫡
@priyansh-narang2308 thank you for the detailed pr that you have made.
But the output for SF6 shd be something like this right?
Can you please clarify what exactly is the output that you got?
In the mean time I will also try it locally
When I checked locally all the atoms are in the spawn point and the bonds are not formed (edges are not being created) ... did you change any logic of creating the bonds @priyansh-narang2308 ?
Yeahh in my system earlier it was working but as soon as i created the helper functions idk what happened the bonds were not created and it was showing an error
I rectified the whole code but was unable to find the error. So this was the issue. I guess the issue lied within the helper fucntions bcoz of what the logic of bonds got breakk.
And the same happened with SF6 the edges were not being created.
And if this doesn't work can this issue be assigned to someone else as i have exams coming up and will not be able to complete within the deadline. And the main issue was during the helper function it self. I mixed up the helper function with the logic of creating bondss.
Sorry for the inconvenience. @TharunKumarrA
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #3
Edited the angle part for the sp3d2 hybridisation
Even Created a case for the molecule SF6(sp3d2 hybridised)
Included the radio button for sp3d2 and added sf6 to sample molucules
Added S and F to the Atom counters useState to be shown in the dropdown
This for the second atom for the bond to be made
Now in the molecule.js
Created a function calcSp3d2bondDirection which aclculates the unit vector representing the bond direction for a new ligand in an sp3d2 system.and also returns a default unit vector ([1,0,0]) if no good direction found.
Used normalizeVector which convert calculated directions into unit vectors.
Used validatePlanarArrangement checks if a set of bonds forms a planar arrangement(all bonds with same plaen).
and used getPlaneNormal which calculates the normal vector to the plane formed by the first two bonds .
OUTPUT SCREEN
Showing for the double bond.
Pls review.🫡🫡